[GitHub] [flink] klion26 opened a new pull request #8313: [FLINK-12184][coordinator]HistoryServerArchieFetcher incompatible with old version

[GitBox <gi...@apache.org>]

klion26 opened a new pull request #8313: [FLINK-12184][coordinator]HistoryServerArchieFetcher incompatible with old version
URL: https://github.com/apache/flink/pull/8313
 
 
   ## What is the purpose of the change
   
   If we have old verison json files in history server, the HistoryServerArchiveFetcher can't convert legacy job overview. It will throw the NullPointerException when trying to convert legacy job overview because the tasks don't have the "pending" field.
   
   There are actually two paths for the legacy job overview to consider, one is coming from Flink < 1.4 where we actually wrote the pending field and the other is for Flink >= 1.4 (legacy mode) which split the pending field up into scheduled, deployed and created.
   
   
   ## Brief change log
   Add a condition check and add the right state.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   `HistoryServerTest#testHistoryServerIntegration`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (**no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**no**)
     - The serializers: (**no**)
     - The runtime per-record code paths (performance sensitive): (**no**)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**no**)
     - The S3 file system connector: (**no**)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**no**)
     - If yes, how is the feature documented? (**not applicable**)
   @tillrohrmann @yumengz5
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services