You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@accumulo.apache.org by David Medinets <da...@gmail.com> on 2012/09/08 14:51:30 UTC

Should SiteConfiguration getInstance be sychronized?

Findbugs is warning (Incorrect lazy initialization and update of
static field) about the following code:

  public static SiteConfiguration getInstance(AccumuloConfiguration parent) {
    if (instance == null) {
      instance = new SiteConfiguration(parent);
      ConfigSanityCheck.validate(instance);
    }
    return instance;
  }

Re: Should SiteConfiguration getInstance be sychronized?

Posted by Eric Newton <er...@gmail.com>.

Yes, it should be synchronized, though it's harmless if it is initialized
multiple times.

On Sat, Sep 8, 2012 at 8:51 AM, David Medinets <da...@gmail.com>wrote:

> Findbugs is warning (Incorrect lazy initialization and update of
> static field) about the following code:
>
>   public static SiteConfiguration getInstance(AccumuloConfiguration
> parent) {
>     if (instance == null) {
>       instance = new SiteConfiguration(parent);
>       ConfigSanityCheck.validate(instance);
>     }
>     return instance;
>   }
>