[GitHub] [flink] lincoln-lil commented on a change in pull request #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value.

[GitBox <gi...@apache.org>]

lincoln-lil commented on a change in pull request #9285: [FLINK-13433][table-planner-blink]  Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value.
URL: https://github.com/apache/flink/pull/9285#discussion_r309062404
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/LookupJoinITCase.scala
 ##########
 @@ -418,4 +432,101 @@ class LookupJoinITCase extends StreamingTestBase {
     assertEquals(0, userTableSource.getResourceCounter)
   }
 
+  @Test
+  def testJoinTemporalTableOnMultiKeyFieldsWithNullData(): Unit = {
+    implicit val tpe: TypeInformation[Row] = new RowTypeInfo(
 
 Review comment:
   this rowTypeInfo can be reused for several cases

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services