You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/03/25 06:02:37 UTC

[GitHub] [incubator-gobblin] jhsenjaliya commented on a change in pull request #2936: Fail YarnAppLaunch if there's existing AM with configuration

jhsenjaliya commented on a change in pull request #2936: Fail YarnAppLaunch if there's existing AM with configuration
URL: https://github.com/apache/incubator-gobblin/pull/2936#discussion_r397625106
 
 

 ##########
 File path: gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java
 ##########
 @@ -499,6 +504,14 @@ void stopYarnClient() {
   private Optional<ApplicationId> getApplicationId() throws YarnException, IOException {
 
 Review comment:
   should this function name changed to `getOrCreateNewYarnApplication` ? just a thought

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services