You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Benedikt Ritter <br...@apache.org> on 2017/06/16 08:50:38 UTC
[CLI] Changing the code style
Hi,
CLI unlike other components has a custom code style. While other components pretty much follow the Sun code guidelines, the CLI code base uses a style like the Maven project. For me it’s annoying the switch code style configurations between components. If nobody objects, I’d like to apply the same rules like we have them in lang or text. I’m also going to enforce this rules using checkstyle and will make checkstyle part of the Travis CI build.
Cheers,
Benedikt
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [CLI] Changing the code style
Posted by Amey Jadiye <am...@gmail.com>.
+1, keeping same discipline throughout components is always better, I liked
the way Lang and Text is maintained at this point.
not only checkstyle but findbug, clirr, javadoc also should passed clean
for each component.
Regards,
Amey
On Fri, Jun 16, 2017 at 2:20 PM, Benedikt Ritter <br...@apache.org> wrote:
> Hi,
>
> CLI unlike other components has a custom code style. While other
> components pretty much follow the Sun code guidelines, the CLI code base
> uses a style like the Maven project. For me it’s annoying the switch code
> style configurations between components. If nobody objects, I’d like to
> apply the same rules like we have them in lang or text. I’m also going to
> enforce this rules using checkstyle and will make checkstyle part of the
> Travis CI build.
>
> Cheers,
> Benedikt
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [CLI] Changing the code style
Posted by "Bruno P. Kinoshita" <br...@yahoo.com.br.INVALID>.
No objection from me. +1 and thanks for taking care of it :)
Cheers
Bruno
________________________________
From: Benedikt Ritter <br...@apache.org>
To: Commons Developers List <de...@commons.apache.org>
Sent: Friday, 16 June 2017 8:50 PM
Subject: [CLI] Changing the code style
Hi,
CLI unlike other components has a custom code style. While other components pretty much follow the Sun code guidelines, the CLI code base uses a style like the Maven project. For me it’s annoying the switch code style configurations between components. If nobody objects, I’d like to apply the same rules like we have them in lang or text. I’m also going to enforce this rules using checkstyle and will make checkstyle part of the Travis CI build.
Cheers,
Benedikt
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [CLI] Changing the code style
Posted by Gary Gregory <ga...@gmail.com>.
On Fri, Jun 16, 2017 at 1:50 AM, Benedikt Ritter <br...@apache.org> wrote:
> Hi,
>
> CLI unlike other components has a custom code style. While other
> components pretty much follow the Sun code guidelines, the CLI code base
> uses a style like the Maven project. For me it’s annoying the switch code
> style configurations between components. If nobody objects, I’d like to
> apply the same rules like we have them in lang or text. I’m also going to
> enforce this rules using checkstyle and will make checkstyle part of the
> Travis CI build.
>
+1
Gary
>
> Cheers,
> Benedikt
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>