You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Qifan Chen (Code Review)" <ge...@cloudera.org> on 2020/10/28 18:22:58 UTC

[Impala-ASF-CR] IMPALA-10267: Impala crashes in HdfsScanner::WriteTemplateTuples() with negative num tuples

Qifan Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16672


Change subject: IMPALA-10267: Impala crashes in HdfsScanner::WriteTemplateTuples() with negative num_tuples
......................................................................

IMPALA-10267: Impala crashes in HdfsScanner::WriteTemplateTuples() with negative num_tuples

This fix enhances method HdfsAvroScanner::ProcessRange() with a DCHECK()
to help catch negative num_tuples. The DCHEK() specifically checks that
num_records_in_block_ is always greater than record_pos_.

Testing:
1. Unit testing.

Change-Id: If88fd3aa4c96a69e37d060031f7432d27d069c62
---
M be/src/exec/hdfs-avro-scanner.cc
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/16672/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If88fd3aa4c96a69e37d060031f7432d27d069c62
Gerrit-Change-Number: 16672
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10267: Impala crashes in HdfsScanner::WriteTemplateTuples() with negative num tuples

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16672 )

Change subject: IMPALA-10267: Impala crashes in HdfsScanner::WriteTemplateTuples() with negative num_tuples
......................................................................

IMPALA-10267: Impala crashes in HdfsScanner::WriteTemplateTuples() with negative num_tuples

This fix enhances method HdfsAvroScanner::ProcessRange() with a DCHECK()
to help catch negative num_tuples. The DCHEK() specifically checks that
num_records_in_block_ is always greater than record_pos_.

Testing:
1. Unit testing.

Change-Id: If88fd3aa4c96a69e37d060031f7432d27d069c62
Reviewed-on: http://gerrit.cloudera.org:8080/16672
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
---
M be/src/exec/hdfs-avro-scanner.cc
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Joe McDonnell: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/16672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If88fd3aa4c96a69e37d060031f7432d27d069c62
Gerrit-Change-Number: 16672
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10267: Impala crashes in HdfsScanner::WriteTemplateTuples() with negative num tuples

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16672 )

Change subject: IMPALA-10267: Impala crashes in HdfsScanner::WriteTemplateTuples() with negative num_tuples
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If88fd3aa4c96a69e37d060031f7432d27d069c62
Gerrit-Change-Number: 16672
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Oct 2020 00:07:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10267: Impala crashes in HdfsScanner::WriteTemplateTuples() with negative num tuples

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16672 )

Change subject: IMPALA-10267: Impala crashes in HdfsScanner::WriteTemplateTuples() with negative num_tuples
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7575/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If88fd3aa4c96a69e37d060031f7432d27d069c62
Gerrit-Change-Number: 16672
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Oct 2020 18:44:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10267: Impala crashes in HdfsScanner::WriteTemplateTuples() with negative num tuples

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16672 )

Change subject: IMPALA-10267: Impala crashes in HdfsScanner::WriteTemplateTuples() with negative num_tuples
......................................................................


Patch Set 2:

This makes sense to me. I'm going to kick off a test run. When it succeeds, I'll approve.


-- 
To view, visit http://gerrit.cloudera.org:8080/16672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If88fd3aa4c96a69e37d060031f7432d27d069c62
Gerrit-Change-Number: 16672
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Oct 2020 18:39:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10267: Impala crashes in HdfsScanner::WriteTemplateTuples() with negative num tuples

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16672 )

Change subject: IMPALA-10267: Impala crashes in HdfsScanner::WriteTemplateTuples() with negative num_tuples
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If88fd3aa4c96a69e37d060031f7432d27d069c62
Gerrit-Change-Number: 16672
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Oct 2020 00:49:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10267: Impala crashes in HdfsScanner::WriteTemplateTuples() with negative num tuples

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16672 )

Change subject: IMPALA-10267: Impala crashes in HdfsScanner::WriteTemplateTuples() with negative num_tuples
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6613/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/16672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If88fd3aa4c96a69e37d060031f7432d27d069c62
Gerrit-Change-Number: 16672
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Oct 2020 18:40:14 +0000
Gerrit-HasComments: No