You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zjncs (via GitHub)" <gi...@apache.org> on 2026/10/13 06:32:03 UTC
[PR] test(metrics): pin the data-source query envelope [rocketmq-dashboard]
zjncs opened a new pull request, #6586:
URL: https://github.com/apache/rocketmq-dashboard/pull/6586
### What
MetricsDataSourceQueryRequest runs a PromQL range query against a configured data source. Its credential redaction is already pinned by SensitiveRequestToStringTest, but the validation side had no test. This pins: the query itself is required, and the nested MetricQueryDTO is validated in place - a broken query fails the whole request with the nested message instead of surfacing later as a remote 400.
### Verification
- New tests on unmodified code: **3/3 green**, checkstyle clean.
- Discriminating mutation: @NotNull removed from the query field (red - the missing-query rejection is caught).
- Restored: green. Test-only change; no product code touched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(metrics): pin the data-source query envelope [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>.
github-actions[bot] commented on PR #6586:
URL: https://github.com/apache/rocketmq-dashboard/pull/6586#issuecomment-6565984779
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(metrics): pin the data-source query envelope [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>.
github-actions[bot] closed pull request #6586: test(metrics): pin the data-source query envelope
URL: https://github.com/apache/rocketmq-dashboard/pull/6586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org