You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/10/31 11:22:32 UTC

[GitHub] [couchdb-nano] insidewhy commented on a diff in pull request #310: Abort HTTP connection when stopping changesReader, fixes #309

insidewhy commented on code in PR #310:
URL: https://github.com/apache/couchdb-nano/pull/310#discussion_r1009304030


##########
lib/nano.js:
##########
@@ -172,6 +172,16 @@ module.exports = exports = function dbScope (cfg) {
       body = { message: body }
     }
 
+    if (!body && req.signal) {

Review Comment:
   `req.signal.aborted` should be `true` also, but (at least in the tests) this doesn't seem to occur.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org