Re: [PR] KAFKA-17185: Declare all Loggers as static to prevent multiple logger instances [kafka]

["chia7712 (via GitHub)" <gi...@apache.org>]

chia7712 commented on code in PR #16680:
URL: https://github.com/apache/kafka/pull/16680#discussion_r1690134497


##########
clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java:
##########
@@ -42,7 +42,7 @@ final class ClusterConnectionStates {
     static final int CONNECTION_SETUP_TIMEOUT_EXP_BASE = 2;
     static final double CONNECTION_SETUP_TIMEOUT_JITTER = 0.2;
     private final Map<String, NodeConnectionState> nodeState;
-    private final Logger log;
+    private static final Logger log;

Review Comment:
   Noted that this static variable should NOT be initialized in constructor.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org