You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/01/19 16:40:41 UTC
[GitHub] [commons-vfs] XenoAmess opened a new pull request #78: fix bug for
class not found:org.apache.commons.vfs2.provider.webdav.WebdavFileProvider
XenoAmess opened a new pull request #78: fix bug for class not found:org.apache.commons.vfs2.provider.webdav.WebdavFileProvider
URL: https://github.com/apache/commons-vfs/pull/78
1.fix bug for class not found:org.apache.commons.vfs2.provider.webdav.WebdavFileProvider since 2.5.0
this bug is caused by the remove of WebdavFileProvider, and when try to load WebdavFileProvider if the user does not have class WebdavFileProvider, then explode.
now the code will check the class as well as its dependency when load.(if the class itself does not exist then return)
2.add clean room test
This bug happened and even with this bug the tests now can pass.
that is because you include all things needed in test scope guys.
and we users do not usually include them all.
so when something went wrong and vfs can only run correctly when user code imports some repo(like this time), the current test mechanism can never tell.
So I add a clean room test for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-vfs] woonsan commented on issue #78: fix bug for class not
found:org.apache.commons.vfs2.provider.webdav.WebdavFileProvider
Posted by GitBox <gi...@apache.org>.
woonsan commented on issue #78: fix bug for class not found:org.apache.commons.vfs2.provider.webdav.WebdavFileProvider
URL: https://github.com/apache/commons-vfs/pull/78#issuecomment-586760940
Hi @XenoAmess ,
(CC: @garydgregory )
Thanks again for reporting and helping with problem determination!
I've filed a JIRA ticket with a simple improvement in a new PR ( https://github.com/apache/commons-vfs/pull/84 ) to avoid this kind of corner case in the future:
- https://issues.apache.org/jira/browse/VFS-759
Cheers,
Woonsan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-vfs] XenoAmess commented on issue #78: fix bug for class
not found:org.apache.commons.vfs2.provider.webdav.WebdavFileProvider
Posted by GitBox <gi...@apache.org>.
XenoAmess commented on issue #78: fix bug for class not found:org.apache.commons.vfs2.provider.webdav.WebdavFileProvider
URL: https://github.com/apache/commons-vfs/pull/78#issuecomment-576635345
@garydgregory ping?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services