You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sateesh Chodapuneedi <sa...@citrix.com> on 2013/02/01 02:46:51 UTC
Review Request: PATCH-5 for feature 'Support for VMware dvSwitch in
CloudStack'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9210/
-----------------------------------------------------------
Review request for cloudstack, Murali Reddy and Kelven Yang.
Description
-------
This is 5/final patch for feature 'Support for VMware dvSwitch in CloudStack'.
Virtual switch type could be chosen at zone level or at cluster level for specific traffic type.
UI functionality is also included.
autoExpand of dvPortGroup is available in code but disabled as its breaking because vCenter 4.1 does not support autoExpand feature.
This addresses bug CLOUDSTACK-657.
Diffs
-----
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java 684df54
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java be3fe9f
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java c450312
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 96c4348
server/src/com/cloud/resource/ResourceManagerImpl.java f82424a
ui/scripts/system.js 2ce7672
ui/scripts/zoneWizard.js 26838a1
vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 50f9541
Diff: https://reviews.apache.org/r/9210/diff/
Testing
-------
Testing
-------
Manual testing:-
1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
Added following tests,
1) Test fetching dvSwitch object from vCenter
2) Test for presence of dvPortGroup
3) Test presence of dvPortGroup
4) Test get existing dvPortGroup
5) fetch dvPortGroup configuration
6) Test compare dvPortGroup configuration
7) Test update dvPortGroup configuration
Thanks,
Sateesh Chodapuneedi
Re: Review Request: PATCH-5 for feature 'Support for VMware dvSwitch in
CloudStack'.
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
> On Feb. 22, 2013, 2:20 a.m., Kelven Yang wrote:
> > Ship It!
Thanks for review.
Rebased the patch to latest master branch, unit testing is in progress. Will update the diffs as soon as the testing finish.
- Sateesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9210/#review16922
-----------------------------------------------------------
On Feb. 5, 2013, 5:23 a.m., Sateesh Chodapuneedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9210/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2013, 5:23 a.m.)
>
>
> Review request for cloudstack, Murali Reddy and Kelven Yang.
>
>
> Description
> -------
>
> This is 5/final patch for feature 'Support for VMware dvSwitch in CloudStack'.
>
> This patch contains
> 1)Changes to addCluster done in vmware discoverer to support vswitch type provided as parameters. Also performing validation of vswitch type parameter provided with addCluster api call.
> 2)Changes to vmware resource to use specified vswitch type while preparing network for guest and public traffic types
> 3)Changes to vmware manager to introduce new global parameter vmware.ports.per.dvportgroup. Some cleanup.
> 4)UI functionality is included.
> Virtual switch type could be chosen at zone level or at cluster level for specific traffic type. autoExpand of dvPortGroup is available in code but disabled as its breaking because vCenter 4.1 does not support autoExpand feature.
>
> Note:- UI code changes are done by Pranav Saxena.
>
>
> This addresses bug CLOUDSTACK-657.
>
>
> Diffs
> -----
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java 684df54
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java be3fe9f
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java c450312
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 96c4348
> server/src/com/cloud/resource/ResourceManagerImpl.java f82424a
> ui/scripts/system.js 2ce7672
> ui/scripts/zoneWizard.js 26838a1
> vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 50f9541
>
> Diff: https://reviews.apache.org/r/9210/diff/
>
>
> Testing
> -------
>
> Testing
> -------
>
> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
>
>
> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
>
>
> Thanks,
>
> Sateesh Chodapuneedi
>
>
Re: Review Request: PATCH-5 for feature 'Support for VMware dvSwitch in
CloudStack'.
Posted by Kelven Yang <ke...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9210/#review16922
-----------------------------------------------------------
Ship it!
Ship It!
- Kelven Yang
On Feb. 5, 2013, 5:23 a.m., Sateesh Chodapuneedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9210/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2013, 5:23 a.m.)
>
>
> Review request for cloudstack, Murali Reddy and Kelven Yang.
>
>
> Description
> -------
>
> This is 5/final patch for feature 'Support for VMware dvSwitch in CloudStack'.
>
> This patch contains
> 1)Changes to addCluster done in vmware discoverer to support vswitch type provided as parameters. Also performing validation of vswitch type parameter provided with addCluster api call.
> 2)Changes to vmware resource to use specified vswitch type while preparing network for guest and public traffic types
> 3)Changes to vmware manager to introduce new global parameter vmware.ports.per.dvportgroup. Some cleanup.
> 4)UI functionality is included.
> Virtual switch type could be chosen at zone level or at cluster level for specific traffic type. autoExpand of dvPortGroup is available in code but disabled as its breaking because vCenter 4.1 does not support autoExpand feature.
>
> Note:- UI code changes are done by Pranav Saxena.
>
>
> This addresses bug CLOUDSTACK-657.
>
>
> Diffs
> -----
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java 684df54
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java be3fe9f
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java c450312
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 96c4348
> server/src/com/cloud/resource/ResourceManagerImpl.java f82424a
> ui/scripts/system.js 2ce7672
> ui/scripts/zoneWizard.js 26838a1
> vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 50f9541
>
> Diff: https://reviews.apache.org/r/9210/diff/
>
>
> Testing
> -------
>
> Testing
> -------
>
> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
>
>
> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
>
>
> Thanks,
>
> Sateesh Chodapuneedi
>
>
Re: Review Request: PATCH-5 for feature 'Support for VMware dvSwitch in
CloudStack'.
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
> On Feb. 18, 2013, 7:59 a.m., Koushik Das wrote:
> > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java, line 185
> > <https://reviews.apache.org/r/9210/diff/1/?file=254475#file254475line185>
> >
> > Is this behavior to default to svs discussed in the FS? If not please try to get a closure.
Makes sense to throw error in case of faulty vswitch type specified as parameter.
Now addCluster attempt is failed if errorneous vswitch type is supplied.
> On Feb. 18, 2013, 7:59 a.m., Koushik Das wrote:
> > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java, line 285
> > <https://reviews.apache.org/r/9210/diff/1/?file=254478#file254478line285>
> >
> > Looks like _nexusVSwitch is no longer getting used
Yes, removed it.
- Sateesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9210/#review16696
-----------------------------------------------------------
On Feb. 25, 2013, 10:06 a.m., Sateesh Chodapuneedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9210/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2013, 10:06 a.m.)
>
>
> Review request for cloudstack, Murali Reddy and Kelven Yang.
>
>
> Description
> -------
>
> This is 5/final patch for feature 'Support for VMware dvSwitch in CloudStack'.
>
> This patch contains
> 1)Changes to addCluster done in vmware discoverer to support vswitch type provided as parameters. Also performing validation of vswitch type parameter provided with addCluster api call. Physical network configuration is validated.
> 2)Changes to vmware resource to use specified vswitch type while preparing network for guest and public traffic types
> 3)Changes to vmware manager to introduce new global parameter vmware.ports.per.dvportgroup. Some cleanup.
> Virtual switch type could be chosen at zone level or at cluster level for specific traffic type. autoExpand of dvPortGroup is available in code but disabled as its breaking because vCenter 4.1 does not support autoExpand feature. This would be supported once vSphere SDK 5.1 is added to CloudStack.
>
>
> This addresses bug CLOUDSTACK-657.
>
>
> Diffs
> -----
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java 5d7edce
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java 445b2f0
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 70f98cc
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 5cac253
> server/src/com/cloud/resource/ResourceManagerImpl.java 98044fb
> vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 50f9541
>
> Diff: https://reviews.apache.org/r/9210/diff/
>
>
> Testing
> -------
>
> Testing
> -------
>
> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
>
>
> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
>
>
> Thanks,
>
> Sateesh Chodapuneedi
>
>
Re: Review Request: PATCH-5 for feature 'Support for VMware dvSwitch in
CloudStack'.
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
> On Feb. 18, 2013, 7:59 a.m., Koushik Das wrote:
> > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java, line 185
> > <https://reviews.apache.org/r/9210/diff/1/?file=254475#file254475line185>
> >
> > Is this behavior to default to svs discussed in the FS? If not please try to get a closure.
>
> Sateesh Chodapuneedi wrote:
> Makes sense to throw error in case of faulty vswitch type specified as parameter.
> Now addCluster attempt is failed if errorneous vswitch type is supplied.
> On Feb. 18, 2013, 7:59 a.m., Koushik Das wrote:
> > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java, line 2456
> > <https://reviews.apache.org/r/9210/diff/1/?file=254478#file254478line2456>
> >
> > Put some comment as to why 2 and 3
Added comment.
- Sateesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9210/#review16696
-----------------------------------------------------------
On Feb. 25, 2013, 10:06 a.m., Sateesh Chodapuneedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9210/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2013, 10:06 a.m.)
>
>
> Review request for cloudstack, Murali Reddy and Kelven Yang.
>
>
> Description
> -------
>
> This is 5/final patch for feature 'Support for VMware dvSwitch in CloudStack'.
>
> This patch contains
> 1)Changes to addCluster done in vmware discoverer to support vswitch type provided as parameters. Also performing validation of vswitch type parameter provided with addCluster api call. Physical network configuration is validated.
> 2)Changes to vmware resource to use specified vswitch type while preparing network for guest and public traffic types
> 3)Changes to vmware manager to introduce new global parameter vmware.ports.per.dvportgroup. Some cleanup.
> Virtual switch type could be chosen at zone level or at cluster level for specific traffic type. autoExpand of dvPortGroup is available in code but disabled as its breaking because vCenter 4.1 does not support autoExpand feature. This would be supported once vSphere SDK 5.1 is added to CloudStack.
>
>
> This addresses bug CLOUDSTACK-657.
>
>
> Diffs
> -----
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java 5d7edce
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java 445b2f0
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 70f98cc
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 5cac253
> server/src/com/cloud/resource/ResourceManagerImpl.java 98044fb
> vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 50f9541
>
> Diff: https://reviews.apache.org/r/9210/diff/
>
>
> Testing
> -------
>
> Testing
> -------
>
> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
>
>
> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
>
>
> Thanks,
>
> Sateesh Chodapuneedi
>
>
Re: Review Request: PATCH-5 for feature 'Support for VMware dvSwitch in
CloudStack'.
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9210/#review16696
-----------------------------------------------------------
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
<https://reviews.apache.org/r/9210/#comment35408>
parseBoolean can handle null values, for null it returns false.
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
<https://reviews.apache.org/r/9210/#comment35409>
Does InvalidParameterValueException always mean incorrect vswitch type? The traffic label code suggest otherwise.
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
<https://reviews.apache.org/r/9210/#comment35410>
Is this behavior to default to svs discussed in the FS? If not please try to get a closure.
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
<https://reviews.apache.org/r/9210/#comment35411>
The code for handling guest and public traffic labels look identical. Move it into a method.
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
<https://reviews.apache.org/r/9210/#comment35422>
The code to create guest and public traffic label is repetade, move it to separate method.
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
<https://reviews.apache.org/r/9210/#comment35424>
Looks like _nexusVSwitch is no longer getting used
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
<https://reviews.apache.org/r/9210/#comment35425>
Put some comment as to why 2 and 3
- Koushik Das
On Feb. 5, 2013, 5:23 a.m., Sateesh Chodapuneedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9210/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2013, 5:23 a.m.)
>
>
> Review request for cloudstack, Murali Reddy and Kelven Yang.
>
>
> Description
> -------
>
> This is 5/final patch for feature 'Support for VMware dvSwitch in CloudStack'.
>
> This patch contains
> 1)Changes to addCluster done in vmware discoverer to support vswitch type provided as parameters. Also performing validation of vswitch type parameter provided with addCluster api call.
> 2)Changes to vmware resource to use specified vswitch type while preparing network for guest and public traffic types
> 3)Changes to vmware manager to introduce new global parameter vmware.ports.per.dvportgroup. Some cleanup.
> 4)UI functionality is included.
> Virtual switch type could be chosen at zone level or at cluster level for specific traffic type. autoExpand of dvPortGroup is available in code but disabled as its breaking because vCenter 4.1 does not support autoExpand feature.
>
> Note:- UI code changes are done by Pranav Saxena.
>
>
> This addresses bug CLOUDSTACK-657.
>
>
> Diffs
> -----
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java 684df54
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java be3fe9f
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java c450312
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 96c4348
> server/src/com/cloud/resource/ResourceManagerImpl.java f82424a
> ui/scripts/system.js 2ce7672
> ui/scripts/zoneWizard.js 26838a1
> vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 50f9541
>
> Diff: https://reviews.apache.org/r/9210/diff/
>
>
> Testing
> -------
>
> Testing
> -------
>
> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
>
>
> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
>
>
> Thanks,
>
> Sateesh Chodapuneedi
>
>
Re: Review Request: PATCH-5 for feature 'Support for VMware dvSwitch in
CloudStack'.
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9210/#review17148
-----------------------------------------------------------
Ship it!
Ship It!
- Sateesh Chodapuneedi
On Feb. 26, 2013, 8:09 a.m., Sateesh Chodapuneedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9210/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2013, 8:09 a.m.)
>
>
> Review request for cloudstack, Murali Reddy and Kelven Yang.
>
>
> Description
> -------
>
> This is 5/final patch for feature 'Support for VMware dvSwitch in CloudStack'.
>
> This patch contains
> 1)Changes to addCluster done in vmware discoverer to support vswitch type provided as parameters. Also performing validation of vswitch type parameter provided with addCluster api call. Physical network configuration is validated.
> 2)Changes to vmware resource to use specified vswitch type while preparing network for guest and public traffic types
> 3)Changes to vmware manager to introduce new global parameter vmware.ports.per.dvportgroup. Some cleanup.
> Virtual switch type could be chosen at zone level or at cluster level for specific traffic type. autoExpand of dvPortGroup is available in code but disabled as its breaking because vCenter 4.1 does not support autoExpand feature. This would be supported once vSphere SDK 5.1 is added to CloudStack.
>
>
> This addresses bug CLOUDSTACK-657.
>
>
> Diffs
> -----
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java 5d7edce
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java 36fa0f3
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java a0d9943
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 4839b35
> server/src/com/cloud/resource/ResourceManagerImpl.java 14628c1
> vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 50f9541
>
> Diff: https://reviews.apache.org/r/9210/diff/
>
>
> Testing
> -------
>
> Testing
> -------
>
> Manual testing:-
> 1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
> 2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
> 3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
> 4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
>
>
> Added following tests,
> 1) Test fetching dvSwitch object from vCenter
> 2) Test for presence of dvPortGroup
> 3) Test presence of dvPortGroup
> 4) Test get existing dvPortGroup
> 5) fetch dvPortGroup configuration
> 6) Test compare dvPortGroup configuration
> 7) Test update dvPortGroup configuration
>
>
> Thanks,
>
> Sateesh Chodapuneedi
>
>
Re: Review Request: PATCH-5 for feature 'Support for VMware dvSwitch in
CloudStack'.
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9210/
-----------------------------------------------------------
(Updated Feb. 26, 2013, 8:09 a.m.)
Review request for cloudstack, Murali Reddy and Kelven Yang.
Changes
-------
Re-based with latest master. Fixed merge conflicts caused after master merge of full clone feature few hours back.
Description
-------
This is 5/final patch for feature 'Support for VMware dvSwitch in CloudStack'.
This patch contains
1)Changes to addCluster done in vmware discoverer to support vswitch type provided as parameters. Also performing validation of vswitch type parameter provided with addCluster api call. Physical network configuration is validated.
2)Changes to vmware resource to use specified vswitch type while preparing network for guest and public traffic types
3)Changes to vmware manager to introduce new global parameter vmware.ports.per.dvportgroup. Some cleanup.
Virtual switch type could be chosen at zone level or at cluster level for specific traffic type. autoExpand of dvPortGroup is available in code but disabled as its breaking because vCenter 4.1 does not support autoExpand feature. This would be supported once vSphere SDK 5.1 is added to CloudStack.
This addresses bug CLOUDSTACK-657.
Diffs (updated)
-----
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java 5d7edce
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java 36fa0f3
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java a0d9943
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 4839b35
server/src/com/cloud/resource/ResourceManagerImpl.java 14628c1
vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 50f9541
Diff: https://reviews.apache.org/r/9210/diff/
Testing
-------
Testing
-------
Manual testing:-
1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
Added following tests,
1) Test fetching dvSwitch object from vCenter
2) Test for presence of dvPortGroup
3) Test presence of dvPortGroup
4) Test get existing dvPortGroup
5) fetch dvPortGroup configuration
6) Test compare dvPortGroup configuration
7) Test update dvPortGroup configuration
Thanks,
Sateesh Chodapuneedi
Re: Review Request: PATCH-5 for feature 'Support for VMware dvSwitch in
CloudStack'.
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9210/
-----------------------------------------------------------
(Updated Feb. 25, 2013, 10:59 a.m.)
Review request for cloudstack, Murali Reddy and Kelven Yang.
Description
-------
This is 5/final patch for feature 'Support for VMware dvSwitch in CloudStack'.
This patch contains
1)Changes to addCluster done in vmware discoverer to support vswitch type provided as parameters. Also performing validation of vswitch type parameter provided with addCluster api call. Physical network configuration is validated.
2)Changes to vmware resource to use specified vswitch type while preparing network for guest and public traffic types
3)Changes to vmware manager to introduce new global parameter vmware.ports.per.dvportgroup. Some cleanup.
Virtual switch type could be chosen at zone level or at cluster level for specific traffic type. autoExpand of dvPortGroup is available in code but disabled as its breaking because vCenter 4.1 does not support autoExpand feature. This would be supported once vSphere SDK 5.1 is added to CloudStack.
This addresses bug CLOUDSTACK-657.
Diffs (updated)
-----
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java 5d7edce
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java 445b2f0
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 70f98cc
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 5cac253
server/src/com/cloud/resource/ResourceManagerImpl.java 98044fb
vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 50f9541
Diff: https://reviews.apache.org/r/9210/diff/
Testing
-------
Testing
-------
Manual testing:-
1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
Added following tests,
1) Test fetching dvSwitch object from vCenter
2) Test for presence of dvPortGroup
3) Test presence of dvPortGroup
4) Test get existing dvPortGroup
5) fetch dvPortGroup configuration
6) Test compare dvPortGroup configuration
7) Test update dvPortGroup configuration
Thanks,
Sateesh Chodapuneedi
Re: Review Request: PATCH-5 for feature 'Support for VMware dvSwitch in
CloudStack'.
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9210/
-----------------------------------------------------------
(Updated Feb. 25, 2013, 10:49 a.m.)
Review request for cloudstack, Murali Reddy and Kelven Yang.
Description
-------
This is 5/final patch for feature 'Support for VMware dvSwitch in CloudStack'.
This patch contains
1)Changes to addCluster done in vmware discoverer to support vswitch type provided as parameters. Also performing validation of vswitch type parameter provided with addCluster api call. Physical network configuration is validated.
2)Changes to vmware resource to use specified vswitch type while preparing network for guest and public traffic types
3)Changes to vmware manager to introduce new global parameter vmware.ports.per.dvportgroup. Some cleanup.
Virtual switch type could be chosen at zone level or at cluster level for specific traffic type. autoExpand of dvPortGroup is available in code but disabled as its breaking because vCenter 4.1 does not support autoExpand feature. This would be supported once vSphere SDK 5.1 is added to CloudStack.
This addresses bug CLOUDSTACK-657.
Diffs (updated)
-----
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java 5d7edce
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java 445b2f0
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 5cac253
server/src/com/cloud/resource/ResourceManagerImpl.java 98044fb
vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 50f9541
Diff: https://reviews.apache.org/r/9210/diff/
Testing
-------
Testing
-------
Manual testing:-
1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
Added following tests,
1) Test fetching dvSwitch object from vCenter
2) Test for presence of dvPortGroup
3) Test presence of dvPortGroup
4) Test get existing dvPortGroup
5) fetch dvPortGroup configuration
6) Test compare dvPortGroup configuration
7) Test update dvPortGroup configuration
Thanks,
Sateesh Chodapuneedi
Re: Review Request: PATCH-5 for feature 'Support for VMware dvSwitch in
CloudStack'.
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9210/
-----------------------------------------------------------
(Updated Feb. 25, 2013, 10:06 a.m.)
Review request for cloudstack, Murali Reddy and Kelven Yang.
Changes
-------
Merged the patch with latest master. Removed UI changes from this patch. They will be coming as separate patch/
Description (updated)
-------
This is 5/final patch for feature 'Support for VMware dvSwitch in CloudStack'.
This patch contains
1)Changes to addCluster done in vmware discoverer to support vswitch type provided as parameters. Also performing validation of vswitch type parameter provided with addCluster api call. Physical network configuration is validated.
2)Changes to vmware resource to use specified vswitch type while preparing network for guest and public traffic types
3)Changes to vmware manager to introduce new global parameter vmware.ports.per.dvportgroup. Some cleanup.
Virtual switch type could be chosen at zone level or at cluster level for specific traffic type. autoExpand of dvPortGroup is available in code but disabled as its breaking because vCenter 4.1 does not support autoExpand feature. This would be supported once vSphere SDK 5.1 is added to CloudStack.
This addresses bug CLOUDSTACK-657.
Diffs (updated)
-----
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java 5d7edce
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java 445b2f0
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 70f98cc
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 5cac253
server/src/com/cloud/resource/ResourceManagerImpl.java 98044fb
vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 50f9541
Diff: https://reviews.apache.org/r/9210/diff/
Testing
-------
Testing
-------
Manual testing:-
1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
Added following tests,
1) Test fetching dvSwitch object from vCenter
2) Test for presence of dvPortGroup
3) Test presence of dvPortGroup
4) Test get existing dvPortGroup
5) fetch dvPortGroup configuration
6) Test compare dvPortGroup configuration
7) Test update dvPortGroup configuration
Thanks,
Sateesh Chodapuneedi
Re: Review Request: PATCH-5 for feature 'Support for VMware dvSwitch in
CloudStack'.
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9210/
-----------------------------------------------------------
(Updated Feb. 5, 2013, 5:23 a.m.)
Review request for cloudstack, Murali Reddy and Kelven Yang.
Changes
-------
Updated description with the changes covered by this patch
Description (updated)
-------
This is 5/final patch for feature 'Support for VMware dvSwitch in CloudStack'.
This patch contains
1)Changes to addCluster done in vmware discoverer to support vswitch type provided as parameters. Also performing validation of vswitch type parameter provided with addCluster api call.
2)Changes to vmware resource to use specified vswitch type while preparing network for guest and public traffic types
3)Changes to vmware manager to introduce new global parameter vmware.ports.per.dvportgroup. Some cleanup.
4)UI functionality is included.
Virtual switch type could be chosen at zone level or at cluster level for specific traffic type. autoExpand of dvPortGroup is available in code but disabled as its breaking because vCenter 4.1 does not support autoExpand feature.
Note:- UI code changes are done by Pranav Saxena.
This addresses bug CLOUDSTACK-657.
Diffs
-----
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java 684df54
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java be3fe9f
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java c450312
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 96c4348
server/src/com/cloud/resource/ResourceManagerImpl.java f82424a
ui/scripts/system.js 2ce7672
ui/scripts/zoneWizard.js 26838a1
vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 50f9541
Diff: https://reviews.apache.org/r/9210/diff/
Testing
-------
Testing
-------
Manual testing:-
1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
Added following tests,
1) Test fetching dvSwitch object from vCenter
2) Test for presence of dvPortGroup
3) Test presence of dvPortGroup
4) Test get existing dvPortGroup
5) fetch dvPortGroup configuration
6) Test compare dvPortGroup configuration
7) Test update dvPortGroup configuration
Thanks,
Sateesh Chodapuneedi
RE: Review Request: PATCH-5 for feature 'Support for VMware
dvSwitch in CloudStack'.
Posted by "Musayev, Ilya" <im...@webmd.net>.
Has this been committed yet?
Thanks
ilya
-----Original Message-----
From: Sateesh Chodapuneedi [mailto:noreply@reviews.apache.org] On Behalf Of Sateesh Chodapuneedi
Sent: Thursday, January 31, 2013 8:47 PM
To: Murali Reddy; Kelven Yang
Cc: Sateesh Chodapuneedi; cloudstack
Subject: Review Request: PATCH-5 for feature 'Support for VMware dvSwitch in CloudStack'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9210/
-----------------------------------------------------------
Review request for cloudstack, Murali Reddy and Kelven Yang.
Description
-------
This is 5/final patch for feature 'Support for VMware dvSwitch in CloudStack'.
Virtual switch type could be chosen at zone level or at cluster level for specific traffic type.
UI functionality is also included.
autoExpand of dvPortGroup is available in code but disabled as its breaking because vCenter 4.1 does not support autoExpand feature.
This addresses bug CLOUDSTACK-657.
Diffs
-----
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java 684df54
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java be3fe9f
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java c450312
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 96c4348
server/src/com/cloud/resource/ResourceManagerImpl.java f82424a
ui/scripts/system.js 2ce7672
ui/scripts/zoneWizard.js 26838a1
vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 50f9541
Diff: https://reviews.apache.org/r/9210/diff/
Testing
-------
Testing
-------
Manual testing:-
1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.
2) Tested both guest traffic and public traffic over dvSwitch on a physical network.
3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.
4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.
Added following tests,
1) Test fetching dvSwitch object from vCenter
2) Test for presence of dvPortGroup
3) Test presence of dvPortGroup
4) Test get existing dvPortGroup
5) fetch dvPortGroup configuration
6) Test compare dvPortGroup configuration
7) Test update dvPortGroup configuration
Thanks,
Sateesh Chodapuneedi