You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2016/10/20 01:23:36 UTC
Review Request 53039: Initial UTs for the driver Store class
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53039/
-----------------------------------------------------------
Review request for atlas, Madhan Neethiraj, Sarath Kumar Subramanian, Shwetha GS, and Suma Shivaprasad.
Bugs: ATLAS-1233
https://issues.apache.org/jira/browse/ATLAS-1233
Repository: atlas
Description
-------
Initial testing
UnitTests for the *DefStores
Diffs
-----
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 160f714047bfc626dc29e42694cf86f21ab250a8
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
repository/src/main/java/org/apache/atlas/util/TypeDefSorter.java 21e6d3f3a656bfea4cd03a31b92254354442f175
repository/src/test/java/org/apache/atlas/TestUtils.java 30071baaededfa954257fe2dcd74e53dac912c42
repository/src/test/java/org/apache/atlas/TestUtilsV2.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java PRE-CREATION
repository/src/test/resources/atlas-application.properties PRE-CREATION
Diff: https://reviews.apache.org/r/53039/diff/
Testing
-------
Passing unit tests for
1. Retrieval cases
2. Creation of typedefs
3. Update typedefs (todo)
4. Delete typedefs (todo)
Thanks,
Apoorv Naik
Re: Review Request 53039: Initial UTs for the driver Store class
Posted by Apoorv Naik <na...@gmail.com>.
> On Oct. 28, 2016, 11:40 p.m., Suma Shivaprasad wrote:
> > repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java, line 181
> > <https://reviews.apache.org/r/53039/diff/1/?file=1541932#file1541932line181>
> >
> > not needed since its in mem and we have graph cleanup?
I added this since I was trying to reuse the same type defs for various creation scenarios (eg. with valid/invalid supertype, with valid/invalid attributes). But since the GUIDS were the same, the tests were reporting failure, hence I was trying to cleanup before next create got executed.
- Apoorv
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53039/#review154195
-----------------------------------------------------------
On Oct. 20, 2016, 1:23 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53039/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2016, 1:23 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1233
> https://issues.apache.org/jira/browse/ATLAS-1233
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Initial testing
>
>
> UnitTests for the *DefStores
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 160f714047bfc626dc29e42694cf86f21ab250a8
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
> repository/src/main/java/org/apache/atlas/util/TypeDefSorter.java 21e6d3f3a656bfea4cd03a31b92254354442f175
> repository/src/test/java/org/apache/atlas/TestUtils.java 30071baaededfa954257fe2dcd74e53dac912c42
> repository/src/test/java/org/apache/atlas/TestUtilsV2.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java PRE-CREATION
> repository/src/test/resources/atlas-application.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53039/diff/
>
>
> Testing
> -------
>
> Passing unit tests for
> 1. Retrieval cases
> 2. Creation of typedefs
> 3. Update typedefs (todo)
> 4. Delete typedefs (todo)
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 53039: Initial UTs for the driver Store class
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53039/#review154195
-----------------------------------------------------------
repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java (line 181)
<https://reviews.apache.org/r/53039/#comment223682>
not needed since its in mem and we have graph cleanup?
- Suma Shivaprasad
On Oct. 20, 2016, 1:23 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53039/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2016, 1:23 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1233
> https://issues.apache.org/jira/browse/ATLAS-1233
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Initial testing
>
>
> UnitTests for the *DefStores
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 160f714047bfc626dc29e42694cf86f21ab250a8
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
> repository/src/main/java/org/apache/atlas/util/TypeDefSorter.java 21e6d3f3a656bfea4cd03a31b92254354442f175
> repository/src/test/java/org/apache/atlas/TestUtils.java 30071baaededfa954257fe2dcd74e53dac912c42
> repository/src/test/java/org/apache/atlas/TestUtilsV2.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java PRE-CREATION
> repository/src/test/resources/atlas-application.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53039/diff/
>
>
> Testing
> -------
>
> Passing unit tests for
> 1. Retrieval cases
> 2. Creation of typedefs
> 3. Update typedefs (todo)
> 4. Delete typedefs (todo)
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 53039: Initial UTs for the driver Store class
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53039/#review154198
-----------------------------------------------------------
repository/src/test/java/org/apache/atlas/TestUtilsV2.java (line 492)
<https://reviews.apache.org/r/53039/#comment223685>
remove if not needed?
- Suma Shivaprasad
On Oct. 20, 2016, 1:23 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53039/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2016, 1:23 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1233
> https://issues.apache.org/jira/browse/ATLAS-1233
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Initial testing
>
>
> UnitTests for the *DefStores
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 160f714047bfc626dc29e42694cf86f21ab250a8
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
> repository/src/main/java/org/apache/atlas/util/TypeDefSorter.java 21e6d3f3a656bfea4cd03a31b92254354442f175
> repository/src/test/java/org/apache/atlas/TestUtils.java 30071baaededfa954257fe2dcd74e53dac912c42
> repository/src/test/java/org/apache/atlas/TestUtilsV2.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java PRE-CREATION
> repository/src/test/resources/atlas-application.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53039/diff/
>
>
> Testing
> -------
>
> Passing unit tests for
> 1. Retrieval cases
> 2. Creation of typedefs
> 3. Update typedefs (todo)
> 4. Delete typedefs (todo)
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 53039: Initial UTs for the driver Store class
Posted by Apoorv Naik <na...@gmail.com>.
> On Oct. 28, 2016, 11:36 p.m., Suma Shivaprasad wrote:
> > repository/src/test/resources/atlas-application.properties, line 19
> > <https://reviews.apache.org/r/53039/diff/1/?file=1541933#file1541933line19>
> >
> > reuse typesystem/src/test/resources...any reasons why we need another one?
For some reason the tests were not picking up these properties so had to add a copy here. Will remove it.
- Apoorv
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53039/#review154194
-----------------------------------------------------------
On Oct. 20, 2016, 1:23 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53039/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2016, 1:23 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1233
> https://issues.apache.org/jira/browse/ATLAS-1233
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Initial testing
>
>
> UnitTests for the *DefStores
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 160f714047bfc626dc29e42694cf86f21ab250a8
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
> repository/src/main/java/org/apache/atlas/util/TypeDefSorter.java 21e6d3f3a656bfea4cd03a31b92254354442f175
> repository/src/test/java/org/apache/atlas/TestUtils.java 30071baaededfa954257fe2dcd74e53dac912c42
> repository/src/test/java/org/apache/atlas/TestUtilsV2.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java PRE-CREATION
> repository/src/test/resources/atlas-application.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53039/diff/
>
>
> Testing
> -------
>
> Passing unit tests for
> 1. Retrieval cases
> 2. Creation of typedefs
> 3. Update typedefs (todo)
> 4. Delete typedefs (todo)
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 53039: Initial UTs for the driver Store class
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53039/#review154194
-----------------------------------------------------------
repository/src/test/resources/atlas-application.properties (line 19)
<https://reviews.apache.org/r/53039/#comment223681>
reuse typesystem/src/test/resources...any reasons why we need another one?
- Suma Shivaprasad
On Oct. 20, 2016, 1:23 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53039/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2016, 1:23 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1233
> https://issues.apache.org/jira/browse/ATLAS-1233
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Initial testing
>
>
> UnitTests for the *DefStores
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 160f714047bfc626dc29e42694cf86f21ab250a8
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
> repository/src/main/java/org/apache/atlas/util/TypeDefSorter.java 21e6d3f3a656bfea4cd03a31b92254354442f175
> repository/src/test/java/org/apache/atlas/TestUtils.java 30071baaededfa954257fe2dcd74e53dac912c42
> repository/src/test/java/org/apache/atlas/TestUtilsV2.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java PRE-CREATION
> repository/src/test/resources/atlas-application.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53039/diff/
>
>
> Testing
> -------
>
> Passing unit tests for
> 1. Retrieval cases
> 2. Creation of typedefs
> 3. Update typedefs (todo)
> 4. Delete typedefs (todo)
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 53039: Initial UTs for the driver Store class
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53039/
-----------------------------------------------------------
(Updated Oct. 31, 2016, 10:49 p.m.)
Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
Changes
-------
removed the redundant property file
Bugs: ATLAS-1233
https://issues.apache.org/jira/browse/ATLAS-1233
Repository: atlas
Description
-------
Initial testing
UnitTests for the *DefStores
Diffs (updated)
-----
intg/pom.xml 3ac19cf9f5310bd6f04ed5565291de2ec1ec7642
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 160f714047bfc626dc29e42694cf86f21ab250a8
intg/src/test/java/org/apache/atlas/TestUtilsV2.java PRE-CREATION
repository/pom.xml 667af113d3e5b0ced38ecff087523525bf447e62
repository/src/main/java/org/apache/atlas/util/TypeDefSorter.java 21e6d3f3a656bfea4cd03a31b92254354442f175
repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/53039/diff/
Testing
-------
Passing unit tests for
1. Retrieval cases
2. Creation of typedefs
3. Update typedefs (bulk/byName/byGuid)
4. Delete typedefs (bulk)
Thanks,
Apoorv Naik
Re: Review Request 53039: Initial UTs for the driver Store class
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53039/
-----------------------------------------------------------
(Updated Oct. 31, 2016, 6:30 p.m.)
Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
Changes
-------
Updated test cases and fixed deletion problem.
Bugs: ATLAS-1233
https://issues.apache.org/jira/browse/ATLAS-1233
Repository: atlas
Description
-------
Initial testing
UnitTests for the *DefStores
Diffs (updated)
-----
intg/pom.xml 3ac19cf9f5310bd6f04ed5565291de2ec1ec7642
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 160f714047bfc626dc29e42694cf86f21ab250a8
intg/src/test/java/org/apache/atlas/TestUtilsV2.java PRE-CREATION
repository/pom.xml 667af113d3e5b0ced38ecff087523525bf447e62
repository/src/main/java/org/apache/atlas/util/TypeDefSorter.java 21e6d3f3a656bfea4cd03a31b92254354442f175
repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java PRE-CREATION
repository/src/test/resources/atlas-application.properties PRE-CREATION
Diff: https://reviews.apache.org/r/53039/diff/
Testing (updated)
-------
Passing unit tests for
1. Retrieval cases
2. Creation of typedefs
3. Update typedefs (bulk/byName/byGuid)
4. Delete typedefs (bulk)
Thanks,
Apoorv Naik
Re: Review Request 53039: Initial UTs for the driver Store class
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53039/#review154202
-----------------------------------------------------------
repository/src/test/java/org/apache/atlas/TestUtilsV2.java (line 57)
<https://reviews.apache.org/r/53039/#comment223691>
can you move this to intg test . Would be useful for tests down the stream as well. The graph part could be moved out
- Suma Shivaprasad
On Oct. 20, 2016, 1:23 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53039/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2016, 1:23 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1233
> https://issues.apache.org/jira/browse/ATLAS-1233
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Initial testing
>
>
> UnitTests for the *DefStores
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 160f714047bfc626dc29e42694cf86f21ab250a8
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 12047bfd80c6fb37b61dfd401b35f9e3dfb41043
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 663470790dda87ea982ab63f22b94d3d576fd4ee
> repository/src/main/java/org/apache/atlas/util/TypeDefSorter.java 21e6d3f3a656bfea4cd03a31b92254354442f175
> repository/src/test/java/org/apache/atlas/TestUtils.java 30071baaededfa954257fe2dcd74e53dac912c42
> repository/src/test/java/org/apache/atlas/TestUtilsV2.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java PRE-CREATION
> repository/src/test/resources/atlas-application.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53039/diff/
>
>
> Testing
> -------
>
> Passing unit tests for
> 1. Retrieval cases
> 2. Creation of typedefs
> 3. Update typedefs (todo)
> 4. Delete typedefs (todo)
>
>
> Thanks,
>
> Apoorv Naik
>
>