[jira] [Commented] (OPENNLP-1211) Improve WindowFeatureGeneratorTest

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577016#comment-16577016 ] 

ASF GitHub Bot commented on OPENNLP-1211:
-----------------------------------------

kojisekig opened a new pull request #326: OPENNLP-1211: Improve WindowFeatureGeneratorTest
URL: https://github.com/apache/opennlp/pull/326
 
 
   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [ ] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
   - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Improve WindowFeatureGeneratorTest
> ----------------------------------
>
>                 Key: OPENNLP-1211
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1211
>             Project: OpenNLP
>          Issue Type: Test
>          Components: Build, Packaging and Test
>    Affects Versions: 1.9.0
>            Reporter: Koji Sekiguchi
>            Priority: Trivial
>             Fix For: 1.9.1
>
>
> I'd like to improve WindowFeatureGeneratorTest from the following perspective:
> * testWindowSizeOne should check the contents of the returned features. It checks the length of the features only now
> * most of test methods uses Assert.assertEquals(expected, actual) in opposite way for its arguments when checking the contents of the returned features
> {code}
> Assert.assertEquals(features.get(0), testSentence[testTokenIndex]);
> {code}
> should be
> {code}
> Assert.assertEquals(testSentence[testTokenIndex], features.get(0));
> {code}
> * Though I pointed out the arguments in assertEquals() above, I think we'd better use exact concrete string rather than expression such like testSentence[testTokenIndex] for the expected. And also, testForCorrectFeatures uses contains method when checking the contents of the returned features but I think we should avoid using contains when checking the items in a List, rather than writing like this:
> {code}
>     Assert.assertTrue(features.contains(WindowFeatureGenerator.PREV_PREFIX + "2" +
>         testSentence[testTokenIndex - 2]));
>     Assert.assertTrue(features.contains(WindowFeatureGenerator.PREV_PREFIX + "1" +
>         testSentence[testTokenIndex - 1]));
>     Assert.assertTrue(features.contains(testSentence[testTokenIndex]));
>     Assert.assertTrue(features.contains(WindowFeatureGenerator.NEXT_PREFIX + "1" +
>         testSentence[testTokenIndex + 1]));
>     Assert.assertTrue(features.contains(WindowFeatureGenerator.NEXT_PREFIX + "2" +
>         testSentence[testTokenIndex + 2]));
> {code}
> but I'd like to rewrite them like this:
> {code}
>     Assert.assertEquals("d",features.get(0));
>     Assert.assertEquals("p1c",features.get(1));
>     Assert.assertEquals("p2b",features.get(2));
>     Assert.assertEquals("n1e",features.get(3));
>     Assert.assertEquals("n2f",features.get(4));
> {code}
> The second form helps us to understand how WindowFeatureGenerator works and it's easier to read.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)