You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by "dsmiley (via GitHub)" <gi...@apache.org> on 2023/09/28 19:11:03 UTC

[GitHub] [solr] dsmiley commented on pull request #1950: SOLR-16994: facilitate date-related FieldValueFeature extensions (docValues=True only)

dsmiley commented on PR #1950:
URL: https://github.com/apache/solr/pull/1950#issuecomment-1739867730

   I've not seen underscores in method names in our codebase before.  I think you could call this method simply readNumericDocValuesDate.  I just added "Date" onto the existing method that calls it.
   
   Alex's feedback looks good too; another way to view this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org