[GitHub] [beam] yeandy commented on a diff in pull request #17043: [BEAM-13966] Add pivot(), a non-deferred column operation on categorical columns

[GitBox <gi...@apache.org>]

yeandy commented on code in PR #17043:
URL: https://github.com/apache/beam/pull/17043#discussion_r841728579


##########
sdks/python/apache_beam/dataframe/pandas_doctests_test.py:
##########
@@ -876,7 +869,7 @@ def test_top_level(self):
                 'merge_ordered(df1, df2, fill_method="ffill", left_by="group")'
             ],
             # Expected error.
-            'pivot': ["df.pivot(index='foo', columns='bar', values='baz')"],
+            'pivot': ["*"],

Review Comment:
   Done!



##########
sdks/python/apache_beam/dataframe/pandas_doctests_test.py:
##########
@@ -366,9 +362,7 @@ def test_dataframe_tests(self):
             # actually raise NotImplementedError
             'pandas.core.frame.DataFrame.pivot_table': ['*'],
             # Expected to raise a ValueError, but we raise NotImplementedError
-            'pandas.core.frame.DataFrame.pivot': [
-                "df.pivot(index='foo', columns='bar', values='baz')"
-            ],

Review Comment:
   Done!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org