You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "wForget (via GitHub)" <gi...@apache.org> on 2024/03/04 02:45:41 UTC

Re: [PR] [SPARK-46094][CORE][FOLLOW-UP] Mark `writing` as volatile at ExecutorJVMProfiler [spark]

wForget commented on PR #45353:
URL: https://github.com/apache/spark/pull/45353#issuecomment-1975557375

   > @wForget mind filling:
   > 
   > > Does this PR introduce any user-facing change?
   > > How was this patch tested?
   > > Was this patch authored or co-authored using generative AI tooling?
   > 
   > How did you test, and which errors did you see?
   
   Thank you for your reminder. I didn't encounter any exception, just found it while learning the relevant code.
   
   Since the `writeChunk` method is executed in a new thread, if it is called after `finishWriting()`, I guess exception may occur.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org