You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Michael Park <mc...@gmail.com> on 2014/12/16 22:33:42 UTC
Re: Review Request 28697: [WIP] Add ReservationType and
ReservationInfo for dynamic reservations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/
-----------------------------------------------------------
(Updated Dec. 16, 2014, 9:33 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Summary (updated)
-----------------
[WIP] Add ReservationType and ReservationInfo for dynamic reservations.
Bugs: MESOS-2137
https://issues.apache.org/jira/browse/MESOS-2137
Repository: mesos-git
Description
-------
Adding new protobuf messages necessary to support dynamic reservations. Work in progress.
Diffs
-----
include/mesos/mesos.proto e0b6375579ca7d3af03e4b59044810b8b7d2df86
Diff: https://reviews.apache.org/r/28697/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 28697: [WIP] Add ReservationType and
ReservationInfo for dynamic reservations.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/#review65264
-----------------------------------------------------------
Patch looks great!
Reviews applied: [28697]
All tests passed.
- Mesos ReviewBot
On Dec. 16, 2014, 11:01 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28697/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2014, 11:01 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-2137
> https://issues.apache.org/jira/browse/MESOS-2137
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adding new protobuf messages necessary to support dynamic reservations.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
>
> Diff: https://reviews.apache.org/r/28697/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 28697: Add ReservationType and ReservationInfo for
dynamic reservations.
Posted by Michael Park <mc...@gmail.com>.
> On Dec. 18, 2014, 10:43 p.m., Adam B wrote:
> > include/mesos/mesos.proto, lines 391-394
> > <https://reviews.apache.org/r/28697/diff/2/?file=793360#file793360line391>
> >
> > Maybe more important than listing the valid states would be to list the valid transitions for framework writers (maybe in a lengthier doc), since a framework cannot, for example, change "role=R, STATIC" to "role=R, DYNAMIC".
>
> Michael Park wrote:
> Do you think it needs to be included in this comment? or should it go into `docs/reservations.md`?
Added valid transitions to the giant comment.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/#review65519
-----------------------------------------------------------
On Dec. 30, 2014, 8:42 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28697/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2014, 8:42 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-2137
> https://issues.apache.org/jira/browse/MESOS-2137
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adding new protobuf messages necessary to support dynamic reservations.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
>
> Diff: https://reviews.apache.org/r/28697/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 28697: [WIP] Add ReservationType and
ReservationInfo for dynamic reservations.
Posted by Michael Park <mc...@gmail.com>.
> On Dec. 18, 2014, 10:43 p.m., Adam B wrote:
> > The protobufs themselves look fine, but we'll need a lot more documentation on the proper way to use these fields together.
Agreed. Added a JIRA ticket to track this: https://issues.apache.org/jira/browse/MESOS-2205
> On Dec. 18, 2014, 10:43 p.m., Adam B wrote:
> > include/mesos/mesos.proto, lines 402-404
> > <https://reviews.apache.org/r/28697/diff/2/?file=793360#file793360line402>
> >
> > Framework writers will definitely need more documentation than this about dynamic reservations. Probably worth a separate subtask and review for a docs/reservations.md
Are framework writers expected to (or already does) use `<include/mesos/mesos.proto>` as documentation? Does it suffice to add the `docs/reservations.md`? or should I modify this comment to be more detailed as well?
> On Dec. 18, 2014, 10:43 p.m., Adam B wrote:
> > include/mesos/mesos.proto, lines 391-394
> > <https://reviews.apache.org/r/28697/diff/2/?file=793360#file793360line391>
> >
> > Maybe more important than listing the valid states would be to list the valid transitions for framework writers (maybe in a lengthier doc), since a framework cannot, for example, change "role=R, STATIC" to "role=R, DYNAMIC".
Do you think it needs to be included in this comment? or should it go into `docs/reservations.md`?
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/#review65519
-----------------------------------------------------------
On Dec. 17, 2014, 12:56 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28697/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2014, 12:56 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-2137
> https://issues.apache.org/jira/browse/MESOS-2137
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adding new protobuf messages necessary to support dynamic reservations.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
>
> Diff: https://reviews.apache.org/r/28697/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 28697: Add ReservationType and ReservationInfo for
dynamic reservations.
Posted by Michael Park <mc...@gmail.com>.
> On Dec. 18, 2014, 10:43 p.m., Adam B wrote:
> > include/mesos/mesos.proto, line 397
> > <https://reviews.apache.org/r/28697/diff/2/?file=793360#file793360line397>
> >
> > Should this be called ReservationType instead, in case we do want/need a true Reservation struct later?
Done.
> On Dec. 18, 2014, 10:43 p.m., Adam B wrote:
> > include/mesos/mesos.proto, line 398
> > <https://reviews.apache.org/r/28697/diff/2/?file=793360#file793360line398>
> >
> > About half of our protobuf enums start at 0, the others at 1. Do you have any reason to reserve 0 for later/NULL?
No reason to reserve for 0. I fell into the trap of thinking it needed to start 1 similar to fields of messages :(
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/#review65519
-----------------------------------------------------------
On Dec. 30, 2014, 2:42 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28697/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2014, 2:42 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-2137
> https://issues.apache.org/jira/browse/MESOS-2137
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adding new protobuf messages necessary to support dynamic reservations.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
>
> Diff: https://reviews.apache.org/r/28697/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 28697: Add ReservationType and ReservationInfo for
dynamic reservations.
Posted by Michael Park <mc...@gmail.com>.
> On Dec. 18, 2014, 10:43 p.m., Adam B wrote:
> > include/mesos/mesos.proto, lines 402-404
> > <https://reviews.apache.org/r/28697/diff/2/?file=793360#file793360line402>
> >
> > Framework writers will definitely need more documentation than this about dynamic reservations. Probably worth a separate subtask and review for a docs/reservations.md
>
> Michael Park wrote:
> Are framework writers expected to (or already does) use `<include/mesos/mesos.proto>` as documentation? Does it suffice to add the `docs/reservations.md`? or should I modify this comment to be more detailed as well?
Added a JIRA ticket to track this: https://issues.apache.org/jira/browse/MESOS-2205
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/#review65519
-----------------------------------------------------------
On Dec. 30, 2014, 8:42 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28697/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2014, 8:42 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-2137
> https://issues.apache.org/jira/browse/MESOS-2137
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adding new protobuf messages necessary to support dynamic reservations.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
>
> Diff: https://reviews.apache.org/r/28697/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 28697: [WIP] Add ReservationType and
ReservationInfo for dynamic reservations.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/#review65519
-----------------------------------------------------------
Ship it!
The protobufs themselves look fine, but we'll need a lot more documentation on the proper way to use these fields together.
include/mesos/mesos.proto
<https://reviews.apache.org/r/28697/#comment108775>
Maybe more important than listing the valid states would be to list the valid transitions for framework writers (maybe in a lengthier doc), since a framework cannot, for example, change "role=R, STATIC" to "role=R, DYNAMIC".
include/mesos/mesos.proto
<https://reviews.apache.org/r/28697/#comment108741>
Should this be called ReservationType instead, in case we do want/need a true Reservation struct later?
include/mesos/mesos.proto
<https://reviews.apache.org/r/28697/#comment108774>
About half of our protobuf enums start at 0, the others at 1. Do you have any reason to reserve 0 for later/NULL?
include/mesos/mesos.proto
<https://reviews.apache.org/r/28697/#comment108773>
Framework writers will definitely need more documentation than this about dynamic reservations. Probably worth a separate subtask and review for a docs/reservations.md
- Adam B
On Dec. 16, 2014, 4:56 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28697/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2014, 4:56 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-2137
> https://issues.apache.org/jira/browse/MESOS-2137
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adding new protobuf messages necessary to support dynamic reservations.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
>
> Diff: https://reviews.apache.org/r/28697/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 28697: Add ReservationType and ReservationInfo for
dynamic reservations.
Posted by Michael Park <mc...@gmail.com>.
> On Dec. 19, 2014, 8:23 p.m., Ben Mahler wrote:
> > This looks good Michael, one thing that I think is important to highlight about this approach is that we no longer "know" the static reservation for a dynamically reserved resource.
> >
> > This is ok for now because a dynamically reserved resource *always* implies that it's static role is `"*"` (unreserved). But it might be work thinking, possibly leaving a NOTE or TODO, about what we would do if we introduced the ability for a framework to dynamically reserved resources from a non-`"*"` role. For example, this could happen if we introduced hierarchical roles (e.g. Marathon reserves `"marathon"` resources under the role `"marathon-ads"`). Would we introduce a `static_role` or a richer `Reservation` message as Adam alluded to? Just some food for thought here.
> >
> > Will defer to Adam on this one, also would like to see some documentation around dynamic reservations at the top level of the `Resource` proto message.
> >
> > Thanks!
>
> Ben Mahler wrote:
> Also, is this a WIP? If you plan on getting this committed mind changing the title?
>
> Adam B wrote:
> If we do end up introducing hierarchical roles, I see no reason why they would only be two levels deep, since one could dynamically reserve from "*" to "marathon" to "marathon/ads" to "marathon/ads/EU" etc., so a single `static_role` field may not suffice. We may need a repeated list/stack, or just keep track of all that information in the master and don't bother exposing it to the framework. The original role is just what was necessary for this framework to get the offer. Once the framework decides to change the role, let the master track any necessary history.
> I think it's fine for us to keep the single `role` field to represent the current/desired role, and the ReservationType will indicate a) (when sent by the master) what type of reservation this resource currently belongs to, and hence what actions may be taken on it, and b) (when sent by the framework) the desired reservation type, with the action specified by what kind of message (acquire/release/launch) this Resource is a part of.
> That said, I am all the more convinced that we should name the enum ReservationType to prepare for a day when we need a fuller Reservation message.
>
> Michael Park wrote:
> Removed WIP. Changed Reservation to ReservationType.
As far as frameworks dynamically reserving resources from a non-"*" role, we do want frameworks to be offered statically reserved resources that *do not belong* to them in order to get better resource utilization. However, we do not want frameworks to be offered resources with `(role=R, reservation_type=STATIC)` where `R` does not belong to the framework due to security issues (a malicious framework could only use/reserve one statically reserved role's resources). What would be better is to send statically reserved resources as revocable resources to the framework where revocable resources are denoted by `role="_"` or maybe a combination of `role="*" + revocable=true`. This makes sense because if the statically reserved resources are needed they need to be revoked. Under this design, the master would keep track of which role the revocable resources came from and the framework doesn't/shouldn't know where they came from.
For frameworks dynamically reserving resources from a non-"*" role that does belong to them, we could revisit it if it seems like a useful feature. I think Adam is right in that we can keep the record of the chain of reservations (hopefully keep it at 2 for simplicity sake...) in the master and not expose it to the framework.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/#review65670
-----------------------------------------------------------
On Dec. 30, 2014, 2:42 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28697/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2014, 2:42 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-2137
> https://issues.apache.org/jira/browse/MESOS-2137
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adding new protobuf messages necessary to support dynamic reservations.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
>
> Diff: https://reviews.apache.org/r/28697/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 28697: [WIP] Add ReservationType and
ReservationInfo for dynamic reservations.
Posted by Adam B <ad...@mesosphere.io>.
> On Dec. 19, 2014, 12:23 p.m., Ben Mahler wrote:
> > This looks good Michael, one thing that I think is important to highlight about this approach is that we no longer "know" the static reservation for a dynamically reserved resource.
> >
> > This is ok for now because a dynamically reserved resource *always* implies that it's static role is `"*"` (unreserved). But it might be work thinking, possibly leaving a NOTE or TODO, about what we would do if we introduced the ability for a framework to dynamically reserved resources from a non-`"*"` role. For example, this could happen if we introduced hierarchical roles (e.g. Marathon reserves `"marathon"` resources under the role `"marathon-ads"`). Would we introduce a `static_role` or a richer `Reservation` message as Adam alluded to? Just some food for thought here.
> >
> > Will defer to Adam on this one, also would like to see some documentation around dynamic reservations at the top level of the `Resource` proto message.
> >
> > Thanks!
>
> Ben Mahler wrote:
> Also, is this a WIP? If you plan on getting this committed mind changing the title?
If we do end up introducing hierarchical roles, I see no reason why they would only be two levels deep, since one could dynamically reserve from "*" to "marathon" to "marathon/ads" to "marathon/ads/EU" etc., so a single `static_role` field may not suffice. We may need a repeated list/stack, or just keep track of all that information in the master and don't bother exposing it to the framework. The original role is just what was necessary for this framework to get the offer. Once the framework decides to change the role, let the master track any necessary history.
I think it's fine for us to keep the single `role` field to represent the current/desired role, and the ReservationType will indicate a) (when sent by the master) what type of reservation this resource currently belongs to, and hence what actions may be taken on it, and b) (when sent by the framework) the desired reservation type, with the action specified by what kind of message (acquire/release/launch) this Resource is a part of.
That said, I am all the more convinced that we should name the enum ReservationType to prepare for a day when we need a fuller Reservation message.
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/#review65670
-----------------------------------------------------------
On Dec. 16, 2014, 4:56 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28697/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2014, 4:56 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-2137
> https://issues.apache.org/jira/browse/MESOS-2137
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adding new protobuf messages necessary to support dynamic reservations.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
>
> Diff: https://reviews.apache.org/r/28697/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 28697: Add ReservationType and ReservationInfo for
dynamic reservations.
Posted by Michael Park <mc...@gmail.com>.
> On Dec. 19, 2014, 8:23 p.m., Ben Mahler wrote:
> > This looks good Michael, one thing that I think is important to highlight about this approach is that we no longer "know" the static reservation for a dynamically reserved resource.
> >
> > This is ok for now because a dynamically reserved resource *always* implies that it's static role is `"*"` (unreserved). But it might be work thinking, possibly leaving a NOTE or TODO, about what we would do if we introduced the ability for a framework to dynamically reserved resources from a non-`"*"` role. For example, this could happen if we introduced hierarchical roles (e.g. Marathon reserves `"marathon"` resources under the role `"marathon-ads"`). Would we introduce a `static_role` or a richer `Reservation` message as Adam alluded to? Just some food for thought here.
> >
> > Will defer to Adam on this one, also would like to see some documentation around dynamic reservations at the top level of the `Resource` proto message.
> >
> > Thanks!
>
> Ben Mahler wrote:
> Also, is this a WIP? If you plan on getting this committed mind changing the title?
>
> Adam B wrote:
> If we do end up introducing hierarchical roles, I see no reason why they would only be two levels deep, since one could dynamically reserve from "*" to "marathon" to "marathon/ads" to "marathon/ads/EU" etc., so a single `static_role` field may not suffice. We may need a repeated list/stack, or just keep track of all that information in the master and don't bother exposing it to the framework. The original role is just what was necessary for this framework to get the offer. Once the framework decides to change the role, let the master track any necessary history.
> I think it's fine for us to keep the single `role` field to represent the current/desired role, and the ReservationType will indicate a) (when sent by the master) what type of reservation this resource currently belongs to, and hence what actions may be taken on it, and b) (when sent by the framework) the desired reservation type, with the action specified by what kind of message (acquire/release/launch) this Resource is a part of.
> That said, I am all the more convinced that we should name the enum ReservationType to prepare for a day when we need a fuller Reservation message.
Removed WIP. Changed Reservation to ReservationType.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/#review65670
-----------------------------------------------------------
On Dec. 30, 2014, 2:42 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28697/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2014, 2:42 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-2137
> https://issues.apache.org/jira/browse/MESOS-2137
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adding new protobuf messages necessary to support dynamic reservations.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
>
> Diff: https://reviews.apache.org/r/28697/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 28697: [WIP] Add ReservationType and
ReservationInfo for dynamic reservations.
Posted by Ben Mahler <be...@gmail.com>.
> On Dec. 19, 2014, 8:23 p.m., Ben Mahler wrote:
> > This looks good Michael, one thing that I think is important to highlight about this approach is that we no longer "know" the static reservation for a dynamically reserved resource.
> >
> > This is ok for now because a dynamically reserved resource *always* implies that it's static role is `"*"` (unreserved). But it might be work thinking, possibly leaving a NOTE or TODO, about what we would do if we introduced the ability for a framework to dynamically reserved resources from a non-`"*"` role. For example, this could happen if we introduced hierarchical roles (e.g. Marathon reserves `"marathon"` resources under the role `"marathon-ads"`). Would we introduce a `static_role` or a richer `Reservation` message as Adam alluded to? Just some food for thought here.
> >
> > Will defer to Adam on this one, also would like to see some documentation around dynamic reservations at the top level of the `Resource` proto message.
> >
> > Thanks!
Also, is this a WIP? If you plan on getting this committed mind changing the title?
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/#review65670
-----------------------------------------------------------
On Dec. 17, 2014, 12:56 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28697/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2014, 12:56 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-2137
> https://issues.apache.org/jira/browse/MESOS-2137
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adding new protobuf messages necessary to support dynamic reservations.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
>
> Diff: https://reviews.apache.org/r/28697/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 28697: Add ReservationType and ReservationInfo for
dynamic reservations.
Posted by Michael Park <mc...@gmail.com>.
> On Dec. 19, 2014, 8:23 p.m., Ben Mahler wrote:
> > This looks good Michael, one thing that I think is important to highlight about this approach is that we no longer "know" the static reservation for a dynamically reserved resource.
> >
> > This is ok for now because a dynamically reserved resource *always* implies that it's static role is `"*"` (unreserved). But it might be work thinking, possibly leaving a NOTE or TODO, about what we would do if we introduced the ability for a framework to dynamically reserved resources from a non-`"*"` role. For example, this could happen if we introduced hierarchical roles (e.g. Marathon reserves `"marathon"` resources under the role `"marathon-ads"`). Would we introduce a `static_role` or a richer `Reservation` message as Adam alluded to? Just some food for thought here.
> >
> > Will defer to Adam on this one, also would like to see some documentation around dynamic reservations at the top level of the `Resource` proto message.
> >
> > Thanks!
>
> Ben Mahler wrote:
> Also, is this a WIP? If you plan on getting this committed mind changing the title?
>
> Adam B wrote:
> If we do end up introducing hierarchical roles, I see no reason why they would only be two levels deep, since one could dynamically reserve from "*" to "marathon" to "marathon/ads" to "marathon/ads/EU" etc., so a single `static_role` field may not suffice. We may need a repeated list/stack, or just keep track of all that information in the master and don't bother exposing it to the framework. The original role is just what was necessary for this framework to get the offer. Once the framework decides to change the role, let the master track any necessary history.
> I think it's fine for us to keep the single `role` field to represent the current/desired role, and the ReservationType will indicate a) (when sent by the master) what type of reservation this resource currently belongs to, and hence what actions may be taken on it, and b) (when sent by the framework) the desired reservation type, with the action specified by what kind of message (acquire/release/launch) this Resource is a part of.
> That said, I am all the more convinced that we should name the enum ReservationType to prepare for a day when we need a fuller Reservation message.
>
> Michael Park wrote:
> Removed WIP. Changed Reservation to ReservationType.
>
> Michael Park wrote:
> As far as frameworks dynamically reserving resources from a non-"*" role, we do want frameworks to be offered statically reserved resources that *do not belong* to them in order to get better resource utilization. However, we do not want frameworks to be offered resources with `(role=R, reservation_type=STATIC)` where `R` does not belong to the framework due to security issues (a malicious framework could only use/reserve one statically reserved role's resources). What would be better is to send statically reserved resources as revocable resources to the framework where revocable resources are denoted by `role="_"` or maybe a combination of `role="*" + revocable=true`. This makes sense because if the statically reserved resources are needed they need to be revoked. Under this design, the master would keep track of which role the revocable resources came from and the framework doesn't/shouldn't know where they came from.
>
> For frameworks dynamically reserving resources from a non-"*" role that does belong to them, we could revisit it if it seems like a useful feature. I think Adam is right in that we can keep the record of the chain of reservations (hopefully keep it at 2 for simplicity sake...) in the master and not expose it to the framework.
Another thought, a framework with role=R gets offered resources with (role=R, reservation_type=STATIC). Such framework shouldn't be able to make a subreservation with role=S since role S doesn't belong to it. This means multi-role frameworks need to be in place before we can make subreservations work.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/#review65670
-----------------------------------------------------------
On Dec. 30, 2014, 2:42 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28697/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2014, 2:42 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-2137
> https://issues.apache.org/jira/browse/MESOS-2137
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adding new protobuf messages necessary to support dynamic reservations.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
>
> Diff: https://reviews.apache.org/r/28697/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 28697: [WIP] Add ReservationType and
ReservationInfo for dynamic reservations.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/#review65670
-----------------------------------------------------------
Ship it!
This looks good Michael, one thing that I think is important to highlight about this approach is that we no longer "know" the static reservation for a dynamically reserved resource.
This is ok for now because a dynamically reserved resource *always* implies that it's static role is `"*"` (unreserved). But it might be work thinking, possibly leaving a NOTE or TODO, about what we would do if we introduced the ability for a framework to dynamically reserved resources from a non-`"*"` role. For example, this could happen if we introduced hierarchical roles (e.g. Marathon reserves `"marathon"` resources under the role `"marathon-ads"`). Would we introduce a `static_role` or a richer `Reservation` message as Adam alluded to? Just some food for thought here.
Will defer to Adam on this one, also would like to see some documentation around dynamic reservations at the top level of the `Resource` proto message.
Thanks!
- Ben Mahler
On Dec. 17, 2014, 12:56 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28697/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2014, 12:56 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-2137
> https://issues.apache.org/jira/browse/MESOS-2137
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adding new protobuf messages necessary to support dynamic reservations.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
>
> Diff: https://reviews.apache.org/r/28697/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 28697: Added ReservationType for dynamic
reservations.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/#review70706
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Jan. 29, 2015, 6:10 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28697/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2015, 6:10 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-2137
> https://issues.apache.org/jira/browse/MESOS-2137
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adding new protobuf messages necessary to support dynamic reservations.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
>
> Diff: https://reviews.apache.org/r/28697/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 28697: Added ReservationType for dynamic
reservations.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/#review70263
-----------------------------------------------------------
Ship it!
That looks good to me!
- Jie Yu
On Jan. 29, 2015, 6:10 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28697/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2015, 6:10 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-2137
> https://issues.apache.org/jira/browse/MESOS-2137
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adding new protobuf messages necessary to support dynamic reservations.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
>
> Diff: https://reviews.apache.org/r/28697/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 28697: Added ReservationType for dynamic
reservations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/
-----------------------------------------------------------
(Updated Jan. 29, 2015, 6:10 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Summary (updated)
-----------------
Added ReservationType for dynamic reservations.
Bugs: MESOS-2137
https://issues.apache.org/jira/browse/MESOS-2137
Repository: mesos-git
Description
-------
Adding new protobuf messages necessary to support dynamic reservations.
Diffs
-----
include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
Diff: https://reviews.apache.org/r/28697/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 28697: Add ReservationType for dynamic
reservations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/
-----------------------------------------------------------
(Updated Jan. 15, 2015, 2:10 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Bugs: MESOS-2137
https://issues.apache.org/jira/browse/MESOS-2137
Repository: mesos-git
Description
-------
Adding new protobuf messages necessary to support dynamic reservations.
Diffs
-----
include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
Diff: https://reviews.apache.org/r/28697/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 28697: Add ReservationType for dynamic
reservations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/
-----------------------------------------------------------
(Updated Jan. 9, 2015, 8:22 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Summary (updated)
-----------------
Add ReservationType for dynamic reservations.
Bugs: MESOS-2137
https://issues.apache.org/jira/browse/MESOS-2137
Repository: mesos-git
Description
-------
Adding new protobuf messages necessary to support dynamic reservations.
Diffs
-----
include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
Diff: https://reviews.apache.org/r/28697/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 28697: Add ReservationType and ReservationInfo for
dynamic reservations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/
-----------------------------------------------------------
(Updated Jan. 9, 2015, 1:46 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Bugs: MESOS-2137
https://issues.apache.org/jira/browse/MESOS-2137
Repository: mesos-git
Description
-------
Adding new protobuf messages necessary to support dynamic reservations.
Diffs
-----
include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
Diff: https://reviews.apache.org/r/28697/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 28697: Add ReservationType and ReservationInfo for
dynamic reservations.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/#review66456
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On Dec. 30, 2014, 11:56 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28697/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2014, 11:56 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-2137
> https://issues.apache.org/jira/browse/MESOS-2137
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adding new protobuf messages necessary to support dynamic reservations.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
>
> Diff: https://reviews.apache.org/r/28697/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 28697: Add ReservationType and ReservationInfo for
dynamic reservations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/
-----------------------------------------------------------
(Updated Dec. 31, 2014, 7:56 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Bugs: MESOS-2137
https://issues.apache.org/jira/browse/MESOS-2137
Repository: mesos-git
Description
-------
Adding new protobuf messages necessary to support dynamic reservations.
Diffs (updated)
-----
include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
Diff: https://reviews.apache.org/r/28697/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 28697: Add ReservationType and ReservationInfo for
dynamic reservations.
Posted by Michael Park <mc...@gmail.com>.
> On Dec. 31, 2014, 7:11 a.m., Adam B wrote:
> > include/mesos/mesos.proto, lines 403-422
> > <https://reviews.apache.org/r/28697/diff/3-4/?file=803136#file803136line403>
> >
> > Excellent explanation, but this belongs in the design doc, not here. The framework author doesn't need API documentation that explains what cannot be done yet. Remove this whole Note 2 block.
Removed.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/#review66449
-----------------------------------------------------------
On Dec. 31, 2014, 7:56 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28697/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2014, 7:56 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-2137
> https://issues.apache.org/jira/browse/MESOS-2137
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adding new protobuf messages necessary to support dynamic reservations.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
>
> Diff: https://reviews.apache.org/r/28697/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 28697: Add ReservationType and ReservationInfo for
dynamic reservations.
Posted by Michael Park <mc...@gmail.com>.
> On Dec. 31, 2014, 7:11 a.m., Adam B wrote:
> > include/mesos/mesos.proto, lines 393-395
> > <https://reviews.apache.org/r/28697/diff/3-4/?file=803136#file803136line393>
> >
> > I like the concise form. Now let's name each:
> > ("*", STATIC) - Unreserved
> > (R, STATIC) - Statically Reserved
> > (R, DYNAMIC) - Dynamically Reserved
> >
> > As an aside, why do we even care what `reservation_type` is set to when `role`=="*"? If we just ignore it, then all states are "valid".
We talked about how reserving for role=R within resources with role=R would effectively be a no-op but we would error to be clear to the framework writers that what they think they're doing isn't what's going on. This is similar in that if we let `("*", DYNAMIC)` be valid, framework writers could think they can dynamically reserve resources with role="*".
> On Dec. 31, 2014, 7:11 a.m., Adam B wrote:
> > include/mesos/mesos.proto, lines 399-400
> > <https://reviews.apache.org/r/28697/diff/3-4/?file=803136#file803136line399>
> >
> > Reworded with the terms defined above:
> > Reservation: ("*", STATIC) => (R, DYNAMIC)
> > "An unreserved resource can become dynamically reserved for a role R."
> >
> > Unreservation: (R, DYNAMIC) => ("*", STATIC)
> > "A dynamically reserved resource can become unreserved."
> >
> > The implied disallowed transitions:
> > "Static reservations cannot be set or changed by a framework. These are set by a cluster administrator on slave start."
Awesome. Thanks for the new wording!
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/#review66449
-----------------------------------------------------------
On Dec. 30, 2014, 8:42 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28697/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2014, 8:42 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-2137
> https://issues.apache.org/jira/browse/MESOS-2137
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adding new protobuf messages necessary to support dynamic reservations.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
>
> Diff: https://reviews.apache.org/r/28697/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 28697: Add ReservationType and ReservationInfo for
dynamic reservations.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/#review66449
-----------------------------------------------------------
include/mesos/mesos.proto
<https://reviews.apache.org/r/28697/#comment110011>
I like the concise form. Now let's name each:
("*", STATIC) - Unreserved
(R, STATIC) - Statically Reserved
(R, DYNAMIC) - Dynamically Reserved
As an aside, why do we even care what `reservation_type` is set to when `role`=="*"? If we just ignore it, then all states are "valid".
include/mesos/mesos.proto
<https://reviews.apache.org/r/28697/#comment110012>
Reworded with the terms defined above:
Reservation: ("*", STATIC) => (R, DYNAMIC)
"An unreserved resource can become dynamically reserved for a role R."
Unreservation: (R, DYNAMIC) => ("*", STATIC)
"A dynamically reserved resource can become unreserved."
The implied disallowed transitions:
"Static reservations cannot be set or changed by a framework. These are set by a cluster administrator on slave start."
include/mesos/mesos.proto
<https://reviews.apache.org/r/28697/#comment110010>
Excellent explanation, but this belongs in the design doc, not here. The framework author doesn't need API documentation that explains what cannot be done yet. Remove this whole Note 2 block.
- Adam B
On Dec. 30, 2014, 12:42 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28697/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2014, 12:42 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-2137
> https://issues.apache.org/jira/browse/MESOS-2137
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adding new protobuf messages necessary to support dynamic reservations.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
>
> Diff: https://reviews.apache.org/r/28697/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 28697: Add ReservationType and ReservationInfo for
dynamic reservations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/
-----------------------------------------------------------
(Updated Dec. 30, 2014, 8:42 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Bugs: MESOS-2137
https://issues.apache.org/jira/browse/MESOS-2137
Repository: mesos-git
Description
-------
Adding new protobuf messages necessary to support dynamic reservations.
Diffs (updated)
-----
include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
Diff: https://reviews.apache.org/r/28697/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 28697: Add ReservationType and ReservationInfo for
dynamic reservations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/
-----------------------------------------------------------
(Updated Dec. 30, 2014, 2:42 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Bugs: MESOS-2137
https://issues.apache.org/jira/browse/MESOS-2137
Repository: mesos-git
Description
-------
Adding new protobuf messages necessary to support dynamic reservations.
Diffs (updated)
-----
include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
Diff: https://reviews.apache.org/r/28697/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 28697: Add ReservationType and ReservationInfo for
dynamic reservations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/
-----------------------------------------------------------
(Updated Dec. 30, 2014, 2:11 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Summary (updated)
-----------------
Add ReservationType and ReservationInfo for dynamic reservations.
Bugs: MESOS-2137
https://issues.apache.org/jira/browse/MESOS-2137
Repository: mesos-git
Description
-------
Adding new protobuf messages necessary to support dynamic reservations.
Diffs
-----
include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
Diff: https://reviews.apache.org/r/28697/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 28697: [WIP] Add ReservationType and
ReservationInfo for dynamic reservations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/
-----------------------------------------------------------
(Updated Dec. 17, 2014, 12:56 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Bugs: MESOS-2137
https://issues.apache.org/jira/browse/MESOS-2137
Repository: mesos-git
Description
-------
Adding new protobuf messages necessary to support dynamic reservations.
Diffs
-----
include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
Diff: https://reviews.apache.org/r/28697/diff/
Testing (updated)
-------
make check
Thanks,
Michael Park
Re: Review Request 28697: [WIP] Add ReservationType and
ReservationInfo for dynamic reservations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/
-----------------------------------------------------------
(Updated Dec. 16, 2014, 11:01 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Bugs: MESOS-2137
https://issues.apache.org/jira/browse/MESOS-2137
Repository: mesos-git
Description (updated)
-------
Adding new protobuf messages necessary to support dynamic reservations.
Diffs (updated)
-----
include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437
Diff: https://reviews.apache.org/r/28697/diff/
Testing
-------
Thanks,
Michael Park