[jira] [Commented] (CASSANDRA-17287) Replace cqlshlib/wcwidth.py with pypi module 'wcwidth'

["Brandon Williams (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-17287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486013#comment-17486013 ] 

Brandon Williams commented on CASSANDRA-17287:
----------------------------------------------

Also needs to be [added to the dtests|https://github.com/driftx/cassandra-dtest/tree/CASSANDRA-17287].  [Circle|https://app.circleci.com/pipelines/github/driftx/cassandra/348/workflows/d8f99706-04f3-4dee-9fc4-5f89f8d31811] running with both.

> Replace cqlshlib/wcwidth.py with pypi module 'wcwidth'
> ------------------------------------------------------
>
>                 Key: CASSANDRA-17287
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17287
>             Project: Cassandra
>          Issue Type: Task
>          Components: CQL/Interpreter
>            Reporter: Brad Schoening
>            Assignee: Brad Schoening
>            Priority: Normal
>             Fix For: 4.x
>
>         Attachments: CQLSH sample query.jpg
>
>
> The module wcwidth implements the same Markus Kuhn algorithm defined in POSIX.1-2008 to return the number of cells a unicode string is expected to occupy.
> The module wcwidth is used by hundreds of libraries including pytest and prompt-toolkit (used in ipython).  It replaces 379 lines of bespoke code in cqlshlib.
> {quote}from wcwidth import wcswidth   # at [https://pypi.org/project/wcwidth/]
> print(wcswidth('コンニチハ'))
> 10
> {{from cqlshlib.wcwidth import wcswidth as cql_wcswidth}}
> print(cql_wcswidth('コンニチハ'))
> 10
> {quote}
> wcwidth appears to be used only by one line in formatting.py:
>  return bval if colormap is NO_COLOR_MAP else color_text(bval, colormap, wcwidth.wcswidth(bval))



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org