[jira] [Commented] (MAPREDUCE-3562) Concurrency issues in MultipleOutputs,JobControl,Counters

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170296#comment-13170296 ] 

Hadoop QA commented on MAPREDUCE-3562:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12507536/MAPREDUCE-3562.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.mapreduce.v2.app.TestStagingCleanup
                  org.apache.hadoop.mapreduce.v2.app.TestJobEndNotifier

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1460//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1460//console

This message is automatically generated.
                
> Concurrency issues in MultipleOutputs,JobControl,Counters
> ---------------------------------------------------------
>
>                 Key: MAPREDUCE-3562
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3562
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Ravi Teja Ch N V
>            Assignee: Ravi Teja Ch N V
>         Attachments: MAPREDUCE-3562.patch
>
>
> bq.MultipleOutputs 
>   The close of recordwriters should be synchronized. 
>   public void close() throws IOException, InterruptedException { 
>     for (RecordWriter writer : recordWriters.values()) { 
>       writer.close(context); 
> bq.JobControl.java 
>   the getters of the jobs to be synchronized. 
> bq.Counters.java 
>    makeEscapedCompactString to be made synchronized. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira