You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by bb-coder <gi...@git.apache.org> on 2017/08/03 15:10:17 UTC
[GitHub] incubator-weex pull request #571: [iOS]Of the 32-bit device, BOOL's encode i...
GitHub user bb-coder opened a pull request:
https://github.com/apache/incubator-weex/pull/571
[iOS]Of the 32-bit device, BOOL's encode is' c ', and the lack of this code will lead to errors.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bb-coder/incubator-weex 0.16-dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/571.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #571
----
commit 76247ab7acbc0c26e5c9c4d450fe4d233f796b1b
Author: bb-coder <bb...@gmail.com>
Date: 2017-08-03T13:56:07Z
[iOS]Of the 32-bit device, BOOL's encode is' c ', and the lack of this code will lead to errors.
commit 3cedfac3dde8f6c2694a4973de5804a821383d60
Author: bb-coder <bb...@gmail.com>
Date: 2017-08-03T15:08:07Z
Revert "[iOS]Of the 32-bit device, BOOL's encode is' c ', and the lack of this code will lead to errors."
This reverts commit 76247ab7acbc0c26e5c9c4d450fe4d233f796b1b.
commit 3c7d0a97025cfe2e875e3be7dcc04b0434326166
Author: bb-coder <bb...@gmail.com>
Date: 2017-08-03T15:09:25Z
[iOS]Of the 32-bit device, BOOL's encode is' c ', and the lack of this code will lead to errors. @notdanger
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #571: [iOS]Of the 32-bit device, BOOL's encode is' c ',...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/571
<!--
0 failure:
3 warning: No Changelog chan..., This PR modify SD..., This PR should up...
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR modify SDK code without add/modify testcases.</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR should update related documents as well. </td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #571: [iOS]Of the 32-bit device, BOOL's encode i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/571
---
[GitHub] incubator-weex issue #571: [iOS]Of the 32-bit device, BOOL's encode is' c ',...
Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on the issue:
https://github.com/apache/incubator-weex/pull/571
hi @bb-coder did you try it on 32bit device and there is an error ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---