You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/11/06 11:12:33 UTC
[GitHub] ScienJus opened a new pull request #1887: Support for overriding
config with agent options
ScienJus opened a new pull request #1887: Support for overriding config with agent options
URL: https://github.com/apache/incubator-skywalking/pull/1887
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [x] Improve performance
- Related issues
#1881
___
### New feature or improvement
- Describe the details and related test reports.
I wrote a unit test for parsing options, it's hard to do unit testing the agent, so i confirm the config result through local integration test:
```
$ java -javaagent:./agent/skywalking-agent.jar=agent.application_code=ui,collector.backend_service=127.0.0.1:11800,logging.level=info -Xms256M -Xmx512M -jar ./webapp/skywalking-webapp.jar
DEBUG 2018-11-06 18:58:48:780 AgentPackagePath : The beacon class location is jar:file:/Users/mobike/java/mobike-repos/infra/incubator-skywalking/dist/apache-skywalking-apm-incubating/agent/skywalking-agent.jar!/org/apache/skywalking/apm/agent/core/boot/AgentPackagePath.class.
INFO 2018-11-06 18:58:48:781 SnifferConfigInitializer : Config file found in /Users/mobike/java/mobike-repos/infra/incubator-skywalking/dist/apache-skywalking-apm-incubating/agent/config/agent.config.
INFO 2018-11-06 18:58:48:793 SnifferConfigInitializer : Agent options is: agent.application_code=ui,collector.backend_service=duke.mobike.io:11800,logging.level=info
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services