You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "sandynz (via GitHub)" <gi...@apache.org> on 2023/02/24 14:06:58 UTC
[GitHub] [shardingsphere] sandynz opened a new pull request, #24344: Configure MySQL table name case-sensitive for pipeline E2E
sandynz opened a new pull request, #24344:
URL: https://github.com/apache/shardingsphere/pull/24344
Changes proposed in this pull request:
- Configure MySQL table name case-sensitive for pipeline E2E
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on pull request #24344: Compatible with case-sensitive table name in pipeline E2E
Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz commented on PR #24344:
URL: https://github.com/apache/shardingsphere/pull/24344#issuecomment-1651591748
Too much code conflicts, submit new PR later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24344: Compatible with case-sensitive table name in pipeline E2E
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24344:
URL: https://github.com/apache/shardingsphere/pull/24344#issuecomment-1456159091
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24344?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24344](https://codecov.io/gh/apache/shardingsphere/pull/24344?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (89ff236) into [master](https://codecov.io/gh/apache/shardingsphere/commit/5ed5a7af542c926c4ff9cf29deb877b85a784f6b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5ed5a7a) will **increase** coverage by `0.27%`.
> The diff coverage is `59.87%`.
> :exclamation: Current head 89ff236 differs from pull request most recent head 358f4ea. Consider uploading reports for the commit 358f4ea to get more accurate results
```diff
@@ Coverage Diff @@
## master #24344 +/- ##
============================================
+ Coverage 49.93% 50.20% +0.27%
- Complexity 1584 1588 +4
============================================
Files 3257 3269 +12
Lines 53586 53690 +104
Branches 9869 9883 +14
============================================
+ Hits 26758 26956 +198
+ Misses 24429 24325 -104
- Partials 2399 2409 +10
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ser/core/kernel/KernelDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/24344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2Rpc3RzcWwvcGFyc2VyL2NvcmUva2VybmVsL0tlcm5lbERpc3RTUUxTdGF0ZW1lbnRWaXNpdG9yLmphdmE=) | `5.26% <0.00%> (-0.06%)` | :arrow_down: |
| [...ardingsphere/infra/state/cluster/ClusterState.java](https://codecov.io/gh/apache/shardingsphere/pull/24344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9zdGF0ZS9jbHVzdGVyL0NsdXN0ZXJTdGF0ZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...phere/infra/state/cluster/ClusterStateContext.java](https://codecov.io/gh/apache/shardingsphere/pull/24344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9zdGF0ZS9jbHVzdGVyL0NsdXN0ZXJTdGF0ZUNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ata/pipeline/api/config/ImporterConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/24344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2FwaS9jb25maWcvSW1wb3J0ZXJDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ere/data/pipeline/api/metadata/IdentifierName.java](https://codecov.io/gh/apache/shardingsphere/pull/24344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2FwaS9tZXRhZGF0YS9JZGVudGlmaWVyTmFtZS5qYXZh) | `58.33% <ø> (ø)` | |
| [...ore/metadata/loader/PipelineTableMetaDataUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/24344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL21ldGFkYXRhL2xvYWRlci9QaXBlbGluZVRhYmxlTWV0YURhdGFVdGlsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ne/core/sqlbuilder/AbstractPipelineSQLBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/24344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL3NxbGJ1aWxkZXIvQWJzdHJhY3RQaXBlbGluZVNRTEJ1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...sphere/mode/metadata/persist/node/ComputeNode.java](https://codecov.io/gh/apache/shardingsphere/pull/24344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21ldGFkYXRhL3BlcnNpc3Qvbm9kZS9Db21wdXRlTm9kZS5qYXZh) | `64.70% <0.00%> (-4.05%)` | :arrow_down: |
| [...atus/compute/service/ComputeNodeStatusService.java](https://codecov.io/gh/apache/shardingsphere/pull/24344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9tYW5hZ2VyL2NsdXN0ZXIvY29vcmRpbmF0b3IvcmVnaXN0cnkvc3RhdHVzL2NvbXB1dGUvc2VydmljZS9Db21wdXRlTm9kZVN0YXR1c1NlcnZpY2UuamF2YQ==) | `71.11% <ø> (ø)` | |
| [...dingsphere/proxy/backend/context/ProxyContext.java](https://codecov.io/gh/apache/shardingsphere/pull/24344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9iYWNrZW5kL2NvbnRleHQvUHJveHlDb250ZXh0LmphdmE=) | `90.00% <ø> (ø)` | |
| ... and [38 more](https://codecov.io/gh/apache/shardingsphere/pull/24344?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz closed pull request #24344: Compatible with case-sensitive table name in pipeline E2E
Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz closed pull request #24344: Compatible with case-sensitive table name in pipeline E2E
URL: https://github.com/apache/shardingsphere/pull/24344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on pull request #24344: Compatible with case-sensitive table name in pipeline E2E
Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz commented on PR #24344:
URL: https://github.com/apache/shardingsphere/pull/24344#issuecomment-1456117457
MySQL:
Set `lower_case_table_names=0` in `my.cnf` to enable table name case-sensitive.
PostgreSQL:
Use double quote table name, e.g. `"T_ORDER_ITEM"`.
When `T_ORDER_ITEM` is used when creating table, it'll be converted to `t_order_item` and it's case-sensitive in metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org