You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/09/18 06:08:15 UTC
[GitHub] [helix] pkuwm opened a new pull request #1379: Add metric annotations to each resource method
pkuwm opened a new pull request #1379:
URL: https://github.com/apache/helix/pull/1379
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
Resolves #1378
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
To enable availability monitoring for helix rest, we want request latency and response metrics. And make sure metrics are not consuming too much memory, we want to categorize the resource methods into "read" and "write". GET verb is read, and POST, DELETE, UPDATE are writes.
### Tests
- [ ] The following tests are written for this issue:
Integration tests will be added later after we merge the PR #1377 so we can run end to end and test metrics.
- [ ] The following is the result of the "mvn test" command on the appropriate module:
Build and run tests successfully
```
[INFO] Apache Helix ....................................... SUCCESS [ 1.172 s]
[INFO] Apache Helix :: Metrics Common ..................... SUCCESS [ 1.731 s]
[INFO] Apache Helix :: Metadata Store Directory Common .... SUCCESS [ 0.887 s]
[INFO] Apache Helix :: ZooKeeper API ...................... SUCCESS [ 1.754 s]
[INFO] Apache Helix :: Helix Common ....................... SUCCESS [ 0.557 s]
[INFO] Apache Helix :: Core ............................... SUCCESS [ 8.559 s]
[INFO] Apache Helix :: Admin Webapp ....................... SUCCESS [ 1.215 s]
[INFO] Apache Helix :: Restful Interface .................. SUCCESS [ 2.765 s]
[INFO] Apache Helix :: Distributed Lock ................... SUCCESS [ 0.402 s]
[INFO] Apache Helix :: HelixAgent ......................... SUCCESS [ 0.617 s]
[INFO] Apache Helix :: Recipes ............................ SUCCESS [ 0.017 s]
[INFO] Apache Helix :: Recipes :: Rabbitmq Consumer Group . SUCCESS [ 0.464 s]
[INFO] Apache Helix :: Recipes :: Rsync Replicated File Store SUCCESS [ 0.489 s]
[INFO] Apache Helix :: Recipes :: distributed lock manager SUCCESS [ 0.425 s]
[INFO] Apache Helix :: Recipes :: distributed task execution SUCCESS [ 0.452 s]
[INFO] Apache Helix :: Recipes :: service discovery ....... SUCCESS [ 0.481 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 22.782 s
[INFO] Finished at: 2020-09-17T23:07:34-07:00
[INFO] ------------------------------------------------------------------------
```
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm merged pull request #1379: Add metric annotations to each resource method
Posted by GitBox <gi...@apache.org>.
pkuwm merged pull request #1379:
URL: https://github.com/apache/helix/pull/1379
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on pull request #1379: Add metric annotations to each resource method
Posted by GitBox <gi...@apache.org>.
pkuwm commented on pull request #1379:
URL: https://github.com/apache/helix/pull/1379#issuecomment-696433180
@dasahcc Thanks for the review! I've verified the annotations worked.
This PR is ready to be merged, approved by @dasahcc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on pull request #1379: Add metric annotations to each resource method
Posted by GitBox <gi...@apache.org>.
pkuwm commented on pull request #1379:
URL: https://github.com/apache/helix/pull/1379#issuecomment-696433180
@dasahcc Thanks for the review! I've verified the annotations worked.
This PR is ready to be merged, approved by @dasahcc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm merged pull request #1379: Add metric annotations to each resource method
Posted by GitBox <gi...@apache.org>.
pkuwm merged pull request #1379:
URL: https://github.com/apache/helix/pull/1379
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on pull request #1379: Add metric annotations to each resource method
Posted by GitBox <gi...@apache.org>.
pkuwm commented on pull request #1379:
URL: https://github.com/apache/helix/pull/1379#issuecomment-696433180
@dasahcc Thanks for the review! I've verified the annotations worked.
This PR is ready to be merged, approved by @dasahcc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm merged pull request #1379: Add metric annotations to each resource method
Posted by GitBox <gi...@apache.org>.
pkuwm merged pull request #1379:
URL: https://github.com/apache/helix/pull/1379
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org