[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #2342: Register classes with Solr Field annotations for reflection

[GitBox <gi...@apache.org>]

aldettinger commented on a change in pull request #2342:
URL: https://github.com/apache/camel-quarkus/pull/2342#discussion_r596180203



##########
File path: extensions/solr/deployment/src/main/java/org/apache/camel/quarkus/component/solr/deployment/SolrProcessor.java
##########
@@ -35,4 +40,27 @@ FeatureBuildItem feature() {
     ExtensionSslNativeSupportBuildItem activateSslNativeSupport() {
         return new ExtensionSslNativeSupportBuildItem(FEATURE);
     }
+
+    @BuildStep
+    void registerForReflection(BuildProducer<ReflectiveClassBuildItem> reflectiveClass, CombinedIndexBuildItem combinedIndex) {
+        // Register any classes within the application archive that contain the Solr Field annotation
+        combinedIndex.getIndex()
+                .getAnnotations(FIELD_DOT_NAME)
+                .stream()
+                .map(annotationInstance -> {
+                    AnnotationTarget target = annotationInstance.target();
+                    AnnotationTarget.Kind kind = target.kind();
+                    if (kind.equals(AnnotationTarget.Kind.FIELD)) {
+                        ClassInfo classInfo = target.asField().declaringClass();
+                        return new ReflectiveClassBuildItem(false, true, classInfo.name().toString());
+                    } else if (kind.equals(AnnotationTarget.Kind.METHOD)) {
+                        ClassInfo classInfo = target.asMethod().declaringClass();
+                        return new ReflectiveClassBuildItem(true, false, classInfo.name().toString());
+                    } else {
+                        throw new RuntimeException(

Review comment:
       As I'm reading it, would solr extend targets for the @Field annotation one day, then we would break the build ? what about a WARN log instead ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org