You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/04/15 04:01:39 UTC

[GitHub] [iotdb] neuyilan opened a new pull request #3007: [Distributed] fix the plan index miss

neuyilan opened a new pull request #3007:
URL: https://github.com/apache/iotdb/pull/3007


   
   
   After the bug was resolved, we can see that the plan index is not zero
   ![image](https://user-images.githubusercontent.com/6237070/114812144-05c68c80-9de2-11eb-8e90-ddb6c4ba38be.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] neuyilan commented on pull request #3007: [Distributed] fix the plan index miss

Posted by GitBox <gi...@apache.org>.
neuyilan commented on pull request #3007:
URL: https://github.com/apache/iotdb/pull/3007#issuecomment-820145546


   > Why call `setIndex` until the log is serialized? What if the coordinator node executes log locally? Maybe we should overload the `setIndex` function in `PhysicalPlan` for these plans so that the raft index will be set successfully at the beginning.
   
   Of course, thanks for your reivew.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] mychaow merged pull request #3007: [Distributed] fix the plan index miss

Posted by GitBox <gi...@apache.org>.
mychaow merged pull request #3007:
URL: https://github.com/apache/iotdb/pull/3007


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org