You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Yurii Shylov <yu...@gmail.com> on 2014/11/10 16:16:20 UTC
Review Request 27810: Alerts: SNMP Target for Notifications
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27810/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Srimanth Gunturi.
Bugs: AMBARI-8251
https://issues.apache.org/jira/browse/AMBARI-8251
Repository: ambari
Description
-------
The Ambari Server will be responsible for scheduling the dispatching of alerts that have been received and not yet processed for outbound notification. On a schedule, Ambari will determine the alert targets that should be receiving some sort of notification and then it will gather all alert data for all alerts that are destined for that alert target.
SNMP is a required notification mechanism. Each alert defined in the system will act as an SNMP trap.
Templates should be used where applicable (ie email/velocity) in order to provide robust, customizable notifications.
Diffs
-----
ambari-server/pom.xml 4e7477e
ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java 9514474
ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchFactory.java 13f2da2
ambari-server/src/main/java/org/apache/ambari/server/notifications/Notification.java 12dffd7
ambari-server/src/main/java/org/apache/ambari/server/notifications/NotificationDispatcher.java 10946be
ambari-server/src/main/java/org/apache/ambari/server/notifications/Recipient.java 933038b
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcher.java a5dad84
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java 72487b3
ambari-server/src/test/java/org/apache/ambari/server/notifications/EmailDispatcherTest.java 1e7689f
ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcherTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/27810/diff/
Testing
-------
In progress
Thanks,
Yurii Shylov
Re: Review Request 27810: Alerts: SNMP Target for Notifications
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27810/#review64440
-----------------------------------------------------------
I think that this dispatcher needs some heavy documentation so that developers know how the various properties affect dispatching. Also, the capitalization issue hasn't been fixed. If we can't agree on a public field capitalization convention, then I'd just make public getters/setters for all properties and move them to private fields.
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/27810/#comment107149>
Missing documentation.
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/27810/#comment107150>
Missing documentation.
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/27810/#comment107152>
This still isn't handling the PDU response.
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/27810/#comment107151>
Missing documentation.
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/27810/#comment107153>
Missing documentation - probably each enumeration should also have documnetation to describe what exactly it does.
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/27810/#comment107154>
Missing documentation.
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/27810/#comment107155>
Missing documentation.
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/27810/#comment107156>
Missing documentation.
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/27810/#comment107157>
Missing documentation.
- Jonathan Hurley
On Dec. 8, 2014, 7:53 a.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27810/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 7:53 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Srimanth Gunturi, and Yusaku Sako.
>
>
> Bugs: AMBARI-8251
> https://issues.apache.org/jira/browse/AMBARI-8251
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The Ambari Server will be responsible for scheduling the dispatching of alerts that have been received and not yet processed for outbound notification. On a schedule, Ambari will determine the alert targets that should be receiving some sort of notification and then it will gather all alert data for all alerts that are destined for that alert target.
> SNMP is a required notification mechanism. Each alert defined in the system will act as an SNMP trap.
> Templates should be used where applicable (ie email/velocity) in order to provide robust, customizable notifications.
>
>
> Diffs
> -----
>
> ambari-server/pom.xml 4076d73
> ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java 9514474
> ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchFactory.java e690e76
> ambari-server/src/main/java/org/apache/ambari/server/notifications/Notification.java 12dffd7
> ambari-server/src/main/java/org/apache/ambari/server/notifications/NotificationDispatcher.java 10946be
> ambari-server/src/main/java/org/apache/ambari/server/notifications/Recipient.java 933038b
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcher.java f979c03
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java 69f3393
> ambari-server/src/test/java/org/apache/ambari/server/notifications/EmailDispatcherTest.java 1e7689f
> ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcherTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/state/services/AlertNoticeDispatchServiceTest.java 2e984bf
>
> Diff: https://reviews.apache.org/r/27810/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [4.589s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.429s]
> [INFO] Ambari Web ........................................ SUCCESS [52.018s]
> [INFO] Ambari Views ...................................... SUCCESS [15.517s]
> [INFO] Ambari Admin View ................................. SUCCESS [1:07.079s]
> [INFO] Ambari Server ..................................... SUCCESS [1:04:44.218s]
> [INFO] Ambari Agent ...................................... SUCCESS [28.370s]
> [INFO] Ambari Client ..................................... SUCCESS [0.733s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.351s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [17.228s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.639s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.162s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [10.510s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:08:04.344s
> [INFO] Finished at: Wed Nov 26 15:11:12 CET 2014
> [INFO] Final Memory: 58M/676M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 27810: Alerts: SNMP Target for Notifications
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27810/#review65084
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Dec. 11, 2014, 3:23 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27810/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 3:23 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Srimanth Gunturi, and Yusaku Sako.
>
>
> Bugs: AMBARI-8251
> https://issues.apache.org/jira/browse/AMBARI-8251
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The Ambari Server will be responsible for scheduling the dispatching of alerts that have been received and not yet processed for outbound notification. On a schedule, Ambari will determine the alert targets that should be receiving some sort of notification and then it will gather all alert data for all alerts that are destined for that alert target.
> SNMP is a required notification mechanism. Each alert defined in the system will act as an SNMP trap.
> Templates should be used where applicable (ie email/velocity) in order to provide robust, customizable notifications.
>
>
> Diffs
> -----
>
> ambari-server/pom.xml f1170c9
> ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchFactory.java e690e76
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcherTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27810/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [4.589s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.429s]
> [INFO] Ambari Web ........................................ SUCCESS [52.018s]
> [INFO] Ambari Views ...................................... SUCCESS [15.517s]
> [INFO] Ambari Admin View ................................. SUCCESS [1:07.079s]
> [INFO] Ambari Server ..................................... SUCCESS [1:04:44.218s]
> [INFO] Ambari Agent ...................................... SUCCESS [28.370s]
> [INFO] Ambari Client ..................................... SUCCESS [0.733s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.351s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [17.228s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.639s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.162s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [10.510s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:08:04.344s
> [INFO] Finished at: Wed Nov 26 15:11:12 CET 2014
> [INFO] Final Memory: 58M/676M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 27810: Alerts: SNMP Target for Notifications
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27810/#review65085
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Dec. 15, 2014, 8:35 a.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27810/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2014, 8:35 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Nate Cole, Srimanth Gunturi, and Yusaku Sako.
>
>
> Bugs: AMBARI-8251
> https://issues.apache.org/jira/browse/AMBARI-8251
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The Ambari Server will be responsible for scheduling the dispatching of alerts that have been received and not yet processed for outbound notification. On a schedule, Ambari will determine the alert targets that should be receiving some sort of notification and then it will gather all alert data for all alerts that are destined for that alert target.
> SNMP is a required notification mechanism. Each alert defined in the system will act as an SNMP trap.
> Templates should be used where applicable (ie email/velocity) in order to provide robust, customizable notifications.
>
>
> Diffs
> -----
>
> ambari-server/pom.xml f1170c9
> ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchFactory.java e690e76
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcherTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27810/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [4.589s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.429s]
> [INFO] Ambari Web ........................................ SUCCESS [52.018s]
> [INFO] Ambari Views ...................................... SUCCESS [15.517s]
> [INFO] Ambari Admin View ................................. SUCCESS [1:07.079s]
> [INFO] Ambari Server ..................................... SUCCESS [1:04:44.218s]
> [INFO] Ambari Agent ...................................... SUCCESS [28.370s]
> [INFO] Ambari Client ..................................... SUCCESS [0.733s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.351s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [17.228s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.639s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.162s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [10.510s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:08:04.344s
> [INFO] Finished at: Wed Nov 26 15:11:12 CET 2014
> [INFO] Final Memory: 58M/676M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 27810: Alerts: SNMP Target for Notifications
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27810/
-----------------------------------------------------------
(Updated Дек. 15, 2014, 1:35 п.п.)
Review request for Ambari, Jonathan Hurley, Nate Cole, Srimanth Gunturi, and Yusaku Sako.
Bugs: AMBARI-8251
https://issues.apache.org/jira/browse/AMBARI-8251
Repository: ambari
Description
-------
The Ambari Server will be responsible for scheduling the dispatching of alerts that have been received and not yet processed for outbound notification. On a schedule, Ambari will determine the alert targets that should be receiving some sort of notification and then it will gather all alert data for all alerts that are destined for that alert target.
SNMP is a required notification mechanism. Each alert defined in the system will act as an SNMP trap.
Templates should be used where applicable (ie email/velocity) in order to provide robust, customizable notifications.
Diffs
-----
ambari-server/pom.xml f1170c9
ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchFactory.java e690e76
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcherTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/27810/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [4.589s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.429s]
[INFO] Ambari Web ........................................ SUCCESS [52.018s]
[INFO] Ambari Views ...................................... SUCCESS [15.517s]
[INFO] Ambari Admin View ................................. SUCCESS [1:07.079s]
[INFO] Ambari Server ..................................... SUCCESS [1:04:44.218s]
[INFO] Ambari Agent ...................................... SUCCESS [28.370s]
[INFO] Ambari Client ..................................... SUCCESS [0.733s]
[INFO] Ambari Python Client .............................. SUCCESS [1.351s]
[INFO] Ambari Groovy Client .............................. SUCCESS [17.228s]
[INFO] Ambari Shell ...................................... SUCCESS [0.639s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.162s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [10.510s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:08:04.344s
[INFO] Finished at: Wed Nov 26 15:11:12 CET 2014
[INFO] Final Memory: 58M/676M
[INFO] ------------------------------------------------------------------------
Thanks,
Yurii Shylov
Re: Review Request 27810: Alerts: SNMP Target for Notifications
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27810/
-----------------------------------------------------------
(Updated Дек. 11, 2014, 8:23 п.п.)
Review request for Ambari, Jonathan Hurley, Srimanth Gunturi, and Yusaku Sako.
Changes
-------
Documentation added, PDU response is now handled
Bugs: AMBARI-8251
https://issues.apache.org/jira/browse/AMBARI-8251
Repository: ambari
Description
-------
The Ambari Server will be responsible for scheduling the dispatching of alerts that have been received and not yet processed for outbound notification. On a schedule, Ambari will determine the alert targets that should be receiving some sort of notification and then it will gather all alert data for all alerts that are destined for that alert target.
SNMP is a required notification mechanism. Each alert defined in the system will act as an SNMP trap.
Templates should be used where applicable (ie email/velocity) in order to provide robust, customizable notifications.
Diffs (updated)
-----
ambari-server/pom.xml f1170c9
ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchFactory.java e690e76
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcherTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/27810/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [4.589s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.429s]
[INFO] Ambari Web ........................................ SUCCESS [52.018s]
[INFO] Ambari Views ...................................... SUCCESS [15.517s]
[INFO] Ambari Admin View ................................. SUCCESS [1:07.079s]
[INFO] Ambari Server ..................................... SUCCESS [1:04:44.218s]
[INFO] Ambari Agent ...................................... SUCCESS [28.370s]
[INFO] Ambari Client ..................................... SUCCESS [0.733s]
[INFO] Ambari Python Client .............................. SUCCESS [1.351s]
[INFO] Ambari Groovy Client .............................. SUCCESS [17.228s]
[INFO] Ambari Shell ...................................... SUCCESS [0.639s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.162s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [10.510s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:08:04.344s
[INFO] Finished at: Wed Nov 26 15:11:12 CET 2014
[INFO] Final Memory: 58M/676M
[INFO] ------------------------------------------------------------------------
Thanks,
Yurii Shylov
Re: Review Request 27810: Alerts: SNMP Target for Notifications
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27810/
-----------------------------------------------------------
(Updated Дек. 8, 2014, 12:53 п.п.)
Review request for Ambari, Jonathan Hurley, Srimanth Gunturi, and Yusaku Sako.
Changes
-------
Patch updated according to comments
Bugs: AMBARI-8251
https://issues.apache.org/jira/browse/AMBARI-8251
Repository: ambari
Description
-------
The Ambari Server will be responsible for scheduling the dispatching of alerts that have been received and not yet processed for outbound notification. On a schedule, Ambari will determine the alert targets that should be receiving some sort of notification and then it will gather all alert data for all alerts that are destined for that alert target.
SNMP is a required notification mechanism. Each alert defined in the system will act as an SNMP trap.
Templates should be used where applicable (ie email/velocity) in order to provide robust, customizable notifications.
Diffs (updated)
-----
ambari-server/pom.xml 4076d73
ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java 9514474
ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchFactory.java e690e76
ambari-server/src/main/java/org/apache/ambari/server/notifications/Notification.java 12dffd7
ambari-server/src/main/java/org/apache/ambari/server/notifications/NotificationDispatcher.java 10946be
ambari-server/src/main/java/org/apache/ambari/server/notifications/Recipient.java 933038b
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcher.java f979c03
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java 69f3393
ambari-server/src/test/java/org/apache/ambari/server/notifications/EmailDispatcherTest.java 1e7689f
ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcherTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/state/services/AlertNoticeDispatchServiceTest.java 2e984bf
Diff: https://reviews.apache.org/r/27810/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [4.589s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.429s]
[INFO] Ambari Web ........................................ SUCCESS [52.018s]
[INFO] Ambari Views ...................................... SUCCESS [15.517s]
[INFO] Ambari Admin View ................................. SUCCESS [1:07.079s]
[INFO] Ambari Server ..................................... SUCCESS [1:04:44.218s]
[INFO] Ambari Agent ...................................... SUCCESS [28.370s]
[INFO] Ambari Client ..................................... SUCCESS [0.733s]
[INFO] Ambari Python Client .............................. SUCCESS [1.351s]
[INFO] Ambari Groovy Client .............................. SUCCESS [17.228s]
[INFO] Ambari Shell ...................................... SUCCESS [0.639s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.162s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [10.510s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:08:04.344s
[INFO] Finished at: Wed Nov 26 15:11:12 CET 2014
[INFO] Final Memory: 58M/676M
[INFO] ------------------------------------------------------------------------
Thanks,
Yurii Shylov
Re: Review Request 27810: Alerts: SNMP Target for Notifications
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27810/#review63368
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/27810/#comment105585>
It's cleaner and less error prone to put the required properties in a static list.
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/27810/#comment105603>
Why not just use SnmpVersion.values() directly?
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/27810/#comment105604>
Target security needs to be addressed for v2 and v3.
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/27810/#comment105605>
I'm guessing this is a synchronous send event (which is fine). But if it's synchrounous, then a PDU response is returned which should be evaluated before calling ```successCallback(...)```
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/27810/#comment105607>
Why not also handle v3 since you're using the PDU factory anyway?
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/27810/#comment105602>
This method is not needed.
- Jonathan Hurley
On Nov. 26, 2014, 12:19 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27810/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2014, 12:19 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Srimanth Gunturi, and Yusaku Sako.
>
>
> Bugs: AMBARI-8251
> https://issues.apache.org/jira/browse/AMBARI-8251
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The Ambari Server will be responsible for scheduling the dispatching of alerts that have been received and not yet processed for outbound notification. On a schedule, Ambari will determine the alert targets that should be receiving some sort of notification and then it will gather all alert data for all alerts that are destined for that alert target.
> SNMP is a required notification mechanism. Each alert defined in the system will act as an SNMP trap.
> Templates should be used where applicable (ie email/velocity) in order to provide robust, customizable notifications.
>
>
> Diffs
> -----
>
> ambari-server/pom.xml e03b626
> ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java 9514474
> ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchFactory.java e690e76
> ambari-server/src/main/java/org/apache/ambari/server/notifications/Notification.java 12dffd7
> ambari-server/src/main/java/org/apache/ambari/server/notifications/NotificationDispatcher.java 10946be
> ambari-server/src/main/java/org/apache/ambari/server/notifications/Recipient.java 933038b
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcher.java f979c03
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java 69f3393
> ambari-server/src/test/java/org/apache/ambari/server/notifications/EmailDispatcherTest.java 1e7689f
> ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcherTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/state/services/AlertNoticeDispatchServiceTest.java 2e984bf
>
> Diff: https://reviews.apache.org/r/27810/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [4.589s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.429s]
> [INFO] Ambari Web ........................................ SUCCESS [52.018s]
> [INFO] Ambari Views ...................................... SUCCESS [15.517s]
> [INFO] Ambari Admin View ................................. SUCCESS [1:07.079s]
> [INFO] Ambari Server ..................................... SUCCESS [1:04:44.218s]
> [INFO] Ambari Agent ...................................... SUCCESS [28.370s]
> [INFO] Ambari Client ..................................... SUCCESS [0.733s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.351s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [17.228s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.639s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.162s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [10.510s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:08:04.344s
> [INFO] Finished at: Wed Nov 26 15:11:12 CET 2014
> [INFO] Final Memory: 58M/676M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 27810: Alerts: SNMP Target for Notifications
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27810/
-----------------------------------------------------------
(Updated Ноя. 26, 2014, 5:19 п.п.)
Review request for Ambari, Jonathan Hurley, Srimanth Gunturi, and Yusaku Sako.
Bugs: AMBARI-8251
https://issues.apache.org/jira/browse/AMBARI-8251
Repository: ambari
Description
-------
The Ambari Server will be responsible for scheduling the dispatching of alerts that have been received and not yet processed for outbound notification. On a schedule, Ambari will determine the alert targets that should be receiving some sort of notification and then it will gather all alert data for all alerts that are destined for that alert target.
SNMP is a required notification mechanism. Each alert defined in the system will act as an SNMP trap.
Templates should be used where applicable (ie email/velocity) in order to provide robust, customizable notifications.
Diffs
-----
ambari-server/pom.xml e03b626
ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java 9514474
ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchFactory.java e690e76
ambari-server/src/main/java/org/apache/ambari/server/notifications/Notification.java 12dffd7
ambari-server/src/main/java/org/apache/ambari/server/notifications/NotificationDispatcher.java 10946be
ambari-server/src/main/java/org/apache/ambari/server/notifications/Recipient.java 933038b
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcher.java f979c03
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java 69f3393
ambari-server/src/test/java/org/apache/ambari/server/notifications/EmailDispatcherTest.java 1e7689f
ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcherTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/state/services/AlertNoticeDispatchServiceTest.java 2e984bf
Diff: https://reviews.apache.org/r/27810/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [4.589s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.429s]
[INFO] Ambari Web ........................................ SUCCESS [52.018s]
[INFO] Ambari Views ...................................... SUCCESS [15.517s]
[INFO] Ambari Admin View ................................. SUCCESS [1:07.079s]
[INFO] Ambari Server ..................................... SUCCESS [1:04:44.218s]
[INFO] Ambari Agent ...................................... SUCCESS [28.370s]
[INFO] Ambari Client ..................................... SUCCESS [0.733s]
[INFO] Ambari Python Client .............................. SUCCESS [1.351s]
[INFO] Ambari Groovy Client .............................. SUCCESS [17.228s]
[INFO] Ambari Shell ...................................... SUCCESS [0.639s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.162s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [10.510s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:08:04.344s
[INFO] Finished at: Wed Nov 26 15:11:12 CET 2014
[INFO] Final Memory: 58M/676M
[INFO] ------------------------------------------------------------------------
Thanks,
Yurii Shylov
Re: Review Request 27810: Alerts: SNMP Target for Notifications
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27810/
-----------------------------------------------------------
(Updated Ноя. 26, 2014, 5:13 п.п.)
Review request for Ambari, Jonathan Hurley and Srimanth Gunturi.
Changes
-------
Support for SNMP v2 was added
Bugs: AMBARI-8251
https://issues.apache.org/jira/browse/AMBARI-8251
Repository: ambari
Description
-------
The Ambari Server will be responsible for scheduling the dispatching of alerts that have been received and not yet processed for outbound notification. On a schedule, Ambari will determine the alert targets that should be receiving some sort of notification and then it will gather all alert data for all alerts that are destined for that alert target.
SNMP is a required notification mechanism. Each alert defined in the system will act as an SNMP trap.
Templates should be used where applicable (ie email/velocity) in order to provide robust, customizable notifications.
Diffs (updated)
-----
ambari-server/pom.xml e03b626
ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java 9514474
ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchFactory.java e690e76
ambari-server/src/main/java/org/apache/ambari/server/notifications/Notification.java 12dffd7
ambari-server/src/main/java/org/apache/ambari/server/notifications/NotificationDispatcher.java 10946be
ambari-server/src/main/java/org/apache/ambari/server/notifications/Recipient.java 933038b
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcher.java f979c03
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java 69f3393
ambari-server/src/test/java/org/apache/ambari/server/notifications/EmailDispatcherTest.java 1e7689f
ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcherTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/state/services/AlertNoticeDispatchServiceTest.java 2e984bf
Diff: https://reviews.apache.org/r/27810/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [4.589s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.429s]
[INFO] Ambari Web ........................................ SUCCESS [52.018s]
[INFO] Ambari Views ...................................... SUCCESS [15.517s]
[INFO] Ambari Admin View ................................. SUCCESS [1:07.079s]
[INFO] Ambari Server ..................................... SUCCESS [1:04:44.218s]
[INFO] Ambari Agent ...................................... SUCCESS [28.370s]
[INFO] Ambari Client ..................................... SUCCESS [0.733s]
[INFO] Ambari Python Client .............................. SUCCESS [1.351s]
[INFO] Ambari Groovy Client .............................. SUCCESS [17.228s]
[INFO] Ambari Shell ...................................... SUCCESS [0.639s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.162s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [10.510s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:08:04.344s
[INFO] Finished at: Wed Nov 26 15:11:12 CET 2014
[INFO] Final Memory: 58M/676M
[INFO] ------------------------------------------------------------------------
Thanks,
Yurii Shylov
Re: Review Request 27810: Alerts: SNMP Target for Notifications
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Nov. 10, 2014, 11:09 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java, line 30
> > <https://reviews.apache.org/r/27810/diff/1/?file=756757#file756757line30>
> >
> > Public fields should be capitalized.
>
> Yurii Shylov wrote:
> Sun's convention says that fields should be in camelCase, and I haven't found any specific rules for Ambari which would imply that they should be capitalized
Ambari's convention for public, non-encapsulated fields has been to use a capitalized word.
> On Nov. 10, 2014, 11:09 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java, line 98
> > <https://reviews.apache.org/r/27810/diff/1/?file=756763#file756763line98>
> >
> > SNMPv2 PDU types are not supported by this. Should this be a determination based on the supplied properties?
>
> Yurii Shylov wrote:
> I think that making pdu time dependant on properties should be done in separate ticket. PDU.V1TRAP was tested and looks like it works fine
Yes, but many companies run with security enabled in v2c; This option won't work with that.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27810/#review60609
-----------------------------------------------------------
On Nov. 10, 2014, 10:49 a.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27810/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2014, 10:49 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Srimanth Gunturi.
>
>
> Bugs: AMBARI-8251
> https://issues.apache.org/jira/browse/AMBARI-8251
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The Ambari Server will be responsible for scheduling the dispatching of alerts that have been received and not yet processed for outbound notification. On a schedule, Ambari will determine the alert targets that should be receiving some sort of notification and then it will gather all alert data for all alerts that are destined for that alert target.
> SNMP is a required notification mechanism. Each alert defined in the system will act as an SNMP trap.
> Templates should be used where applicable (ie email/velocity) in order to provide robust, customizable notifications.
>
>
> Diffs
> -----
>
> ambari-server/pom.xml 4e7477e
> ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java 9514474
> ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchFactory.java 13f2da2
> ambari-server/src/main/java/org/apache/ambari/server/notifications/Notification.java 12dffd7
> ambari-server/src/main/java/org/apache/ambari/server/notifications/NotificationDispatcher.java 10946be
> ambari-server/src/main/java/org/apache/ambari/server/notifications/Recipient.java 933038b
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcher.java a5dad84
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java 72487b3
> ambari-server/src/test/java/org/apache/ambari/server/notifications/EmailDispatcherTest.java 1e7689f
> ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcherTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27810/diff/
>
>
> Testing
> -------
>
> Total run:693
> Total errors:0
> Total failures:0
> OK
>
> Results :
>
> Tests run: 2225, Failures: 0, Errors: 0, Skipped: 14
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 27810: Alerts: SNMP Target for Notifications
Posted by Yurii Shylov <yu...@gmail.com>.
> On Ноя. 10, 2014, 4:09 п.п., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java, line 30
> > <https://reviews.apache.org/r/27810/diff/1/?file=756757#file756757line30>
> >
> > Public fields should be capitalized.
>
> Yurii Shylov wrote:
> Sun's convention says that fields should be in camelCase, and I haven't found any specific rules for Ambari which would imply that they should be capitalized
>
> Jonathan Hurley wrote:
> Ambari's convention for public, non-encapsulated fields has been to use a capitalized word.
Where can I check for Ambari's conventions? I was using https://cwiki.apache.org/confluence/display/AMBARI/Coding+Guidelines+for+Ambari. Can you talk with Yusaku to update that document?
- Yurii
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27810/#review60609
-----------------------------------------------------------
On Ноя. 10, 2014, 3:49 п.п., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27810/
> -----------------------------------------------------------
>
> (Updated Ноя. 10, 2014, 3:49 п.п.)
>
>
> Review request for Ambari, Jonathan Hurley and Srimanth Gunturi.
>
>
> Bugs: AMBARI-8251
> https://issues.apache.org/jira/browse/AMBARI-8251
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The Ambari Server will be responsible for scheduling the dispatching of alerts that have been received and not yet processed for outbound notification. On a schedule, Ambari will determine the alert targets that should be receiving some sort of notification and then it will gather all alert data for all alerts that are destined for that alert target.
> SNMP is a required notification mechanism. Each alert defined in the system will act as an SNMP trap.
> Templates should be used where applicable (ie email/velocity) in order to provide robust, customizable notifications.
>
>
> Diffs
> -----
>
> ambari-server/pom.xml 4e7477e
> ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java 9514474
> ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchFactory.java 13f2da2
> ambari-server/src/main/java/org/apache/ambari/server/notifications/Notification.java 12dffd7
> ambari-server/src/main/java/org/apache/ambari/server/notifications/NotificationDispatcher.java 10946be
> ambari-server/src/main/java/org/apache/ambari/server/notifications/Recipient.java 933038b
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcher.java a5dad84
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java 72487b3
> ambari-server/src/test/java/org/apache/ambari/server/notifications/EmailDispatcherTest.java 1e7689f
> ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcherTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27810/diff/
>
>
> Testing
> -------
>
> Total run:693
> Total errors:0
> Total failures:0
> OK
>
> Results :
>
> Tests run: 2225, Failures: 0, Errors: 0, Skipped: 14
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 27810: Alerts: SNMP Target for Notifications
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Nov. 10, 2014, 11:09 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java, line 30
> > <https://reviews.apache.org/r/27810/diff/1/?file=756757#file756757line30>
> >
> > Public fields should be capitalized.
>
> Yurii Shylov wrote:
> Sun's convention says that fields should be in camelCase, and I haven't found any specific rules for Ambari which would imply that they should be capitalized
>
> Jonathan Hurley wrote:
> Ambari's convention for public, non-encapsulated fields has been to use a capitalized word.
>
> Yurii Shylov wrote:
> Where can I check for Ambari's conventions? I was using https://cwiki.apache.org/confluence/display/AMBARI/Coding+Guidelines+for+Ambari. Can you talk with Yusaku to update that document?
Sure, we can get the document updated. It actually doesn't mention public fields naming conventions, so we'll need to add that.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27810/#review60609
-----------------------------------------------------------
On Nov. 10, 2014, 10:49 a.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27810/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2014, 10:49 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Srimanth Gunturi.
>
>
> Bugs: AMBARI-8251
> https://issues.apache.org/jira/browse/AMBARI-8251
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The Ambari Server will be responsible for scheduling the dispatching of alerts that have been received and not yet processed for outbound notification. On a schedule, Ambari will determine the alert targets that should be receiving some sort of notification and then it will gather all alert data for all alerts that are destined for that alert target.
> SNMP is a required notification mechanism. Each alert defined in the system will act as an SNMP trap.
> Templates should be used where applicable (ie email/velocity) in order to provide robust, customizable notifications.
>
>
> Diffs
> -----
>
> ambari-server/pom.xml 4e7477e
> ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java 9514474
> ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchFactory.java 13f2da2
> ambari-server/src/main/java/org/apache/ambari/server/notifications/Notification.java 12dffd7
> ambari-server/src/main/java/org/apache/ambari/server/notifications/NotificationDispatcher.java 10946be
> ambari-server/src/main/java/org/apache/ambari/server/notifications/Recipient.java 933038b
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcher.java a5dad84
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java 72487b3
> ambari-server/src/test/java/org/apache/ambari/server/notifications/EmailDispatcherTest.java 1e7689f
> ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcherTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27810/diff/
>
>
> Testing
> -------
>
> Total run:693
> Total errors:0
> Total failures:0
> OK
>
> Results :
>
> Tests run: 2225, Failures: 0, Errors: 0, Skipped: 14
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 27810: Alerts: SNMP Target for Notifications
Posted by Yurii Shylov <yu...@gmail.com>.
> On Ноя. 10, 2014, 4:09 п.п., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java, line 30
> > <https://reviews.apache.org/r/27810/diff/1/?file=756757#file756757line30>
> >
> > Public fields should be capitalized.
Sun's convention says that fields should be in camelCase, and I haven't found any specific rules for Ambari which would imply that they should be capitalized
> On Ноя. 10, 2014, 4:09 п.п., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java, line 98
> > <https://reviews.apache.org/r/27810/diff/1/?file=756763#file756763line98>
> >
> > SNMPv2 PDU types are not supported by this. Should this be a determination based on the supplied properties?
I think that making pdu time dependant on properties should be done in separate ticket. PDU.V1TRAP was tested and looks like it works fine
- Yurii
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27810/#review60609
-----------------------------------------------------------
On Ноя. 10, 2014, 3:49 п.п., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27810/
> -----------------------------------------------------------
>
> (Updated Ноя. 10, 2014, 3:49 п.п.)
>
>
> Review request for Ambari, Jonathan Hurley and Srimanth Gunturi.
>
>
> Bugs: AMBARI-8251
> https://issues.apache.org/jira/browse/AMBARI-8251
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The Ambari Server will be responsible for scheduling the dispatching of alerts that have been received and not yet processed for outbound notification. On a schedule, Ambari will determine the alert targets that should be receiving some sort of notification and then it will gather all alert data for all alerts that are destined for that alert target.
> SNMP is a required notification mechanism. Each alert defined in the system will act as an SNMP trap.
> Templates should be used where applicable (ie email/velocity) in order to provide robust, customizable notifications.
>
>
> Diffs
> -----
>
> ambari-server/pom.xml 4e7477e
> ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java 9514474
> ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchFactory.java 13f2da2
> ambari-server/src/main/java/org/apache/ambari/server/notifications/Notification.java 12dffd7
> ambari-server/src/main/java/org/apache/ambari/server/notifications/NotificationDispatcher.java 10946be
> ambari-server/src/main/java/org/apache/ambari/server/notifications/Recipient.java 933038b
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcher.java a5dad84
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java 72487b3
> ambari-server/src/test/java/org/apache/ambari/server/notifications/EmailDispatcherTest.java 1e7689f
> ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcherTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27810/diff/
>
>
> Testing
> -------
>
> Total run:693
> Total errors:0
> Total failures:0
> OK
>
> Results :
>
> Tests run: 2225, Failures: 0, Errors: 0, Skipped: 14
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 27810: Alerts: SNMP Target for Notifications
Posted by Yurii Shylov <yu...@gmail.com>.
> On Ноя. 10, 2014, 4:09 п.п., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java, line 30
> > <https://reviews.apache.org/r/27810/diff/1/?file=756757#file756757line30>
> >
> > Public fields should be capitalized.
>
> Yurii Shylov wrote:
> Sun's convention says that fields should be in camelCase, and I haven't found any specific rules for Ambari which would imply that they should be capitalized
>
> Jonathan Hurley wrote:
> Ambari's convention for public, non-encapsulated fields has been to use a capitalized word.
>
> Yurii Shylov wrote:
> Where can I check for Ambari's conventions? I was using https://cwiki.apache.org/confluence/display/AMBARI/Coding+Guidelines+for+Ambari. Can you talk with Yusaku to update that document?
>
> Jonathan Hurley wrote:
> Sure, we can get the document updated. It actually doesn't mention public fields naming conventions, so we'll need to add that.
As the wiki wasn't updated and I haven't seen any other Ambari files following the suggested convention, the field names are still named according to java's default convention. I'll add Yusaku to review to clarify this.
- Yurii
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27810/#review60609
-----------------------------------------------------------
On Ноя. 26, 2014, 5:13 п.п., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27810/
> -----------------------------------------------------------
>
> (Updated Ноя. 26, 2014, 5:13 п.п.)
>
>
> Review request for Ambari, Jonathan Hurley and Srimanth Gunturi.
>
>
> Bugs: AMBARI-8251
> https://issues.apache.org/jira/browse/AMBARI-8251
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The Ambari Server will be responsible for scheduling the dispatching of alerts that have been received and not yet processed for outbound notification. On a schedule, Ambari will determine the alert targets that should be receiving some sort of notification and then it will gather all alert data for all alerts that are destined for that alert target.
> SNMP is a required notification mechanism. Each alert defined in the system will act as an SNMP trap.
> Templates should be used where applicable (ie email/velocity) in order to provide robust, customizable notifications.
>
>
> Diffs
> -----
>
> ambari-server/pom.xml e03b626
> ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java 9514474
> ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchFactory.java e690e76
> ambari-server/src/main/java/org/apache/ambari/server/notifications/Notification.java 12dffd7
> ambari-server/src/main/java/org/apache/ambari/server/notifications/NotificationDispatcher.java 10946be
> ambari-server/src/main/java/org/apache/ambari/server/notifications/Recipient.java 933038b
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcher.java f979c03
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java 69f3393
> ambari-server/src/test/java/org/apache/ambari/server/notifications/EmailDispatcherTest.java 1e7689f
> ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcherTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/state/services/AlertNoticeDispatchServiceTest.java 2e984bf
>
> Diff: https://reviews.apache.org/r/27810/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [4.589s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.429s]
> [INFO] Ambari Web ........................................ SUCCESS [52.018s]
> [INFO] Ambari Views ...................................... SUCCESS [15.517s]
> [INFO] Ambari Admin View ................................. SUCCESS [1:07.079s]
> [INFO] Ambari Server ..................................... SUCCESS [1:04:44.218s]
> [INFO] Ambari Agent ...................................... SUCCESS [28.370s]
> [INFO] Ambari Client ..................................... SUCCESS [0.733s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.351s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [17.228s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.639s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.162s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [10.510s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:08:04.344s
> [INFO] Finished at: Wed Nov 26 15:11:12 CET 2014
> [INFO] Final Memory: 58M/676M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 27810: Alerts: SNMP Target for Notifications
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27810/#review60609
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java
<https://reviews.apache.org/r/27810/#comment101977>
Public fields should be capitalized.
ambari-server/src/main/java/org/apache/ambari/server/notifications/Notification.java
<https://reviews.apache.org/r/27810/#comment101978>
Public fields should be capitalized.
ambari-server/src/main/java/org/apache/ambari/server/notifications/Recipient.java
<https://reviews.apache.org/r/27810/#comment101979>
Public fields should be capitalized.
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/27810/#comment101981>
SNMPv2 PDU types are not supported by this. Should this be a determination based on the supplied properties?
- Jonathan Hurley
On Nov. 10, 2014, 10:49 a.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27810/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2014, 10:49 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Srimanth Gunturi.
>
>
> Bugs: AMBARI-8251
> https://issues.apache.org/jira/browse/AMBARI-8251
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The Ambari Server will be responsible for scheduling the dispatching of alerts that have been received and not yet processed for outbound notification. On a schedule, Ambari will determine the alert targets that should be receiving some sort of notification and then it will gather all alert data for all alerts that are destined for that alert target.
> SNMP is a required notification mechanism. Each alert defined in the system will act as an SNMP trap.
> Templates should be used where applicable (ie email/velocity) in order to provide robust, customizable notifications.
>
>
> Diffs
> -----
>
> ambari-server/pom.xml 4e7477e
> ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java 9514474
> ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchFactory.java 13f2da2
> ambari-server/src/main/java/org/apache/ambari/server/notifications/Notification.java 12dffd7
> ambari-server/src/main/java/org/apache/ambari/server/notifications/NotificationDispatcher.java 10946be
> ambari-server/src/main/java/org/apache/ambari/server/notifications/Recipient.java 933038b
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcher.java a5dad84
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java 72487b3
> ambari-server/src/test/java/org/apache/ambari/server/notifications/EmailDispatcherTest.java 1e7689f
> ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcherTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27810/diff/
>
>
> Testing
> -------
>
> Total run:693
> Total errors:0
> Total failures:0
> OK
>
> Results :
>
> Tests run: 2225, Failures: 0, Errors: 0, Skipped: 14
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 27810: Alerts: SNMP Target for Notifications
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27810/
-----------------------------------------------------------
(Updated Ноя. 10, 2014, 3:49 п.п.)
Review request for Ambari, Jonathan Hurley and Srimanth Gunturi.
Bugs: AMBARI-8251
https://issues.apache.org/jira/browse/AMBARI-8251
Repository: ambari
Description
-------
The Ambari Server will be responsible for scheduling the dispatching of alerts that have been received and not yet processed for outbound notification. On a schedule, Ambari will determine the alert targets that should be receiving some sort of notification and then it will gather all alert data for all alerts that are destined for that alert target.
SNMP is a required notification mechanism. Each alert defined in the system will act as an SNMP trap.
Templates should be used where applicable (ie email/velocity) in order to provide robust, customizable notifications.
Diffs
-----
ambari-server/pom.xml 4e7477e
ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java 9514474
ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchFactory.java 13f2da2
ambari-server/src/main/java/org/apache/ambari/server/notifications/Notification.java 12dffd7
ambari-server/src/main/java/org/apache/ambari/server/notifications/NotificationDispatcher.java 10946be
ambari-server/src/main/java/org/apache/ambari/server/notifications/Recipient.java 933038b
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcher.java a5dad84
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java 72487b3
ambari-server/src/test/java/org/apache/ambari/server/notifications/EmailDispatcherTest.java 1e7689f
ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcherTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/27810/diff/
Testing (updated)
-------
Total run:693
Total errors:0
Total failures:0
OK
Results :
Tests run: 2225, Failures: 0, Errors: 0, Skipped: 14
Thanks,
Yurii Shylov