You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Maron <jm...@hortonworks.com> on 2015/09/02 21:36:27 UTC
Review Request 38065: leverage stack advisor to manifest config
changes in hive due to atlas availability
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38065/
-----------------------------------------------------------
Review request for Ambari, John Speidel, Sumit Mohanty, and Srimanth Gunturi.
Bugs: AMBARI-12978
https://issues.apache.org/jira/browse/AMBARI-12978
Repository: ambari
Description
-------
Rather than make modifications that are not visible to the user via the service scripts, the config changes that are required for hive when atlas is available in the cluster have been moved to the stack advisor. Some important points:
1) atlas.cluster.name and atlas.rest.address are now configuration properties that are defined in the service's hive-site.xml. They therefore appear as advanced hive-site properties in the UI.
2) When atlas is not installed, these two properties are set to a space so that hopefully no values are seen in the UI and the 'require-input' attribute of atlas.cluster.name does not trigger a requirement to specify a value.
3) When atlas is installed, the atlas.cluster.name is set to a null string and the 'require-input' property appears to trigger the expected "value required" logic in the UI. This is important since the cluster name property defines the namespace for the atlas queries associated with the given cluster (atlas supports multiple hive instances).
Diffs
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml f4e4b25
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 2d07726
ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 08c48d8
Diff: https://reviews.apache.org/r/38065/diff/
Testing
-------
- python unit tests
- installation of clusters:
1) Hive only followed by addition of atlas
2) hive and atlas together
(NOTE: still working thru some of the functional cluster test scenarios but wanted to proceed with a review process in parallel)
Thanks,
Jonathan Maron
Re: Review Request 38065: leverage stack advisor to manifest config
changes in hive due to atlas availability
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38065/#review98467
-----------------------------------------------------------
Ship it!
Ship It!
- Srimanth Gunturi
On Sept. 4, 2015, 9:16 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38065/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2015, 9:16 p.m.)
>
>
> Review request for Ambari, John Speidel, Sumit Mohanty, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-12978
> https://issues.apache.org/jira/browse/AMBARI-12978
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Rather than make modifications that are not visible to the user via the service scripts, the config changes that are required for hive when atlas is available in the cluster have been moved to the stack advisor. Some important points:
>
> 1) atlas.cluster.name and atlas.rest.address are now configuration properties that are defined in the service's hive-site.xml. They therefore appear as advanced hive-site properties in the UI.
> 2) When atlas is not installed, these two properties are set to a space so that hopefully no values are seen in the UI and the 'require-input' attribute of atlas.cluster.name does not trigger a requirement to specify a value.
> 3) When atlas is installed, the atlas.cluster.name is set to a null string and the 'require-input' property appears to trigger the expected "value required" logic in the UI. This is important since the cluster name property defines the namespace for the atlas queries associated with the given cluster (atlas supports multiple hive instances).
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml f4e4b25
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 2d07726
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 08c48d8
>
> Diff: https://reviews.apache.org/r/38065/diff/
>
>
> Testing
> -------
>
> - python unit tests
> - installation of clusters:
> 1) Hive only followed by addition of atlas
> 2) hive and atlas together
>
> (NOTE: still working thru some of the functional cluster test scenarios but wanted to proceed with a review process in parallel)
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 38065: leverage stack advisor to manifest config
changes in hive due to atlas availability
Posted by John Speidel <js...@hortonworks.com>.
> On Sept. 14, 2015, 3:53 p.m., John Speidel wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml, line 376
> > <https://reviews.apache.org/r/38065/diff/2/?file=1064287#file1064287line376>
> >
> > this will require that this property is set by the user when deploying via a blueprint even if Atlas isn't installed.
just noticed that this has been closed. I will file an Ambari Jira for this matter.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38065/#review98855
-----------------------------------------------------------
On Sept. 10, 2015, 9:59 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38065/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2015, 9:59 p.m.)
>
>
> Review request for Ambari, John Speidel, Sumit Mohanty, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-12978
> https://issues.apache.org/jira/browse/AMBARI-12978
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Rather than make modifications that are not visible to the user via the service scripts, the config changes that are required for hive when atlas is available in the cluster have been moved to the stack advisor. Some important points:
>
> 1) atlas.cluster.name and atlas.rest.address are now configuration properties that are defined in the service's hive-site.xml. They therefore appear as advanced hive-site properties in the UI.
> 2) When atlas is not installed, these two properties are set to a space so that hopefully no values are seen in the UI and the 'require-input' attribute of atlas.cluster.name does not trigger a requirement to specify a value.
> 3) When atlas is installed, the atlas.cluster.name is set to a null string and the 'require-input' property appears to trigger the expected "value required" logic in the UI. This is important since the cluster name property defines the namespace for the atlas queries associated with the given cluster (atlas supports multiple hive instances).
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml f4e4b25
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py affee98
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py c65e110
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py bea7d60
>
> Diff: https://reviews.apache.org/r/38065/diff/
>
>
> Testing
> -------
>
> - python unit tests
> - installation of clusters:
> 1) Hive only followed by addition of atlas
> 2) hive and atlas together
>
> (NOTE: still working thru some of the functional cluster test scenarios but wanted to proceed with a review process in parallel)
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 38065: leverage stack advisor to manifest config
changes in hive due to atlas availability
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38065/#review98855
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml (line 376)
<https://reviews.apache.org/r/38065/#comment155478>
this will require that this property is set by the user when deploying via a blueprint even if Atlas isn't installed.
- John Speidel
On Sept. 10, 2015, 9:59 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38065/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2015, 9:59 p.m.)
>
>
> Review request for Ambari, John Speidel, Sumit Mohanty, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-12978
> https://issues.apache.org/jira/browse/AMBARI-12978
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Rather than make modifications that are not visible to the user via the service scripts, the config changes that are required for hive when atlas is available in the cluster have been moved to the stack advisor. Some important points:
>
> 1) atlas.cluster.name and atlas.rest.address are now configuration properties that are defined in the service's hive-site.xml. They therefore appear as advanced hive-site properties in the UI.
> 2) When atlas is not installed, these two properties are set to a space so that hopefully no values are seen in the UI and the 'require-input' attribute of atlas.cluster.name does not trigger a requirement to specify a value.
> 3) When atlas is installed, the atlas.cluster.name is set to a null string and the 'require-input' property appears to trigger the expected "value required" logic in the UI. This is important since the cluster name property defines the namespace for the atlas queries associated with the given cluster (atlas supports multiple hive instances).
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml f4e4b25
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py affee98
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py c65e110
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py bea7d60
>
> Diff: https://reviews.apache.org/r/38065/diff/
>
>
> Testing
> -------
>
> - python unit tests
> - installation of clusters:
> 1) Hive only followed by addition of atlas
> 2) hive and atlas together
>
> (NOTE: still working thru some of the functional cluster test scenarios but wanted to proceed with a review process in parallel)
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 38065: leverage stack advisor to manifest config
changes in hive due to atlas availability
Posted by Jonathan Maron <jm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38065/#review98599
-----------------------------------------------------------
Is it spelled correctly in the actual file?
<property>
<type>atlast-env</type>
<name>metadata_port</name>
</property>
The code snippet you pasted indicates "atlast-env"...
- Jonathan Maron
On Sept. 10, 2015, 9:59 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38065/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2015, 9:59 p.m.)
>
>
> Review request for Ambari, John Speidel, Sumit Mohanty, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-12978
> https://issues.apache.org/jira/browse/AMBARI-12978
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Rather than make modifications that are not visible to the user via the service scripts, the config changes that are required for hive when atlas is available in the cluster have been moved to the stack advisor. Some important points:
>
> 1) atlas.cluster.name and atlas.rest.address are now configuration properties that are defined in the service's hive-site.xml. They therefore appear as advanced hive-site properties in the UI.
> 2) When atlas is not installed, these two properties are set to a space so that hopefully no values are seen in the UI and the 'require-input' attribute of atlas.cluster.name does not trigger a requirement to specify a value.
> 3) When atlas is installed, the atlas.cluster.name is set to a null string and the 'require-input' property appears to trigger the expected "value required" logic in the UI. This is important since the cluster name property defines the namespace for the atlas queries associated with the given cluster (atlas supports multiple hive instances).
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml f4e4b25
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py affee98
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py c65e110
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py bea7d60
>
> Diff: https://reviews.apache.org/r/38065/diff/
>
>
> Testing
> -------
>
> - python unit tests
> - installation of clusters:
> 1) Hive only followed by addition of atlas
> 2) hive and atlas together
>
> (NOTE: still working thru some of the functional cluster test scenarios but wanted to proceed with a review process in parallel)
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 38065: leverage stack advisor to manifest config
changes in hive due to atlas availability
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
> On Sept. 11, 2015, 6:15 a.m., Srimanth Gunturi wrote:
> > To make add-service wizard change configs in Hive also I had to add the extra depends-on in 'hive.exec.pre.hooks'
> >
> > <property>
> > <name>hive.exec.pre.hooks</name>
> > <value>org.apache.hadoop.hive.ql.hooks.ATSHook</value>
> > <description>
> > Comma-separated list of pre-execution hooks to be invoked for each statement.
> > A pre-execution hook is specified as the name of a Java class which implements the
> > org.apache.hadoop.hive.ql.hooks.ExecuteWithHookContext interface.
> > </description>
> > <depends-on>
> > <property>
> > <type>hive-env</type>
> > <name>hive_timeline_logging_enabled</name>
> > </property>
> > </depends-on>
> > </property>
<property>
<name>hive.exec.post.hooks</name>
<value>org.apache.hadoop.hive.ql.hooks.ATSHook</value>
<description>
Comma-separated list of post-execution hooks to be invoked for each statement.
A post-execution hook is specified as the name of a Java class which implements the
org.apache.hadoop.hive.ql.hooks.ExecuteWithHookContext interface.
</description>
<depends-on>
<property>
<type>hive-env</type>
<name>hive_timeline_logging_enabled</name>
</property>
<property>
<type>atlast-env</type>
<name>metadata_port</name>
</property>
</depends-on>
</property>
- Srimanth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38065/#review98564
-----------------------------------------------------------
On Sept. 10, 2015, 9:59 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38065/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2015, 9:59 p.m.)
>
>
> Review request for Ambari, John Speidel, Sumit Mohanty, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-12978
> https://issues.apache.org/jira/browse/AMBARI-12978
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Rather than make modifications that are not visible to the user via the service scripts, the config changes that are required for hive when atlas is available in the cluster have been moved to the stack advisor. Some important points:
>
> 1) atlas.cluster.name and atlas.rest.address are now configuration properties that are defined in the service's hive-site.xml. They therefore appear as advanced hive-site properties in the UI.
> 2) When atlas is not installed, these two properties are set to a space so that hopefully no values are seen in the UI and the 'require-input' attribute of atlas.cluster.name does not trigger a requirement to specify a value.
> 3) When atlas is installed, the atlas.cluster.name is set to a null string and the 'require-input' property appears to trigger the expected "value required" logic in the UI. This is important since the cluster name property defines the namespace for the atlas queries associated with the given cluster (atlas supports multiple hive instances).
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml f4e4b25
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py affee98
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py c65e110
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py bea7d60
>
> Diff: https://reviews.apache.org/r/38065/diff/
>
>
> Testing
> -------
>
> - python unit tests
> - installation of clusters:
> 1) Hive only followed by addition of atlas
> 2) hive and atlas together
>
> (NOTE: still working thru some of the functional cluster test scenarios but wanted to proceed with a review process in parallel)
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 38065: leverage stack advisor to manifest config
changes in hive due to atlas availability
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38065/#review98564
-----------------------------------------------------------
Ship it!
To make add-service wizard change configs in Hive also I had to add the extra depends-on in 'hive.exec.pre.hooks'
<property>
<name>hive.exec.pre.hooks</name>
<value>org.apache.hadoop.hive.ql.hooks.ATSHook</value>
<description>
Comma-separated list of pre-execution hooks to be invoked for each statement.
A pre-execution hook is specified as the name of a Java class which implements the
org.apache.hadoop.hive.ql.hooks.ExecuteWithHookContext interface.
</description>
<depends-on>
<property>
<type>hive-env</type>
<name>hive_timeline_logging_enabled</name>
</property>
</depends-on>
</property>
- Srimanth Gunturi
On Sept. 10, 2015, 9:59 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38065/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2015, 9:59 p.m.)
>
>
> Review request for Ambari, John Speidel, Sumit Mohanty, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-12978
> https://issues.apache.org/jira/browse/AMBARI-12978
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Rather than make modifications that are not visible to the user via the service scripts, the config changes that are required for hive when atlas is available in the cluster have been moved to the stack advisor. Some important points:
>
> 1) atlas.cluster.name and atlas.rest.address are now configuration properties that are defined in the service's hive-site.xml. They therefore appear as advanced hive-site properties in the UI.
> 2) When atlas is not installed, these two properties are set to a space so that hopefully no values are seen in the UI and the 'require-input' attribute of atlas.cluster.name does not trigger a requirement to specify a value.
> 3) When atlas is installed, the atlas.cluster.name is set to a null string and the 'require-input' property appears to trigger the expected "value required" logic in the UI. This is important since the cluster name property defines the namespace for the atlas queries associated with the given cluster (atlas supports multiple hive instances).
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml f4e4b25
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py affee98
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py c65e110
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py bea7d60
>
> Diff: https://reviews.apache.org/r/38065/diff/
>
>
> Testing
> -------
>
> - python unit tests
> - installation of clusters:
> 1) Hive only followed by addition of atlas
> 2) hive and atlas together
>
> (NOTE: still working thru some of the functional cluster test scenarios but wanted to proceed with a review process in parallel)
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 38065: leverage stack advisor to manifest config
changes in hive due to atlas availability
Posted by Jonathan Maron <jm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38065/
-----------------------------------------------------------
(Updated Sept. 10, 2015, 9:59 p.m.)
Review request for Ambari, John Speidel, Sumit Mohanty, and Srimanth Gunturi.
Bugs: AMBARI-12978
https://issues.apache.org/jira/browse/AMBARI-12978
Repository: ambari
Description
-------
Rather than make modifications that are not visible to the user via the service scripts, the config changes that are required for hive when atlas is available in the cluster have been moved to the stack advisor. Some important points:
1) atlas.cluster.name and atlas.rest.address are now configuration properties that are defined in the service's hive-site.xml. They therefore appear as advanced hive-site properties in the UI.
2) When atlas is not installed, these two properties are set to a space so that hopefully no values are seen in the UI and the 'require-input' attribute of atlas.cluster.name does not trigger a requirement to specify a value.
3) When atlas is installed, the atlas.cluster.name is set to a null string and the 'require-input' property appears to trigger the expected "value required" logic in the UI. This is important since the cluster name property defines the namespace for the atlas queries associated with the given cluster (atlas supports multiple hive instances).
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml f4e4b25
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py affee98
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py c65e110
ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py bea7d60
Diff: https://reviews.apache.org/r/38065/diff/
Testing
-------
- python unit tests
- installation of clusters:
1) Hive only followed by addition of atlas
2) hive and atlas together
(NOTE: still working thru some of the functional cluster test scenarios but wanted to proceed with a review process in parallel)
Thanks,
Jonathan Maron
Re: Review Request 38065: leverage stack advisor to manifest config
changes in hive due to atlas availability
Posted by Jonathan Maron <jm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38065/
-----------------------------------------------------------
(Updated Sept. 4, 2015, 9:16 p.m.)
Review request for Ambari, John Speidel, Sumit Mohanty, and Srimanth Gunturi.
Changes
-------
Updated given Srimanth's input. I've tested the unit tests, installed both services, and installed hive and added atlas. The correct recommendations are being made.
I have some code to guard against a space value for atlas.cluster.name, but now not certain it's required?
Bugs: AMBARI-12978
https://issues.apache.org/jira/browse/AMBARI-12978
Repository: ambari
Description
-------
Rather than make modifications that are not visible to the user via the service scripts, the config changes that are required for hive when atlas is available in the cluster have been moved to the stack advisor. Some important points:
1) atlas.cluster.name and atlas.rest.address are now configuration properties that are defined in the service's hive-site.xml. They therefore appear as advanced hive-site properties in the UI.
2) When atlas is not installed, these two properties are set to a space so that hopefully no values are seen in the UI and the 'require-input' attribute of atlas.cluster.name does not trigger a requirement to specify a value.
3) When atlas is installed, the atlas.cluster.name is set to a null string and the 'require-input' property appears to trigger the expected "value required" logic in the UI. This is important since the cluster name property defines the namespace for the atlas queries associated with the given cluster (atlas supports multiple hive instances).
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml f4e4b25
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 2d07726
ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 08c48d8
Diff: https://reviews.apache.org/r/38065/diff/
Testing
-------
- python unit tests
- installation of clusters:
1) Hive only followed by addition of atlas
2) hive and atlas together
(NOTE: still working thru some of the functional cluster test scenarios but wanted to proceed with a review process in parallel)
Thanks,
Jonathan Maron
Re: Review Request 38065: leverage stack advisor to manifest config
changes in hive due to atlas availability
Posted by Jonathan Maron <jm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38065/#review97623
-----------------------------------------------------------
I think I need to make some modifications to the cluster name logic. will upload another patch.
- Jonathan Maron
On Sept. 2, 2015, 7:36 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38065/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 7:36 p.m.)
>
>
> Review request for Ambari, John Speidel, Sumit Mohanty, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-12978
> https://issues.apache.org/jira/browse/AMBARI-12978
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Rather than make modifications that are not visible to the user via the service scripts, the config changes that are required for hive when atlas is available in the cluster have been moved to the stack advisor. Some important points:
>
> 1) atlas.cluster.name and atlas.rest.address are now configuration properties that are defined in the service's hive-site.xml. They therefore appear as advanced hive-site properties in the UI.
> 2) When atlas is not installed, these two properties are set to a space so that hopefully no values are seen in the UI and the 'require-input' attribute of atlas.cluster.name does not trigger a requirement to specify a value.
> 3) When atlas is installed, the atlas.cluster.name is set to a null string and the 'require-input' property appears to trigger the expected "value required" logic in the UI. This is important since the cluster name property defines the namespace for the atlas queries associated with the given cluster (atlas supports multiple hive instances).
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml f4e4b25
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a5abcb5
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 2d07726
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 08c48d8
>
> Diff: https://reviews.apache.org/r/38065/diff/
>
>
> Testing
> -------
>
> - python unit tests
> - installation of clusters:
> 1) Hive only followed by addition of atlas
> 2) hive and atlas together
>
> (NOTE: still working thru some of the functional cluster test scenarios but wanted to proceed with a review process in parallel)
>
>
> Thanks,
>
> Jonathan Maron
>
>