You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/01/17 17:31:11 UTC

[GitHub] [lucene-solr] madrob opened a new pull request #1181: LUCENE-9145 First pass addressing static analysis

madrob opened a new pull request #1181: LUCENE-9145 First pass addressing static analysis
URL: https://github.com/apache/lucene-solr/pull/1181
 
 
   Fixed a bunch of the smaller warnings found by error-prone compiler
   plugin, while ignoring a lot of the bigger ones.
   
   This is just the warnings found by #1176 without the build changes

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] dweiss commented on issue #1181: LUCENE-9145 First pass addressing static analysis

Posted by GitBox <gi...@apache.org>.
dweiss commented on issue #1181: LUCENE-9145 First pass addressing static analysis
URL: https://github.com/apache/lucene-solr/pull/1181#issuecomment-575727247
 
 
   I'd run a full test suite and if it passes just commit it in. Most of these look like legitimate bug fixes!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] madrob merged pull request #1181: LUCENE-9145 First pass addressing static analysis

Posted by GitBox <gi...@apache.org>.
madrob merged pull request #1181: LUCENE-9145 First pass addressing static analysis
URL: https://github.com/apache/lucene-solr/pull/1181
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org