You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by Sebastian Schelter <ss...@apache.org> on 2014/04/12 13:17:52 UTC
Review Request 20282: MAHOUT-1508 Performance problems with sparse matrices
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20282/
-----------------------------------------------------------
Review request for mahout.
Repository: mahout
Description
-------
matrixLike() in our sparse vectors should return a SparseMatrix not return a SparseRowMatrix as its mainly used for outer products which produce many zero rows
MatrixWritable should preserve the type of sparse matrix (currently it always deserializes as SparseRowMatrix)
provide an optimized assign for addition in SparseMatrix
Diffs
-----
trunk/core/src/main/java/org/apache/mahout/math/MatrixWritable.java 1586372
trunk/core/src/test/java/org/apache/mahout/math/MatrixWritableTest.java 1586372
trunk/math/src/main/java/org/apache/mahout/math/RandomAccessSparseVector.java 1586372
trunk/math/src/main/java/org/apache/mahout/math/SequentialAccessSparseVector.java 1586372
trunk/math/src/main/java/org/apache/mahout/math/SparseMatrix.java 1586372
trunk/math/src/test/java/org/apache/mahout/math/TestSparseMatrix.java 1586372
Diff: https://reviews.apache.org/r/20282/diff/
Testing
-------
passed unittests
Thanks,
Sebastian Schelter
Re: Review Request 20282: MAHOUT-1508 Performance problems with sparse
matrices
Posted by Suneel Marthi <sm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20282/#review40207
-----------------------------------------------------------
Ship it!
Ship It!
- Suneel Marthi
On April 12, 2014, 11:17 a.m., Sebastian Schelter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20282/
> -----------------------------------------------------------
>
> (Updated April 12, 2014, 11:17 a.m.)
>
>
> Review request for mahout.
>
>
> Repository: mahout
>
>
> Description
> -------
>
>
> matrixLike() in our sparse vectors should return a SparseMatrix not return a SparseRowMatrix as its mainly used for outer products which produce many zero rows
> MatrixWritable should preserve the type of sparse matrix (currently it always deserializes as SparseRowMatrix)
> provide an optimized assign for addition in SparseMatrix
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/mahout/math/MatrixWritable.java 1586372
> trunk/core/src/test/java/org/apache/mahout/math/MatrixWritableTest.java 1586372
> trunk/math/src/main/java/org/apache/mahout/math/RandomAccessSparseVector.java 1586372
> trunk/math/src/main/java/org/apache/mahout/math/SequentialAccessSparseVector.java 1586372
> trunk/math/src/main/java/org/apache/mahout/math/SparseMatrix.java 1586372
> trunk/math/src/test/java/org/apache/mahout/math/TestSparseMatrix.java 1586372
>
> Diff: https://reviews.apache.org/r/20282/diff/
>
>
> Testing
> -------
>
> passed unittests
>
>
> Thanks,
>
> Sebastian Schelter
>
>