You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2025/05/27 15:40:30 UTC
(superset) 18/19: linting
This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a commit to branch mv_components
in repository https://gitbox.apache.org/repos/asf/superset.git
commit f785d3d3435a4b04e921273292408adbad4a6f8f
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Sun May 25 19:12:28 2025 -0700
linting
---
superset-frontend/.eslintrc.js | 2 +-
superset-frontend/package.json | 6 ++++++
.../superset-ui-core/src/components/Loading/index.tsx | 2 +-
.../superset-ui-core/src/components/Select/constants.ts | 2 +-
.../superset-ui-core}/src/utils/rankedSearchCompare.test.ts | 0
.../superset-ui-core}/src/utils/rankedSearchCompare.ts | 0
.../test/chart-composition/ChartFrame.test.tsx | 12 ++++++------
7 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/superset-frontend/.eslintrc.js b/superset-frontend/.eslintrc.js
index 54bf6f4aa2..bcd4d7b5de 100644
--- a/superset-frontend/.eslintrc.js
+++ b/superset-frontend/.eslintrc.js
@@ -331,7 +331,7 @@ module.exports = {
'import/no-extraneous-dependencies': [
'error',
{
- devDependencies: true ,
+ devDependencies: true,
},
],
'no-only-tests/no-only-tests': 'error',
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
index a91ba5a8a0..223a0ed6ac 100644
--- a/superset-frontend/package.json
+++ b/superset-frontend/package.json
@@ -357,6 +357,12 @@
"webpack-sources": "^3.2.3",
"webpack-visualizer-plugin2": "^1.1.0"
},
+ "peerDependencies": {
+ "react-ace": "^10.1.0",
+ "ace-builds": "^1.41.0",
+ "regenerator-runtime": "^0.14.1",
+ "core-js": "^3.38.1"
+ },
"engines": {
"node": "^20.16.0",
"npm": "^10.8.1"
diff --git a/superset-frontend/packages/superset-ui-core/src/components/Loading/index.tsx b/superset-frontend/packages/superset-ui-core/src/components/Loading/index.tsx
index b7fe2dba5f..c97a27c2e7 100644
--- a/superset-frontend/packages/superset-ui-core/src/components/Loading/index.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Loading/index.tsx
@@ -19,7 +19,7 @@
import { styled } from '@superset-ui/core';
import cls from 'classnames';
-import { Loading } from '../assets';
+import { Loading as Loader } from '../assets';
import type { LoadingProps } from './types';
const LoaderImg = styled.img`
diff --git a/superset-frontend/packages/superset-ui-core/src/components/Select/constants.ts b/superset-frontend/packages/superset-ui-core/src/components/Select/constants.ts
index 84f5f01e4b..dd2797b4a5 100644
--- a/superset-frontend/packages/superset-ui-core/src/components/Select/constants.ts
+++ b/superset-frontend/packages/superset-ui-core/src/components/Select/constants.ts
@@ -17,8 +17,8 @@
* under the License.
*/
import { LabeledValue as AntdLabeledValue } from 'antd/es/select';
-import { rankedSearchCompare } from 'src/utils/rankedSearchCompare';
import { t } from '@superset-ui/core';
+import { rankedSearchCompare } from '../../utils/rankedSearchCompare';
import { RawValue } from './types';
export const MAX_TAG_COUNT = 4;
diff --git a/superset-frontend/src/utils/rankedSearchCompare.test.ts b/superset-frontend/packages/superset-ui-core/src/utils/rankedSearchCompare.test.ts
similarity index 100%
rename from superset-frontend/src/utils/rankedSearchCompare.test.ts
rename to superset-frontend/packages/superset-ui-core/src/utils/rankedSearchCompare.test.ts
diff --git a/superset-frontend/src/utils/rankedSearchCompare.ts b/superset-frontend/packages/superset-ui-core/src/utils/rankedSearchCompare.ts
similarity index 100%
rename from superset-frontend/src/utils/rankedSearchCompare.ts
rename to superset-frontend/packages/superset-ui-core/src/utils/rankedSearchCompare.ts
diff --git a/superset-frontend/packages/superset-ui-core/test/chart-composition/ChartFrame.test.tsx b/superset-frontend/packages/superset-ui-core/test/chart-composition/ChartFrame.test.tsx
index 4125bc0161..bb4ccd12ee 100644
--- a/superset-frontend/packages/superset-ui-core/test/chart-composition/ChartFrame.test.tsx
+++ b/superset-frontend/packages/superset-ui-core/test/chart-composition/ChartFrame.test.tsx
@@ -37,7 +37,7 @@ type Props = {
const renderChartFrame = (props: Props) => render(<ChartFrame {...props} />);
-it('renders content that requires smaller space than frame', () => {
+test('renders content that requires smaller space than frame', () => {
const { getByText } = renderChartFrame({
width: 400,
height: 400,
@@ -52,7 +52,7 @@ it('renders content that requires smaller space than frame', () => {
expect(getByText('400/400')).toBeInTheDocument();
});
-it('renders content without specifying content size', () => {
+test('renders content without specifying content size', () => {
const { getByText } = renderChartFrame({
width: 400,
height: 400,
@@ -65,7 +65,7 @@ it('renders content without specifying content size', () => {
expect(getByText('400/400')).toBeInTheDocument();
});
-it('renders content that requires equivalent size to frame', () => {
+test('renders content that requires equivalent size to frame', () => {
const { getByText } = renderChartFrame({
width: 400,
height: 400,
@@ -80,7 +80,7 @@ it('renders content that requires equivalent size to frame', () => {
expect(getByText('400/400')).toBeInTheDocument();
});
-it('renders content that requires space larger than frame', () => {
+test('renders content that requires space larger than frame', () => {
const { getByText, container } = renderChartFrame({
width: 400,
height: 400,
@@ -97,7 +97,7 @@ it('renders content that requires space larger than frame', () => {
expect(containerDiv).toHaveStyle({ overflowX: 'auto', overflowY: 'auto' });
});
-it('renders content when width is larger than frame', () => {
+test('renders content when width is larger than frame', () => {
const { getByText, container } = renderChartFrame({
width: 400,
height: 400,
@@ -113,7 +113,7 @@ it('renders content when width is larger than frame', () => {
expect(containerDiv).toHaveStyle({ overflowX: 'auto', overflowY: 'hidden' });
});
-it('renders content when height is larger than frame', () => {
+test('renders content when height is larger than frame', () => {
const { getByText, container } = renderChartFrame({
width: 400,
height: 400,