[jira] [Commented] (HADOOP-11889) Make checkstyle runnable from root project

["Jonathan Eagles (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-11889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522452#comment-14522452 ] 

Jonathan Eagles commented on HADOOP-11889:
------------------------------------------

>From a high level I would still like to see the checkstyle.xml file under the hadoop-build-tools src/main/resources. Perhaps that explains the build failure below.

Couple of minor nits below.
can we remove azure maven-checkstyle-plugin definition?
{code}
      <plugin>
          <groupId>org.apache.maven.plugins</groupId>
          <artifactId>maven-checkstyle-plugin</artifactId>
          <configuration>
            <!-- To run with the default Sun ruleset, 
                 comment out the configLocation line -->
            <configLocation>src/config/checkstyle.xml</configLocation>
          </configuration>
          
      </plugin>
{code}

Looks like a few typos
{code:title=hadoop-build-tools/pom.xml}
  <name>Apache Hadoop Build Toolst</name>
{code}

This is the first reference to dependency of hadoop artifact by version. I think we are safe without this.
{code:title=pom.xml}
            <dependency>
              <groupId>org.apache.hadoop</groupId>
              <artifactId>hadoop-build-tools</artifactId>
              <version>3.0.0-SNAPSHOT</version>
            </dependency>
{code}

the mvn checkstyle:checkstyle goal fails to the checkstyle/checkstyle.xml file being in the incorrect location
{code:title=pom.xml}
          <configuration>
            <configLocation>checkstyle/checkstyle.xml</configLocation>
            <failOnViolation>false</failOnViolation>
            <format>xml</format>
            <format>html</format>
            <outputFile>${project.build.directory}/test/checkstyle-errors.xml</outputFile>
           </configuration>
{code}

> Make checkstyle runnable from root project
> ------------------------------------------
>
>                 Key: HADOOP-11889
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11889
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build, test
>    Affects Versions: 2.7.0
>            Reporter: Gera Shegalov
>            Assignee: Gera Shegalov
>         Attachments: HADOOP-11889.001.patch, HADOOP-11889.002.patch
>
>
> Checkstyle -1 are hard to debug without submitting to Jenkins and downloading build artifacts.
> With this JIRA we 
> # remove identical checkstyle rules in hdfs which is identical to common 
> # move checkstyle plugin to the parent pom
> # update rules to ignore import



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)