You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/10/24 16:12:48 UTC
Review Request 27136: Stale configs indicators disappearing very long
for clients if restarting service via API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27136/
-----------------------------------------------------------
Review request for Ambari and Nate Cole.
Bugs: AMBARI-7946
https://issues.apache.org/jira/browse/AMBARI-7946
Repository: ambari
Description
-------
For example, restart indicators for Zookeeper cleared after about 5 minutes
for me.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java fa633c1
Diff: https://reviews.apache.org/r/27136/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 27136: Stale configs indicators disappearing very
long for clients if restarting service via API
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27136/#review58286
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Oct. 24, 2014, 11:56 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27136/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 11:56 a.m.)
>
>
> Review request for Ambari, Dmytro Sen and Nate Cole.
>
>
> Bugs: AMBARI-7946
> https://issues.apache.org/jira/browse/AMBARI-7946
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For example, restart indicators for Zookeeper cleared after about 5 minutes
> for me.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java fa633c1
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 8c975d6
>
> Diff: https://reviews.apache.org/r/27136/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 27136: Stale configs indicators disappearing very
long for clients if restarting service via API
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27136/#review58282
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Sen
On Окт. 24, 2014, 3:56 п.п., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27136/
> -----------------------------------------------------------
>
> (Updated Окт. 24, 2014, 3:56 п.п.)
>
>
> Review request for Ambari, Dmytro Sen and Nate Cole.
>
>
> Bugs: AMBARI-7946
> https://issues.apache.org/jira/browse/AMBARI-7946
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For example, restart indicators for Zookeeper cleared after about 5 minutes
> for me.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java fa633c1
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 8c975d6
>
> Diff: https://reviews.apache.org/r/27136/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 27136: Stale configs indicators disappearing very
long for clients if restarting service via API
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27136/
-----------------------------------------------------------
(Updated Oct. 24, 2014, 3:56 p.m.)
Review request for Ambari, Dmytro Sen and Nate Cole.
Bugs: AMBARI-7946
https://issues.apache.org/jira/browse/AMBARI-7946
Repository: ambari
Description
-------
For example, restart indicators for Zookeeper cleared after about 5 minutes
for me.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java fa633c1
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 8c975d6
Diff: https://reviews.apache.org/r/27136/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 27136: Stale configs indicators disappearing very
long for clients if restarting service via API
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27136/#review58272
-----------------------------------------------------------
In addition, you should also have uploaded the patch to the public jira so that the automated patch checker can verify and record that there were no tests.
- Nate Cole
On Oct. 24, 2014, 10:13 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27136/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 10:13 a.m.)
>
>
> Review request for Ambari, Dmytro Sen and Nate Cole.
>
>
> Bugs: AMBARI-7946
> https://issues.apache.org/jira/browse/AMBARI-7946
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For example, restart indicators for Zookeeper cleared after about 5 minutes
> for me.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java fa633c1
>
> Diff: https://reviews.apache.org/r/27136/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 27136: Stale configs indicators disappearing very
long for clients if restarting service via API
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27136/#review58271
-----------------------------------------------------------
Please add tests for this code path.
- Nate Cole
On Oct. 24, 2014, 10:13 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27136/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 10:13 a.m.)
>
>
> Review request for Ambari, Dmytro Sen and Nate Cole.
>
>
> Bugs: AMBARI-7946
> https://issues.apache.org/jira/browse/AMBARI-7946
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For example, restart indicators for Zookeeper cleared after about 5 minutes
> for me.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java fa633c1
>
> Diff: https://reviews.apache.org/r/27136/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 27136: Stale configs indicators disappearing very
long for clients if restarting service via API
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27136/
-----------------------------------------------------------
(Updated Oct. 24, 2014, 2:13 p.m.)
Review request for Ambari, Dmytro Sen and Nate Cole.
Bugs: AMBARI-7946
https://issues.apache.org/jira/browse/AMBARI-7946
Repository: ambari
Description
-------
For example, restart indicators for Zookeeper cleared after about 5 minutes
for me.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java fa633c1
Diff: https://reviews.apache.org/r/27136/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk