[GitHub] [spark] cloud-fan commented on a diff in pull request #42931: [SPARK-45137][CONNECT] Support map/array parameters in parameterized `sql()`

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #42931:
URL: https://github.com/apache/spark/pull/42931#discussion_r1328222151


##########
connector/connect/common/src/main/protobuf/spark/connect/commands.proto:
##########
@@ -65,6 +65,12 @@ message SqlCommand {
 
   // (Optional) A sequence of literal expressions for positional parameters in the SQL query text.
   repeated Expression.Literal pos_args = 3;
+
+  // (Optional) A map of parameter names to expressions.
+  map<string, Expression> arguments = 4;

Review Comment:
   `named_arguments`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org