You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/07/06 16:35:57 UTC
[GitHub] [bookkeeper] wenbingshen opened a new pull request, #3388: Remove meaningless useFallocate definition from DirectWriter
wenbingshen opened a new pull request, #3388:
URL: https://github.com/apache/bookkeeper/pull/3388
### Motivation
The work of the `BP-47` has been very meaningful. I am reading and learning it.
As the title, `useFallocate` in `DirectWriter` has no practical meaning, because the judgment of SystemUtils.IS_OS_LINUX always happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on pull request #3388: Add static declaration for useFallocate in DirectWriter
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on PR #3388:
URL: https://github.com/apache/bookkeeper/pull/3388#issuecomment-1179155490
PTAL. @Shoothzj Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on pull request #3388: Remove meaningless useFallocate definition from DirectWriter
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on PR #3388:
URL: https://github.com/apache/bookkeeper/pull/3388#issuecomment-1176439332
@hangc0276 @dlg99 @eolivelli Can you help take a look? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on pull request #3388: Remove meaningless useFallocate definition from DirectWriter
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on PR #3388:
URL: https://github.com/apache/bookkeeper/pull/3388#issuecomment-1176461897
Or `useFallocate` should be defined with `static`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 merged pull request #3388: Add static declaration for useFallocate in DirectWriter
Posted by GitBox <gi...@apache.org>.
hangc0276 merged PR #3388:
URL: https://github.com/apache/bookkeeper/pull/3388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on pull request #3388: Add static declaration for useFallocate in DirectWriter
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on PR #3388:
URL: https://github.com/apache/bookkeeper/pull/3388#issuecomment-1179155146
PTAL. @zymap Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3388: Remove meaningless useFallocate definition from DirectWriter
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on code in PR #3388:
URL: https://github.com/apache/bookkeeper/pull/3388#discussion_r915450706
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/directentrylogger/DirectWriter.java:
##########
@@ -49,7 +49,6 @@ class DirectWriter implements LogWriter {
final List<Future<?>> outstandingWrites = new ArrayList<Future<?>>();
Buffer nativeBuffer;
long offset;
- private volatile boolean useFallocate = true;
Review Comment:
It's better to use `static`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on a diff in pull request #3388: Add static declaration for useFallocate in DirectWriter
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on code in PR #3388:
URL: https://github.com/apache/bookkeeper/pull/3388#discussion_r915488071
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/directentrylogger/DirectWriter.java:
##########
@@ -49,7 +49,6 @@ class DirectWriter implements LogWriter {
final List<Future<?>> outstandingWrites = new ArrayList<Future<?>>();
Buffer nativeBuffer;
long offset;
- private volatile boolean useFallocate = true;
Review Comment:
It makes sense to me. I have addressed your comment. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org