You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2021/09/24 19:37:25 UTC

[GitHub] [tinkerpop] spmallette opened a new pull request #1481: TINKERPOP-2621 Allowed grammar to support empty arguments to within/without()

spmallette opened a new pull request #1481:
URL: https://github.com/apache/tinkerpop/pull/1481


   This functionality was allowed by Java/Groovy so it seems to follow that we have the same here:
   
   ```text
   gremlin> P.within()
   ==>within([])
   ```
   
   Builds with `mvn clean install` which means that the variants were content with this syntax as well. 
   
   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] spmallette merged pull request #1481: TINKERPOP-2621 Allowed grammar to support empty arguments to within/without()

Posted by GitBox <gi...@apache.org>.
spmallette merged pull request #1481:
URL: https://github.com/apache/tinkerpop/pull/1481


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] joshsh commented on pull request #1481: TINKERPOP-2621 Allowed grammar to support empty arguments to within/without()

Posted by GitBox <gi...@apache.org>.
joshsh commented on pull request #1481:
URL: https://github.com/apache/tinkerpop/pull/1481#issuecomment-926876957


   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] spmallette commented on pull request #1481: TINKERPOP-2621 Allowed grammar to support empty arguments to within/without()

Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1481:
URL: https://github.com/apache/tinkerpop/pull/1481#issuecomment-927821801


   > Could we also please create a JIRA to write an optimizer to handle empty within()/without() steps from the query? 
   
   Sure, i was more focused on just getting this to work for this PR but the thought crossed my mind that we could probably treat these cases a bit better.  Here's the JIRA: https://issues.apache.org/jira/browse/TINKERPOP-2625


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] divijvaidya commented on pull request #1481: TINKERPOP-2621 Allowed grammar to support empty arguments to within/without()

Posted by GitBox <gi...@apache.org>.
divijvaidya commented on pull request #1481:
URL: https://github.com/apache/tinkerpop/pull/1481#issuecomment-927742342


   Could we also please create a JIRA to write an optimizer to handle empty within()/without() steps from the query? Some examples of how the optimizers will behave are as follows (I can add more details in the JIRA later):
   1. `has(key, within(''))` is always false in which case we can replace `within('')` with `false`. 
   2. `has(hey, without(''))` is always true in which case this step/`HasContainer` can be removed from the traversal as a filter.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org