You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by jm...@apache.org on 2007/09/24 13:58:56 UTC

svn commit: r578771 - /spamassassin/trunk/masses/mass-check

Author: jm
Date: Mon Sep 24 04:58:55 2007
New Revision: 578771

URL: http://svn.apache.org/viewvc?rev=578771&view=rev
Log:
massively increase retry timeout for client-server mass-check; the SA zone can take an extremely long time due to its crappy I/O performance

Modified:
    spamassassin/trunk/masses/mass-check

Modified: spamassassin/trunk/masses/mass-check
URL: http://svn.apache.org/viewvc/spamassassin/trunk/masses/mass-check?rev=578771&r1=578770&r2=578771&view=diff
==============================================================================
--- spamassassin/trunk/masses/mass-check (original)
+++ spamassassin/trunk/masses/mass-check Mon Sep 24 04:58:55 2007
@@ -1716,7 +1716,10 @@
   }
 
   my $made_conn_once = 0;
-  my $conn_retries = 60;        # 1 hour
+
+  # 6 hours; it can take the SpamAssassin zone this long to perform the
+  # scan stage if the ArchiveIterator cache is cold
+  my $conn_retries = 60 * 6;
 
   # keep going until something stops us.
   while (1) {



Re: svn commit: r578771 - /spamassassin/trunk/masses/mass-check

Posted by "Daryl C. W. O'Shea" <sp...@dostech.ca>.
Can this retry not be done by a script wrapped around mass-check on the 
clients you're running these checks on (failure to connect already exits 
non-zero)?  An hour timeout was excessive for most people, 6 hours, is 
well, more than excessive.

Alternatively, make it an option that defaults to only a few minutes of 
retries.


Daryl


jm@apache.org wrote:
> Author: jm
> Date: Mon Sep 24 04:58:55 2007
> New Revision: 578771
> 
> URL: http://svn.apache.org/viewvc?rev=578771&view=rev
> Log:
> massively increase retry timeout for client-server mass-check; the SA zone can take an extremely long time due to its crappy I/O performance
> 
> Modified:
>     spamassassin/trunk/masses/mass-check
> 
> Modified: spamassassin/trunk/masses/mass-check
> URL: http://svn.apache.org/viewvc/spamassassin/trunk/masses/mass-check?rev=578771&r1=578770&r2=578771&view=diff
> ==============================================================================
> --- spamassassin/trunk/masses/mass-check (original)
> +++ spamassassin/trunk/masses/mass-check Mon Sep 24 04:58:55 2007
> @@ -1716,7 +1716,10 @@
>    }
>  
>    my $made_conn_once = 0;
> -  my $conn_retries = 60;        # 1 hour
> +
> +  # 6 hours; it can take the SpamAssassin zone this long to perform the
> +  # scan stage if the ArchiveIterator cache is cold
> +  my $conn_retries = 60 * 6;
>  
>    # keep going until something stops us.
>    while (1) {
> 
>