[GitHub] [pulsar] nodece commented on pull request #20611: [cleanup][test] Remove and prevent junit

["nodece (via GitHub)" <gi...@apache.org>]

nodece commented on PR #20611:
URL: https://github.com/apache/pulsar/pull/20611#issuecomment-1598027721

   > LGTM.
   > 
   > It's possible to exclude junit dependency from the testcontainers one? 
   
   We can exclude junit from the testcontainers, but we need to add a patch, see this comment from https://github.com/testcontainers/testcontainers-java/issues/970:
   
   > https://github.com/testcontainers/testcontainers-java/issues/970#issuecomment-625044008 and https://github.com/testcontainers/testcontainers-java/issues/970#issuecomment-629479506. Exclude junit4 and add workaround module with the empty classes. Not a perfect solution, but I've been using this setup locally for some time without issues so far.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org