You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/04/06 09:37:59 UTC

[GitHub] [camel-website] aashnajena commented on a change in pull request #319: Fix redirecting to anchor tags

aashnajena commented on a change in pull request #319: Fix redirecting to anchor tags
URL: https://github.com/apache/camel-website/pull/319#discussion_r403956932
 
 

 ##########
 File path: antora-ui-camel/src/js/02-fragment-jumper.js
 ##########
 @@ -1,6 +1,10 @@
 ;(function () {
   'use strict'
 
+  var shiftWindow = function () { window.scrollBy(0, -80) }
 
 Review comment:
   Sure, makes sense. I'm thinking I can find the height of the navbar and add some buffer to it for scrolling. Shouldn't be a long calculation.
   
   Also, can you confirm if the rest of the code in the file is needed? I think it was meant to do this job, but I'm not sure if it serves any other purpose as well. Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services