You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/12/10 19:50:01 UTC
[GitHub] [iceberg] kbendick opened a new pull request #3713: [Flink] Update flink-runtime jar naming to put Flink version at the end
kbendick opened a new pull request #3713:
URL: https://github.com/apache/iceberg/pull/3713
This PR changes the JAR / task names for different Flink versions, to have the version number at the very end.
This makes the jars alphabetically ordered and also places all words before version numbers.
This also is consistent with how we version our Spark runtime jars.
Current: `iceberg-1.14-runtime` and `iceberg-1.14`, `iceberg-1.13-runtime` and `iceberg-1.13
Proposed: `iceberg-runtime-1.14`, `iceberg-runtime-1.13` and `iceberg-1.13` , etc
cc @rdblue @stevenzwu @aokolnychyi @RussellSpitzer @openinx and I believe @wypoon handled the first version change for Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on pull request #3713: [Flink] Update flink-runtime jar naming with flink version at the end (like we do with Spark)
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on pull request #3713:
URL: https://github.com/apache/iceberg/pull/3713#issuecomment-991401205
LGTM. this makes sense. and since we haven't release 0.13, now it is a good time to change/fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #3713: [Flink] Update flink-runtime jar naming with flink version at the end (like we do with Spark)
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #3713:
URL: https://github.com/apache/iceberg/pull/3713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] wypoon commented on pull request #3713: [Flink] Update flink-runtime jar naming with flink version at the end (like we do with Spark)
Posted by GitBox <gi...@apache.org>.
wypoon commented on pull request #3713:
URL: https://github.com/apache/iceberg/pull/3713#issuecomment-991831065
The change makes sense. LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3713: [Flink] Update flink-runtime jar naming with flink version at the end (like we do with Spark)
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3713:
URL: https://github.com/apache/iceberg/pull/3713#issuecomment-991949219
Thanks, @kbendick!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] wypoon commented on pull request #3713: [Flink] Update flink-runtime jar naming with flink version at the end (like we do with Spark)
Posted by GitBox <gi...@apache.org>.
wypoon commented on pull request #3713:
URL: https://github.com/apache/iceberg/pull/3713#issuecomment-991831065
The change makes sense. LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3713: [Flink] Update flink-runtime jar naming with flink version at the end (like we do with Spark)
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3713:
URL: https://github.com/apache/iceberg/pull/3713#issuecomment-991264285
Looks good to me. @openinx and @stevenzwu, any objections?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3713: [Flink] Update flink-runtime jar naming with flink version at the end (like we do with Spark)
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3713:
URL: https://github.com/apache/iceberg/pull/3713#issuecomment-991264285
Looks good to me. @openinx and @stevenzwu, any objections?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on pull request #3713: [Flink] Update flink-runtime jar naming with flink version at the end (like we do with Spark)
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on pull request #3713:
URL: https://github.com/apache/iceberg/pull/3713#issuecomment-991401205
LGTM. this makes sense. and since we haven't release 0.13, now it is a good time to change/fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org