You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/03/16 14:06:22 UTC
[GitHub] [tvm] pfk-beta opened a new pull request #10641: query rpc tracker - sort servers by key name
pfk-beta opened a new pull request #10641:
URL: https://github.com/apache/tvm/pull/10641
Hello,
I have created simple PR, currenly when I have multiple RPC server I can see then in random order, another issue is that ip address can have different length, e.g. 1.1.1.1 is 7, and 255.255.255.255 is 15, so the output may looks like:
```
Server List
----------------------------
server-address key
----------------------------
172.31.8.8:5001 server:prague
172.31.8.3:5001 server:plex
172.31.8.12:5001 server:plex
172.31.8.4:5001 server:prague
172.31.8.13:5001 server:plex
172.31.8.5:5001 server:prague
172.31.8.13:5001 server:plex
----------------------------
```
after my changes:
```
Server List
------------------------------
server-address key
------------------------------
172.31.8.12:5001 server:plex
172.31.8.3:5001 server:plex
172.31.8.13:5001 server:plex
172.31.8.13:5001 server:plex
172.31.8.8:5001 server:prague
172.31.8.4:5001 server:prague
172.31.8.5:5001 server:prague
------------------------------
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] kparzysz-quic merged pull request #10641: query rpc tracker - sort servers by key name
Posted by GitBox <gi...@apache.org>.
kparzysz-quic merged pull request #10641:
URL: https://github.com/apache/tvm/pull/10641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] pfk-beta commented on pull request #10641: query rpc tracker - sort servers by key name
Posted by GitBox <gi...@apache.org>.
pfk-beta commented on pull request #10641:
URL: https://github.com/apache/tvm/pull/10641#issuecomment-1069166507
another issue, when I review client code, is that `total_ct` can be converted to `defaultdict(int)`, and computing `max_key_len` can be shortened to `if-condition-assignment`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org