You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by lu...@apache.org on 2009/07/20 18:29:46 UTC

svn commit: r795903 - in /commons/proper/math/trunk/src: java/org/apache/commons/math/fraction/Fraction.java test/org/apache/commons/math/fraction/FractionTest.java

Author: luc
Date: Mon Jul 20 16:29:46 2009
New Revision: 795903

URL: http://svn.apache.org/viewvc?rev=795903&view=rev
Log:
added test for Fraction serialization

Modified:
    commons/proper/math/trunk/src/java/org/apache/commons/math/fraction/Fraction.java
    commons/proper/math/trunk/src/test/org/apache/commons/math/fraction/FractionTest.java

Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/fraction/Fraction.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/fraction/Fraction.java?rev=795903&r1=795902&r2=795903&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/fraction/Fraction.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/fraction/Fraction.java Mon Jul 20 16:29:46 2009
@@ -31,9 +31,9 @@
  * @since 1.1
  * @version $Revision$ $Date$
  */
-public class Fraction extends Number implements FieldElement<Fraction>, Comparable<Fraction>, Serializable {
-    // TODO: Add Serializable documentation
-    // TODO: Check Serializable implementation
+public class Fraction
+    extends Number
+    implements FieldElement<Fraction>, Comparable<Fraction>, Serializable {
 
     /** A fraction representing "2 / 1". */
     public static final Fraction TWO = new Fraction(2, 1);

Modified: commons/proper/math/trunk/src/test/org/apache/commons/math/fraction/FractionTest.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/org/apache/commons/math/fraction/FractionTest.java?rev=795903&r1=795902&r2=795903&view=diff
==============================================================================
--- commons/proper/math/trunk/src/test/org/apache/commons/math/fraction/FractionTest.java (original)
+++ commons/proper/math/trunk/src/test/org/apache/commons/math/fraction/FractionTest.java Mon Jul 20 16:29:46 2009
@@ -17,6 +17,7 @@
 package org.apache.commons.math.fraction;
 
 import org.apache.commons.math.ConvergenceException;
+import org.apache.commons.math.TestUtils;
 
 import junit.framework.TestCase;
 
@@ -570,4 +571,16 @@
         assertEquals("3", new Fraction(6, 2).toString());
         assertEquals("2 / 3", new Fraction(18, 27).toString());
     }
+
+    public void testSerial() throws FractionConversionException {
+        Fraction[] fractions = {
+            new Fraction(3, 4), Fraction.ONE, Fraction.ZERO,
+            new Fraction(17), new Fraction(Math.PI, 1000),
+            new Fraction(-5, 2)
+        };
+        for (Fraction fraction : fractions) {
+            assertEquals(fraction, TestUtils.serializeAndRecover(fraction));
+        }
+    }
+
 }