You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/04/01 04:10:20 UTC

Review Request 45575: Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45575/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Bugs: MESOS-5047
    https://issues.apache.org/jira/browse/MESOS-5047


Repository: mesos


Description
-------

Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.


Diffs
-----

  src/tests/containerizer/cgroups_isolator_tests.cpp c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45575/diff/


Testing
-------


Thanks,

haosdent huang


Re: Review Request 45575: Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45575/#review126914
-----------------------------------------------------------



Patch looks great!

Reviews applied: [45083, 45084, 45350, 45085, 45086, 45087, 45351, 45352, 45353, 45354, 45362, 45363, 45364, 45472, 45473, 43283, 43284, 45573, 45574, 45575]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 4, 2016, 5:23 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45575/
> -----------------------------------------------------------
> 
> (Updated April 4, 2016, 5:23 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and Kevin Klues.
> 
> 
> Bugs: MESOS-5047
>     https://issues.apache.org/jira/browse/MESOS-5047
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp c4e467c8227f9e4129b05d173812592f39a04e06 
> 
> Diff: https://reviews.apache.org/r/45575/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Re: Review Request 45575: Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45575/
-----------------------------------------------------------

(Updated April 16, 2016, 10:19 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and Kevin Klues.


Bugs: MESOS-5047
    https://issues.apache.org/jira/browse/MESOS-5047


Repository: mesos


Description
-------

Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.


Diffs
-----

  src/tests/containerizer/cgroups_isolator_tests.cpp c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45575/diff/


Testing
-------


Thanks,

haosdent huang


Re: Review Request 45575: Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45575/
-----------------------------------------------------------

(Updated April 4, 2016, 5:23 p.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and Kevin Klues.


Changes
-------

Rebase and update reviewers.


Bugs: MESOS-5047
    https://issues.apache.org/jira/browse/MESOS-5047


Repository: mesos


Description
-------

Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.


Diffs (updated)
-----

  src/tests/containerizer/cgroups_isolator_tests.cpp c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45575/diff/


Testing
-------


Thanks,

haosdent huang


Re: Review Request 45575: Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45575/#review126576
-----------------------------------------------------------



Patch looks great!

Reviews applied: [45083, 45084, 45350, 45085, 45086, 45087, 45351, 45352, 45353, 45354, 45362, 45363, 45364, 45472, 45473, 43283, 43284, 45573, 45574, 45575]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 1, 2016, 10:45 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45575/
> -----------------------------------------------------------
> 
> (Updated April 1, 2016, 10:45 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5047
>     https://issues.apache.org/jira/browse/MESOS-5047
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp c4e467c8227f9e4129b05d173812592f39a04e06 
> 
> Diff: https://reviews.apache.org/r/45575/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Re: Review Request 45575: Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45575/
-----------------------------------------------------------

(Updated April 1, 2016, 10:45 a.m.)


Review request for mesos and Jie Yu.


Changes
-------

Rebase.


Bugs: MESOS-5047
    https://issues.apache.org/jira/browse/MESOS-5047


Repository: mesos


Description
-------

Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.


Diffs (updated)
-----

  src/tests/containerizer/cgroups_isolator_tests.cpp c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45575/diff/


Testing
-------


Thanks,

haosdent huang


Re: Review Request 45575: Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45575/#review126552
-----------------------------------------------------------



Patch looks great!

Reviews applied: [45083, 45084, 45350, 45085, 45086, 45087, 45351, 45352, 45353, 45354, 45362, 45363, 45364, 45472, 45473, 43283, 45573, 45574, 45575]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 1, 2016, 2:10 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45575/
> -----------------------------------------------------------
> 
> (Updated April 1, 2016, 2:10 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5047
>     https://issues.apache.org/jira/browse/MESOS-5047
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp c4e467c8227f9e4129b05d173812592f39a04e06 
> 
> Diff: https://reviews.apache.org/r/45575/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>