[jira] [Resolved] (YUNIKORN-3482) invalidate node cache list only if impacted

["Manikandan R (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/YUNIKORN-3482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Manikandan R resolved YUNIKORN-3482.
------------------------------------
    Fix Version/s: 1.11.0
       Resolution: Fixed

> invalidate node cache list only if impacted
> -------------------------------------------
>
>                 Key: YUNIKORN-3482
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-3482
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: shim - kubernetes
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Aditya Maheshwari
>            Priority: Major
>              Labels: newbie, pull-request-available
>             Fix For: 1.11.0
>
>
> In YUNIKORN-3422 the node cache updates are properly locked. During code review the of that change a performance point was brought up. Currently we just blindly invalidate the slice without even checking if the pod or node is part of the slice.
> If the pod or node that gets manipulated fits the criteria we should invalidate the cached slice(s). If the node or pod is not in the slice we should not reset the slice.
> The only place that we do something currently in in {{updatePod}} that kind of check should be extended to {{removePod}}, {{removeNode}}, {{updateNode and {{addNode}}.
> The check in {{updatePod}} is not correct either. It just looks at the current pod and if it has an affinity set or not. Based on that it clears out the cache. It really should check if the node has changed: last pod with affinity removed or first one added. That should reduce the number of times the cache is rebuild.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org