[jira] [Commented] (GEODE-4456) Remove singleton calls from all tests in org.apache.geode.internal.cache

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426210#comment-16426210 ] 

ASF subversion and git services commented on GEODE-4456:
--------------------------------------------------------

Commit da1ce1c0da9f8d9feea27f54ba2b84c344102c55 in geode's branch refs/heads/develop from [~dschneider]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=da1ce1c ]

GEODE-4456: Remove singleton calls from all tests in org.apache.geode.internal.cache

* removed InternalDistributedSystem.getConnectedInstance call from TombstoneCreationJUnitTest
* Also the cache is now created in a @Before method and uses non-deprecated methods to create it.
* removed InternalDistributedSystem.getConnectedInstance call from ClientServerTransactionDUnitTest
* removed getAnyInstance calls in GridAdvisorDUnitTest


> Remove singleton calls from all tests in org.apache.geode.internal.cache
> ------------------------------------------------------------------------
>
>                 Key: GEODE-4456
>                 URL: https://issues.apache.org/jira/browse/GEODE-4456
>             Project: Geode
>          Issue Type: Sub-task
>          Components: regions, tests, transactions
>            Reporter: Kirk Lund
>            Assignee: Darrel Schneider
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> These tests in org.apache.geode.internal.cache invoke singleton getters.
> CacheFactory.getAnyInstance():
> * Bug37241DUnitTest
> * CommitFunction
> * GridAdvisorDUnitTest
> * NestedTransactionFunction
> * RollbackFunction
> * SingleHopStatsDUnitTest
> * UpdateVersionDUnitTest
> CacheFactory.getExisting(DistributedSystem):
> * PartitionedRegionTestHelper
> GemFireCacheImpl.getInstance():
> * DiskRegRecoveryJUnitTest
> * FixedPRSinglehopDUnitTest
> * NetSearchMessagingDUnitTest
> * RemoteCQTransactionDUnitTest
> * RemoteTransactionDUnitTest
> * SystemFailureDUnitTest
> GemFireCacheImpl.setInstanceForTests(GemFireCacheImpl):
> * ColocationHelperTest
> InternalDistributedSystem.getAnyInstance():
> * ClientServerTransactionDUnitTest
> * GridAdvisorDUnitTest
> InternalDistributedSystem.getConnectedInstance():
> * ClientServerTransactionDUnitTest
> * TombstoneCreationJUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)