You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/07/20 07:29:47 UTC

[GitHub] [hudi] xushiyan commented on a change in pull request #1849: [WIP] Externalize test classes' configs

xushiyan commented on a change in pull request #1849:
URL: https://github.com/apache/hudi/pull/1849#discussion_r457130487



##########
File path: hudi-client/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java
##########
@@ -274,6 +275,7 @@ public HoodieIndexConfig build() {
           DEFAULT_GLOBAL_SIMPLE_INDEX_PARALLELISM);
       setDefaultOnCondition(props, !props.containsKey(SIMPLE_INDEX_UPDATE_PARTITION_PATH),
           SIMPLE_INDEX_UPDATE_PARTITION_PATH, DEFAULT_SIMPLE_INDEX_UPDATE_PARTITION_PATH);
+      setDefaultOnCondition(props, !isHBaseIndexConfigSet, HoodieHBaseIndexConfig.newBuilder().fromProperties(props).build());

Review comment:
       @yanghua Maybe this can be done specially for HBase index. But I'm also open to leave it as is: any sub-config should be initialized regardless.
   
   ```suggestion
         setDefaultOnCondition(props, indexType==IndexType.HBASE && !isHBaseIndexConfigSet, HoodieHBaseIndexConfig.newBuilder().fromProperties(props).build());
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org