[GitHub] [geode] mhansonp commented on a diff in pull request #7629: GEODE-7875: fix create index gfsh command on partitioned region

[GitBox <gi...@apache.org>]

mhansonp commented on code in PR #7629:
URL: https://github.com/apache/geode/pull/7629#discussion_r870524698


##########
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/CreateIndexCommand.java:
##########
@@ -96,7 +96,7 @@ public ResultModel createIndex(@CliOption(key = CliStrings.CREATE_INDEX__NAME, m
             .createError("Region " + regionName + " does not exist in some of the groups.");
       }
       if (groups == null) {
-        // the calculatedGroups will have "cluster" value to indicate the "cluster" level, in thise
+        // the calculatedGroups will have "cluster" value to indicate the "cluster" level, in this
         // case

Review Comment:
   Super small nitpick, please combine weird comment lines like this.



##########
geode-dunit/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommandsIntegrationTestBase.java:
##########
@@ -136,7 +136,9 @@ public void testCannotCreateIndexWithExistingIndexName() throws Exception {
     csb.addOption(CliStrings.CREATE_INDEX__REGION, SEPARATOR + regionName);
     csb.addOption(CliStrings.CREATE_INDEX__TYPE, "hash");
 
-    gfsh.executeAndAssertThat(csb.toString()).statusIsError();
+    gfsh.executeAndAssertThat(csb.toString())
+        .statusIsSuccess()

Review Comment:
   Why would the status be success if there was a duplicate?



##########
geode-dunit/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommandsIntegrationTestBase.java:
##########
@@ -170,7 +172,7 @@ public void cannotCreateWithTheSameName() throws Exception {
     createSimpleIndexA();
     gfsh.executeAndAssertThat(
         "create index --name=indexA --expression=key --region=" + SEPARATOR + "regionA")
-        .statusIsError()
+        .statusIsSuccess()

Review Comment:
   Same as above, from a high level this seems like an error.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org