You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Mahadev konar (JIRA)" <ji...@apache.org> on 2009/03/27 06:11:50 UTC
[jira] Created: (ZOOKEEPER-355) make validatePath non public in
Zookeeper client api.
make validatePath non public in Zookeeper client api.
------------------------------------------------------
Key: ZOOKEEPER-355
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-355
Project: Zookeeper
Issue Type: Bug
Affects Versions: 3.1.0, 3.1.1
Reporter: Mahadev konar
Fix For: 3.2.0
make validatePath non public in Zookeeper client api.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-355) make validatePath non public in
Zookeeper client api.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-355:
-----------------------------------
Status: Patch Available (was: Open)
resubmitting - mahadev says fleepochtest should be fixed now.
> make validatePath non public in Zookeeper client api.
> ------------------------------------------------------
>
> Key: ZOOKEEPER-355
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-355
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.1, 3.1.0
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-355.patch
>
>
> make validatePath non public in Zookeeper client api.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-355) make validatePath non public in
Zookeeper client api.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-355:
--------------------------------------
Assignee: Patrick Hunt
> make validatePath non public in Zookeeper client api.
> ------------------------------------------------------
>
> Key: ZOOKEEPER-355
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-355
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
>
> make validatePath non public in Zookeeper client api.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-355) make validatePath non public in
Zookeeper client api.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-355:
-----------------------------------
Attachment: ZOOKEEPER-355.patch
This patch moves the method into common. It also fixes ZOOKEEPER-348 - we now correctly handle path validation when sequence flag is used. c/java and tests for both also updated.
> make validatePath non public in Zookeeper client api.
> ------------------------------------------------------
>
> Key: ZOOKEEPER-355
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-355
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-355.patch
>
>
> make validatePath non public in Zookeeper client api.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-355) make validatePath non public in
Zookeeper client api.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-355:
------------------------------------
Status: Patch Available (was: Open)
> make validatePath non public in Zookeeper client api.
> ------------------------------------------------------
>
> Key: ZOOKEEPER-355
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-355
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.1, 3.1.0
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-355.patch, ZOOKEEPER-355.patch
>
>
> make validatePath non public in Zookeeper client api.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-355) make validatePath non public in
Zookeeper client api.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698075#action_12698075 ]
Hudson commented on ZOOKEEPER-355:
----------------------------------
Integrated in ZooKeeper-trunk #278 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/278/])
Adding a file missed in -- . make validatePath non public in Zookeeper client api.
> make validatePath non public in Zookeeper client api.
> ------------------------------------------------------
>
> Key: ZOOKEEPER-355
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-355
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-355.patch, ZOOKEEPER-355.patch
>
>
> make validatePath non public in Zookeeper client api.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-355) make validatePath non public in
Zookeeper client api.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-355:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. thanks pat.
> make validatePath non public in Zookeeper client api.
> ------------------------------------------------------
>
> Key: ZOOKEEPER-355
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-355
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-355.patch, ZOOKEEPER-355.patch
>
>
> make validatePath non public in Zookeeper client api.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-355) make validatePath non public in
Zookeeper client api.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695628#action_12695628 ]
Hadoop QA commented on ZOOKEEPER-355:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12404602/ZOOKEEPER-355.patch
against trunk revision 761816.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/17/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/17/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/17/console
This message is automatically generated.
> make validatePath non public in Zookeeper client api.
> ------------------------------------------------------
>
> Key: ZOOKEEPER-355
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-355
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-355.patch
>
>
> make validatePath non public in Zookeeper client api.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-355) make validatePath non public in
Zookeeper client api.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695621#action_12695621 ]
Patrick Hunt commented on ZOOKEEPER-355:
----------------------------------------
the failed test is fletestepochwhich is unrelated to my changes and known to be failing.
Please review/commit this.
> make validatePath non public in Zookeeper client api.
> ------------------------------------------------------
>
> Key: ZOOKEEPER-355
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-355
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-355.patch
>
>
> make validatePath non public in Zookeeper client api.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-355) make validatePath non public in
Zookeeper client api.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-355:
------------------------------------
Status: Open (was: Patch Available)
> make validatePath non public in Zookeeper client api.
> ------------------------------------------------------
>
> Key: ZOOKEEPER-355
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-355
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.1, 3.1.0
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-355.patch, ZOOKEEPER-355.patch
>
>
> make validatePath non public in Zookeeper client api.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-355) make validatePath non public in
Zookeeper client api.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695618#action_12695618 ]
Hadoop QA commented on ZOOKEEPER-355:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12404602/ZOOKEEPER-355.patch
against trunk revision 761811.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/15/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/15/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/15/console
This message is automatically generated.
> make validatePath non public in Zookeeper client api.
> ------------------------------------------------------
>
> Key: ZOOKEEPER-355
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-355
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-355.patch
>
>
> make validatePath non public in Zookeeper client api.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-355) make validatePath non public in
Zookeeper client api.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12697348#action_12697348 ]
Hadoop QA commented on ZOOKEEPER-355:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12404921/ZOOKEEPER-355.patch
against trunk revision 763435.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/23/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/23/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/23/console
This message is automatically generated.
> make validatePath non public in Zookeeper client api.
> ------------------------------------------------------
>
> Key: ZOOKEEPER-355
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-355
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-355.patch, ZOOKEEPER-355.patch
>
>
> make validatePath non public in Zookeeper client api.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-355) make validatePath non public in
Zookeeper client api.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12697857#action_12697857 ]
Patrick Hunt commented on ZOOKEEPER-355:
----------------------------------------
I added a file missed by the previous commit:
Committed revision 763973.
> make validatePath non public in Zookeeper client api.
> ------------------------------------------------------
>
> Key: ZOOKEEPER-355
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-355
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-355.patch, ZOOKEEPER-355.patch
>
>
> make validatePath non public in Zookeeper client api.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-355) make validatePath non public in
Zookeeper client api.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-355:
------------------------------------
Attachment: ZOOKEEPER-355.patch
made a minor change,
created another methoda that is
{code}
validatePath(path, issequential)
{code}
keeping the old method
{code}
validatePath(path)
{code}
just reduces some line of code :) and makes it similar to c code structure where validatePath is called with issequential. other than that +1 for the patch..
> make validatePath non public in Zookeeper client api.
> ------------------------------------------------------
>
> Key: ZOOKEEPER-355
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-355
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-355.patch, ZOOKEEPER-355.patch
>
>
> make validatePath non public in Zookeeper client api.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-355) make validatePath non public in
Zookeeper client api.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-355:
-----------------------------------
Status: Patch Available (was: Open)
> make validatePath non public in Zookeeper client api.
> ------------------------------------------------------
>
> Key: ZOOKEEPER-355
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-355
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.1, 3.1.0
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-355.patch
>
>
> make validatePath non public in Zookeeper client api.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-355) make validatePath non public in
Zookeeper client api.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-355:
-----------------------------------
Status: Open (was: Patch Available)
> make validatePath non public in Zookeeper client api.
> ------------------------------------------------------
>
> Key: ZOOKEEPER-355
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-355
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.1, 3.1.0
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-355.patch
>
>
> make validatePath non public in Zookeeper client api.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.