You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by GitBox <gi...@apache.org> on 2022/11/28 06:56:50 UTC

[GitHub] [servicemix-maven-plugins] laeubi opened a new pull request, #8: Create Github Action Verification

laeubi opened a new pull request, #8:
URL: https://github.com/apache/servicemix-maven-plugins/pull/8

   Having an automated verification build helps with contributing to this repository.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@servicemix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Create Github Action Verification [servicemix-maven-plugins]

Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd merged PR #8:
URL: https://github.com/apache/servicemix-maven-plugins/pull/8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@servicemix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Create Github Action Verification [servicemix-maven-plugins]

Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #8:
URL: https://github.com/apache/servicemix-maven-plugins/pull/8#issuecomment-1831309382

   Thanks for the reminder and the merge @oscerd !
   I forgot this one. LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@servicemix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Create Github Action Verification [servicemix-maven-plugins]

Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on code in PR #8:
URL: https://github.com/apache/servicemix-maven-plugins/pull/8#discussion_r1408788303


##########
.github/workflows/maven.yml:
##########
@@ -0,0 +1,35 @@
+# This workflow will build a Java project with Maven, and cache/restore any dependencies to improve the workflow execution time
+# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-java-with-maven
+
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+
+name: Java CI with Maven
+
+on:
+  push:
+    branches: [ "master" ]
+  pull_request:
+    branches: [ "master" ]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v3
+    - name: Set up JDK 11
+      uses: actions/setup-java@v3
+      with:
+        java-version: '11'
+        distribution: 'temurin'
+        cache: maven
+    - name: Build with Maven
+      run: mvn -B package --file pom.xml
+
+    # Optional: Uploads the full dependency graph to GitHub to improve the quality of Dependabot alerts this repository can receive
+    - name: Update dependency graph
+      uses: advanced-security/maven-dependency-submission-action@571e99aab1055c2e71a1e2309b9691de18d6b7d6

Review Comment:
   Is there a reason for pointing to that commit?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@servicemix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [servicemix-maven-plugins] laeubi commented on pull request #8: Create Github Action Verification

Posted by GitBox <gi...@apache.org>.
laeubi commented on PR #8:
URL: https://github.com/apache/servicemix-maven-plugins/pull/8#issuecomment-1328648372

   @jbonofre can you take a look here also?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@servicemix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Create Github Action Verification [servicemix-maven-plugins]

Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on code in PR #8:
URL: https://github.com/apache/servicemix-maven-plugins/pull/8#discussion_r1408798831


##########
.github/workflows/maven.yml:
##########
@@ -0,0 +1,35 @@
+# This workflow will build a Java project with Maven, and cache/restore any dependencies to improve the workflow execution time
+# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-java-with-maven
+
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+
+name: Java CI with Maven
+
+on:
+  push:
+    branches: [ "master" ]
+  pull_request:
+    branches: [ "master" ]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v3
+    - name: Set up JDK 11
+      uses: actions/setup-java@v3
+      with:
+        java-version: '11'
+        distribution: 'temurin'
+        cache: maven
+    - name: Build with Maven
+      run: mvn -B package --file pom.xml
+
+    # Optional: Uploads the full dependency graph to GitHub to improve the quality of Dependabot alerts this repository can receive
+    - name: Update dependency graph
+      uses: advanced-security/maven-dependency-submission-action@571e99aab1055c2e71a1e2309b9691de18d6b7d6

Review Comment:
   Let's merge



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@servicemix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Create Github Action Verification [servicemix-maven-plugins]

Posted by "laeubi (via GitHub)" <gi...@apache.org>.
laeubi commented on code in PR #8:
URL: https://github.com/apache/servicemix-maven-plugins/pull/8#discussion_r1408798095


##########
.github/workflows/maven.yml:
##########
@@ -0,0 +1,35 @@
+# This workflow will build a Java project with Maven, and cache/restore any dependencies to improve the workflow execution time
+# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-java-with-maven
+
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+
+name: Java CI with Maven
+
+on:
+  push:
+    branches: [ "master" ]
+  pull_request:
+    branches: [ "master" ]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v3
+    - name: Set up JDK 11
+      uses: actions/setup-java@v3
+      with:
+        java-version: '11'
+        distribution: 'temurin'
+        cache: maven
+    - name: Build with Maven
+      run: mvn -B package --file pom.xml
+
+    # Optional: Uploads the full dependency graph to GitHub to improve the quality of Dependabot alerts this repository can receive
+    - name: Update dependency graph
+      uses: advanced-security/maven-dependency-submission-action@571e99aab1055c2e71a1e2309b9691de18d6b7d6

Review Comment:
   It was suggested by github at the time of my PR, maybe one need to update it in the meanwhile :-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@servicemix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Create Github Action Verification [servicemix-maven-plugins]

Posted by "laeubi (via GitHub)" <gi...@apache.org>.
laeubi commented on PR #8:
URL: https://github.com/apache/servicemix-maven-plugins/pull/8#issuecomment-1831273628

   Anyone? :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@servicemix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org