You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/20 09:51:05 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons
HyukjinKwon commented on a change in pull request #28580:
URL: https://github.com/apache/spark/pull/28580#discussion_r427883652
##########
File path: sbin/spark-daemon.sh
##########
@@ -74,10 +75,13 @@ shift
spark_rotate_log ()
{
log=$1;
- num=5;
- if [ -n "$2" ]; then
- num=$2
+
+ if [[ ${SPARK_LOG_MAX_FILES} -gt 5 ]] 2>/dev/null; then
Review comment:
why do we redirect to dev/null?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org