You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/02/08 17:55:14 UTC
[GitHub] [solr] risdenk opened a new pull request #612: SOLR-15987: Remove ant-compat/force-versions.gradle
risdenk opened a new pull request #612:
URL: https://github.com/apache/solr/pull/612
https://issues.apache.org/jira/browse/SOLR-15987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #612: SOLR-15987: Upgrade slf4j to 1.7.35 and remove ant-compat/force-versions.gradle
Posted by GitBox <gi...@apache.org>.
risdenk commented on pull request #612:
URL: https://github.com/apache/solr/pull/612#issuecomment-1033739712
Added solr/CHANGES.txt and updated the commit message to call out the slf4j upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dweiss commented on pull request #612: SOLR-15987: Remove ant-compat/force-versions.gradle
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #612:
URL: https://github.com/apache/solr/pull/612#issuecomment-1033435355
> There is really no good reason these versions are pegged to this. https://github.com/apache/solr/commits/main/gradle/ant-compat/force-versions.gradle just shows it was to "match the ant build".
Yep, this was done to make the gradle build produce identical outputs as ant. Otherwise palantir's consistent versions would have picked the highest version of a dependency from those available in the dependency set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #612: SOLR-15987: Remove ant-compat/force-versions.gradle
Posted by GitBox <gi...@apache.org>.
risdenk commented on pull request #612:
URL: https://github.com/apache/solr/pull/612#issuecomment-1032954567
FWIW commons-logging will get cleaned up in SOLR-15992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a change in pull request #612: SOLR-15987: Remove ant-compat/force-versions.gradle
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #612:
URL: https://github.com/apache/solr/pull/612#discussion_r801932650
##########
File path: solr/licenses/slf4j-api-1.7.25.jar.sha1
##########
@@ -0,0 +1 @@
+da76ca59f6a57ee3102f8f9bd9cee742973efa8a
Review comment:
It's strange that we are getting 1.7.25 (here) and also 1.7.30 resolved...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #612: SOLR-15987: Remove ant-compat/force-versions.gradle
Posted by GitBox <gi...@apache.org>.
risdenk commented on pull request #612:
URL: https://github.com/apache/solr/pull/612#issuecomment-1033126549
@dsmiley yea thats fine. I wasn't planning on upgrading slf4j, but there is no way with the current build to keep a specific version - except with what is being removed here. There is really no good reason these versions are pegged to this. https://github.com/apache/solr/commits/main/gradle/ant-compat/force-versions.gradle just shows it was to "match the ant build".
So the tl;dr is that this shouldn't be here (see comments about all these ant-compat files) and sure can call out more detail about the upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk merged pull request #612: SOLR-15987: Upgrade slf4j to 1.7.35 and remove ant-compat/force-versions.gradle
Posted by GitBox <gi...@apache.org>.
risdenk merged pull request #612:
URL: https://github.com/apache/solr/pull/612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a change in pull request #612: SOLR-15987: Remove ant-compat/force-versions.gradle
Posted by GitBox <gi...@apache.org>.
risdenk commented on a change in pull request #612:
URL: https://github.com/apache/solr/pull/612#discussion_r801943719
##########
File path: solr/licenses/slf4j-api-1.7.25.jar.sha1
##########
@@ -0,0 +1 @@
+da76ca59f6a57ee3102f8f9bd9cee742973efa8a
Review comment:
Fixed in 791af33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a change in pull request #612: SOLR-15987: Remove ant-compat/force-versions.gradle
Posted by GitBox <gi...@apache.org>.
risdenk commented on a change in pull request #612:
URL: https://github.com/apache/solr/pull/612#discussion_r801934179
##########
File path: solr/licenses/slf4j-api-1.7.25.jar.sha1
##########
@@ -0,0 +1 @@
+da76ca59f6a57ee3102f8f9bd9cee742973efa8a
Review comment:
Good catch - most likely transitive dependency resolution across all the modules. Its easy to force to 1.7.30 in versions.props. I didn't bump it but probably should.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org